This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/selinux/packages/targeted [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40511 bytes in 8 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make %{?_smp_mflags} macro. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nvidia- container-toolkit-operator-extensions , nvidia-container-toolkit- selinux , golang-github-nvidia-container-toolkit-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nvidia-container-toolkit-1.17.2-1.fc40.aarch64.rpm nvidia-container-toolkit-operator-extensions-1.17.2-1.fc40.aarch64.rpm nvidia-container-toolkit-selinux-1.17.2-1.fc40.noarch.rpm golang-github-nvidia-container-toolkit-devel-1.17.2-1.fc40.noarch.rpm nvidia-container-toolkit-1.17.2-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8w5c3gs0')] checks: 32, packages: 5 nvidia-container-toolkit.aarch64: W: no-manual-page-for-binary nvidia-cdi-hook nvidia-container-toolkit.aarch64: W: no-manual-page-for-binary nvidia-container-runtime nvidia-container-toolkit.aarch64: W: no-manual-page-for-binary nvidia-container-runtime-hook nvidia-container-toolkit.aarch64: W: no-manual-page-for-binary nvidia-ctk nvidia-container-toolkit-operator-extensions.aarch64: W: no-manual-page-for-binary nvidia-container-runtime.cdi nvidia-container-toolkit-operator-extensions.aarch64: W: no-manual-page-for-binary nvidia-container-runtime.legacy golang-github-nvidia-container-toolkit-devel.noarch: W: no-documentation nvidia-container-toolkit-operator-extensions.aarch64: W: no-documentation nvidia-container-toolkit.spec: W: invalid-url Source1: nvidia-container-toolkit-1.17.2-vendor.tar.bz2 golang-github-nvidia-container-toolkit-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/NVIDIA/nvidia-container-toolkit/.goipath nvidia-container-toolkit.aarch64: W: files-duplicate /usr/share/licenses/nvidia-container-toolkit/vendor/github.com/moby/sys/symlink/LICENSE /usr/share/licenses/nvidia-container-toolkit/LICENSE:/usr/share/licenses/nvidia-container-toolkit/packaging/rpm/SOURCES/LICENSE:/usr/share/licenses/nvidia-container-toolkit/vendor/github.com/NVIDIA/go-nvlib/LICENSE:/usr/share/licenses/nvidia-container-toolkit/vendor/github.com/NVIDIA/go-nvml/LICENSE nvidia-container-toolkit.aarch64: W: files-duplicate /usr/share/licenses/nvidia-container-toolkit/vendor/github.com/opencontainers/runtime-tools/LICENSE /usr/share/licenses/nvidia-container-toolkit/vendor/github.com/opencontainers/runtime-spec/LICENSE nvidia-container-toolkit.aarch64: W: files-duplicate /usr/share/licenses/nvidia-container-toolkit/vendor/golang.org/x/sys/LICENSE /usr/share/licenses/nvidia-container-toolkit/vendor/golang.org/x/mod/LICENSE nvidia-container-toolkit.aarch64: W: files-duplicate /usr/share/licenses/nvidia-container-toolkit/vendor/golang.org/x/sys/PATENTS /usr/share/licenses/nvidia-container-toolkit/vendor/golang.org/x/mod/PATENTS nvidia-container-toolkit.aarch64: W: files-duplicate /usr/share/licenses/nvidia-container-toolkit/vendor/gopkg.in/yaml.v3/NOTICE /usr/share/licenses/nvidia-container-toolkit/vendor/gopkg.in/yaml.v2/NOTICE nvidia-container-toolkit.aarch64: W: files-duplicate /usr/share/licenses/nvidia-container-toolkit/vendor/tags.cncf.io/container-device-interface/specs-go/LICENSE /usr/share/licenses/nvidia-container-toolkit/vendor/tags.cncf.io/container-device-interface/LICENSE nvidia-container-toolkit-selinux.noarch: W: dangerous-command-in-%postun rm nvidia-container-toolkit-selinux.noarch: W: dangerous-command-in-%post install 5 packages and 0 specfiles checked; 0 errors, 18 warnings, 18 filtered, 0 badness; has taken 1.0 s Rpmlint (debuginfo) ------------------- Checking: nvidia-container-toolkit-debuginfo-1.17.2-1.fc40.aarch64.rpm nvidia-container-toolkit-operator-extensions-debuginfo-1.17.2-1.fc40.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8xj2p3qu')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 18 filtered, 0 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "nvidia-container-toolkit-operator-extensions". (none): E: there is no installed rpm "nvidia-container-toolkit-operator-extensions-debuginfo". (none): E: there is no installed rpm "golang-github-nvidia-container-toolkit-devel". (none): E: there is no installed rpm "nvidia-container-toolkit-debuginfo". (none): E: there is no installed rpm "nvidia-container-toolkit". (none): E: there is no installed rpm "nvidia-container-toolkit-selinux". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/NVIDIA/dgx-selinux/archive/b988ea65e7b43009a705eb5e5d7e94048f916734/dgx-selinux-b988ea65e7b43009a705eb5e5d7e94048f916734.tar.gz : CHECKSUM(SHA256) this package : 3b55709591676bf693adde6daf3110f6cb4967f2c758d0ba2f1f4703b4cf778c CHECKSUM(SHA256) upstream package : 3b55709591676bf693adde6daf3110f6cb4967f2c758d0ba2f1f4703b4cf778c https://github.com/NVIDIA/nvidia-container-toolkit/archive/v1.17.2/nvidia-container-toolkit-1.17.2.tar.gz : CHECKSUM(SHA256) this package : 2233415cae3476e24d0c15a13843f62471dbc36570450ce6c7a03c0aa45d326f CHECKSUM(SHA256) upstream package : 2233415cae3476e24d0c15a13843f62471dbc36570450ce6c7a03c0aa45d326f Requires -------- nvidia-container-toolkit (rpmlib, GLIBC filtered): libc.so.6()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) nvidia-container-toolkit-operator-extensions (rpmlib, GLIBC filtered): libc.so.6()(64bit) libresolv.so.2()(64bit) nvidia-container-toolkit rtld(GNU_HASH) nvidia-container-toolkit-selinux (rpmlib, GLIBC filtered): (container-selinux >= 2.213 if selinux-policy-targeted) /bin/sh nvidia-container-toolkit policycoreutils selinux-policy golang-github-nvidia-container-toolkit-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/NVIDIA/go-nvlib/pkg/nvlib/device) golang(github.com/NVIDIA/go-nvlib/pkg/nvlib/info) golang(github.com/NVIDIA/go-nvlib/pkg/nvpci) golang(github.com/NVIDIA/go-nvml/pkg/dl) golang(github.com/NVIDIA/go-nvml/pkg/nvml) golang(github.com/fsnotify/fsnotify) golang(github.com/moby/sys/symlink) golang(github.com/opencontainers/runtime-spec/specs-go) golang(github.com/pelletier/go-toml) golang(github.com/sirupsen/logrus) golang(github.com/urfave/cli/v2) golang(golang.org/x/mod/semver) golang(golang.org/x/sys/unix) golang(tags.cncf.io/container-device-interface/pkg/cdi) golang(tags.cncf.io/container-device-interface/pkg/parser) golang(tags.cncf.io/container-device-interface/specs-go) Provides -------- nvidia-container-toolkit: bundled(golang(github.com/NVIDIA/go-nvlib)) bundled(golang(github.com/NVIDIA/go-nvml)) bundled(golang(github.com/cpuguy83/go-md2man/v2)) bundled(golang(github.com/davecgh/go-spew)) bundled(golang(github.com/fsnotify/fsnotify)) bundled(golang(github.com/google/uuid)) bundled(golang(github.com/hashicorp/errwrap)) bundled(golang(github.com/kr/pretty)) bundled(golang(github.com/moby/sys/symlink)) bundled(golang(github.com/opencontainers/runtime-spec)) bundled(golang(github.com/opencontainers/runtime-tools)) bundled(golang(github.com/opencontainers/selinux)) bundled(golang(github.com/pelletier/go-toml)) bundled(golang(github.com/pmezard/go-difflib)) bundled(golang(github.com/russross/blackfriday/v2)) bundled(golang(github.com/sirupsen/logrus)) bundled(golang(github.com/stretchr/testify)) bundled(golang(github.com/syndtr/gocapability)) bundled(golang(github.com/urfave/cli/v2)) bundled(golang(github.com/xeipuuv/gojsonpointer)) bundled(golang(github.com/xrash/smetrics)) bundled(golang(golang.org/x/mod)) bundled(golang(golang.org/x/sys)) bundled(golang(gopkg.in/check.v1)) bundled(golang(gopkg.in/yaml.v2)) bundled(golang(gopkg.in/yaml.v3)) bundled(golang(sigs.k8s.io/yaml)) bundled(golang(tags.cncf.io/container-device-interface)) bundled(golang(tags.cncf.io/container-device-interface/specs-go)) nvidia-container-toolkit nvidia-container-toolkit(aarch-64) nvidia-container-toolkit-operator-extensions: nvidia-container-toolkit-operator-extensions nvidia-container-toolkit-operator-extensions(aarch-64) nvidia-container-toolkit-selinux: nvidia-container-toolkit-selinux golang-github-nvidia-container-toolkit-devel: golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-cdi-hook/chmod) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-cdi-hook/commands) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-cdi-hook/create-symlinks) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-cdi-hook/update-ldcache) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/cdi) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/cdi/generate) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/cdi/list) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/cdi/transform) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/cdi/transform/root) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/config) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/config/create-default) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/config/flags) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/hook) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/info) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/runtime) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/runtime/configure) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/system) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/system/create-dev-char-symlinks) golang(github.com/NVIDIA/nvidia-container-toolkit/cmd/nvidia-ctk/system/create-device-nodes) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/config) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/config/image) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/cuda) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/discover) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/dxcore) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/edits) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/info) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/info/drm) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/info/proc) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/info/proc/devices) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/ldcache) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/logger) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/lookup) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/lookup/cuda) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/lookup/root) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/lookup/symlinks) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/modifier) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/modifier/cdi) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/nvcaps) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/nvsandboxutils) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/nvsandboxutils/mock) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/oci) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/platform-support/dgpu) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/platform-support/tegra) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/platform-support/tegra/csv) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/requirements) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/requirements/constraints) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/runtime) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/system/nvdevices) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/system/nvmodules) golang(github.com/NVIDIA/nvidia-container-toolkit/internal/test) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/config) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/config/engine) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/config/engine/containerd) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/config/engine/crio) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/config/engine/docker) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/config/ocihook) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/config/toml) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/spec) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/transform) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/transform/noop) golang(github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/transform/root) golang(github.com/NVIDIA/nvidia-container-toolkit/tools/container) golang(github.com/NVIDIA/nvidia-container-toolkit/tools/container/operator) golang(github.com/NVIDIA/nvidia-container-toolkit/tools/container/runtime) golang(github.com/NVIDIA/nvidia-container-toolkit/tools/container/runtime/containerd) golang(github.com/NVIDIA/nvidia-container-toolkit/tools/container/runtime/crio) golang(github.com/NVIDIA/nvidia-container-toolkit/tools/container/runtime/docker) golang(github.com/NVIDIA/nvidia-container-toolkit/tools/container/toolkit) golang-github-nvidia-container-toolkit-devel golang-ipath(github.com/NVIDIA/nvidia-container-toolkit) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nvidia-container-toolkit --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-40-aarch64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Haskell, Java, Perl, Ocaml, SugarActivity, R, Python, fonts, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH