{
  "issues": [
    {
      "result": "fail",
      "text": "Package does not use a name that already exists.",
      "note": "A package with this name already exists. Please check https://src.fedoraproject.org/rpms/jmdns",
      "name": "CheckNoNameConflict",
      "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names"
    },
    {
      "result": "fail",
      "text": "Javadoc documentation files are generated and included in -javadoc subpackage",
      "note": "No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21",
      "name": "CheckJavadoc",
      "url": "https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation"
    },
    {
      "result": "fail",
      "text": "Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)",
      "note": "No javadoc subpackage present",
      "name": "CheckJavadocdirName",
      "url": "https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation"
    }
  ],
  "results": {
    "MUST": {
      "Generic": [
        {
          "result": "pending",
          "text": "Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.",
          "note": null,
          "name": "CheckApprovedLicense",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/"
        },
        {
          "result": "pass",
          "text": "Package uses either %{buildroot} or $RPM_BUILD_ROOT",
          "note": null,
          "name": "CheckBuildrootMacros",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros"
        },
        {
          "result": "pending",
          "text": "Package contains no bundled libraries without FPC exception.",
          "note": null,
          "name": "CheckBundledLibs",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling"
        },
        {
          "result": "pending",
          "text": "Changelog in prescribed format.",
          "note": null,
          "name": "CheckChangelogFormat",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs"
        },
        {
          "result": "pass",
          "text": "Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install.",
          "note": null,
          "name": "CheckCleanBuildroot",
          "url": "(this test has no URL)"
        },
        {
          "result": "pending",
          "text": "Sources contain only permissible code or content.",
          "note": null,
          "name": "CheckCodeAndContent",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#_impermissible_content"
        },
        {
          "result": "pass",
          "text": "Macros in Summary, %description expandable at SRPM build time.",
          "note": null,
          "name": "CheckDescMacros",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_rpm_buildtime_macros"
        },
        {
          "result": "pending",
          "text": "Package contains desktop file if it is a GUI application.",
          "note": null,
          "name": "CheckDesktopFile",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files"
        },
        {
          "result": "pending",
          "text": "Development files must be in a -devel package",
          "note": null,
          "name": "CheckDevelFilesInDevel",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages"
        },
        {
          "result": "pass",
          "text": "Package requires other packages for directories it uses.",
          "note": null,
          "name": "CheckDirectoryRequire",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership"
        },
        {
          "result": "pass",
          "text": "Dist tag is present.",
          "note": null,
          "name": "CheckDistTag",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/"
        },
        {
          "result": "pending",
          "text": "Package uses nothing in %doc for runtime.",
          "note": null,
          "name": "CheckDocRuntime",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation"
        },
        {
          "result": "pass",
          "text": "Package does not contain duplicates in %files.",
          "note": null,
          "name": "CheckFileDuplicates",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_duplicate_files"
        },
        {
          "result": "pass",
          "text": "Permissions on files are set properly.",
          "note": null,
          "name": "CheckFilePermissions",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions"
        },
        {
          "result": "pending",
          "text": "Package complies to the Packaging Guidelines",
          "note": null,
          "name": "CheckGuidelines",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/"
        },
        {
          "result": "pass",
          "text": "Package must not depend on deprecated() packages.",
          "note": null,
          "name": "CheckIfDepsDeprecated",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/"
        },
        {
          "result": "pass",
          "text": "If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license.",
          "note": null,
          "name": "CheckLicensInDoc",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text"
        },
        {
          "result": "pending",
          "text": "License field in the package spec file matches the actual license.",
          "note": "Checking patched sources after %prep for licenses. Licenses found: \"Unknown or generated\", \"*No copyright* Apache License 2.0\", \"*No copyright* Apache License 2.0 GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]\", \"*No copyright* GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]\", \"Apache License 2.0\". 105 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/jmdns/licensecheck.txt",
          "name": "CheckLicenseField",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names"
        },
        {
          "result": "pass",
          "text": "The License field must be a valid SPDX expression.",
          "note": null,
          "name": "CheckLicenseFieldSPDX",
          "url": "https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1"
        },
        {
          "result": "pending",
          "text": "Package consistently uses macros (instead of hard-coded directory names).",
          "note": null,
          "name": "CheckMacros",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros"
        },
        {
          "result": "pass",
          "text": "Package use %makeinstall only when make install DESTDIR=... doesn't work.",
          "note": null,
          "name": "CheckMakeinstall",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_why_the_makeinstall_macro_should_not_be_used"
        },
        {
          "result": "pass",
          "text": "Package is named using only allowed ASCII characters.",
          "note": null,
          "name": "CheckNameCharset",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/"
        },
        {
          "result": "pending",
          "text": "Package is named according to the Package Naming Guidelines.",
          "note": null,
          "name": "CheckNaming",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/"
        },
        {
          "result": "pending",
          "text": "Package does not generate any conflict.",
          "note": null,
          "name": "CheckNoConflicts",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_conflicts"
        },
        {
          "result": "fail",
          "text": "Package does not use a name that already exists.",
          "note": "A package with this name already exists. Please check https://src.fedoraproject.org/rpms/jmdns",
          "name": "CheckNoNameConflict",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names"
        },
        {
          "result": "pending",
          "text": "Package obeys FHS, except libexecdir and /usr/target.",
          "note": null,
          "name": "CheckObeysFHS",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_filesystem_layout"
        },
        {
          "result": "pending",
          "text": "If the package is a rename of another package, proper Obsoletes and Provides are present.",
          "note": null,
          "name": "CheckObsoletesForRename",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages"
        },
        {
          "result": "pass",
          "text": "Package must own all directories that it creates.",
          "note": null,
          "name": "CheckOwnDirs",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership"
        },
        {
          "result": "pass",
          "text": "Package does not own files or directories owned by other packages.",
          "note": null,
          "name": "CheckOwnOther",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership"
        },
        {
          "result": "pass",
          "text": "Package is not relocatable.",
          "note": null,
          "name": "CheckRelocatable",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_relocatable_packages"
        },
        {
          "result": "pending",
          "text": "Requires correct, justified where necessary.",
          "note": null,
          "name": "CheckRequires",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires"
        },
        {
          "result": "pass",
          "text": "Sources used to build the package match the upstream source, as provided in the spec URL.",
          "note": null,
          "name": "CheckSourceMD5",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/"
        },
        {
          "result": "pending",
          "text": "Spec file is legible and written in American English.",
          "note": null,
          "name": "CheckSpecLegibility",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility"
        },
        {
          "result": "pass",
          "text": "Spec file name must match the spec package %{name}, in the format %{name}.spec.",
          "note": null,
          "name": "CheckSpecName",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming"
        },
        {
          "result": "pending",
          "text": "Package contains systemd file(s) if in need.",
          "note": null,
          "name": "CheckSystemdScripts",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/"
        },
        {
          "result": "pass",
          "text": "File names are valid UTF-8.",
          "note": null,
          "name": "CheckUTF8Filenames",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_non_ascii_filenames"
        },
        {
          "result": "pending",
          "text": "Package is not known to require an ExcludeArch tag.",
          "note": null,
          "name": "generic-excludearch",
          "url": "https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch"
        },
        {
          "result": "pending",
          "text": "Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files.",
          "note": "Documentation size is 11135 bytes in 1 files. ",
          "name": "generic-large-docs",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation"
        },
        {
          "result": "pass",
          "text": "Packages must not store files under /srv, /opt or /usr/local",
          "note": null,
          "name": "generic-srv-opt",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation"
        },
        {
          "result": "pending",
          "text": "Package successfully compiles and builds into binary rpms on at least one supported primary architecture.",
          "note": "Using prebuilt packages",
          "name": "CheckBuild",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support"
        },
        {
          "result": "pass",
          "text": "Package installs properly.",
          "note": null,
          "name": "CheckPackageInstalls",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/"
        },
        {
          "result": "pass",
          "text": "Rpmlint is run on all rpms the build produces.",
          "note": "No rpmlint messages.",
          "name": "CheckRpmlint",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint"
        }
      ],
      "Java": [
        {
          "result": "pass",
          "text": "Bundled jar/class files should be removed before build",
          "note": null,
          "name": "java-check-bundled-jars",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_pre_built_dependencies"
        },
        {
          "result": "pass",
          "text": "Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils)",
          "note": "Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local",
          "name": "CheckJPackageRequires",
          "url": "https://fedoraproject.org/wiki/Packaging:Java"
        },
        {
          "result": "fail",
          "text": "Javadoc documentation files are generated and included in -javadoc subpackage",
          "note": "No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21",
          "name": "CheckJavadoc",
          "url": "https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation"
        },
        {
          "result": "fail",
          "text": "Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)",
          "note": "No javadoc subpackage present",
          "name": "CheckJavadocdirName",
          "url": "https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation"
        }
      ],
      "Maven": [
        {
          "result": "pass",
          "text": "POM files have correct Maven mapping",
          "note": null,
          "name": "CheckAddMavenDepmap",
          "url": "https://fedoraproject.org/wiki/Packaging:Java#Maven_pom.xml_files"
        },
        {
          "result": "pass",
          "text": "Maven packages should use new style packaging",
          "note": null,
          "name": "CheckNewStyleMaven",
          "url": "https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven"
        },
        {
          "result": "pass",
          "text": "Old add_to_maven_depmap macro is not being used",
          "note": null,
          "name": "CheckNoOldMavenDepmap",
          "url": "https://fedoraproject.org/wiki/Packaging:Java#Maven_pom.xml_files"
        },
        {
          "result": "pass",
          "text": "Packages DO NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro",
          "note": "",
          "name": "CheckNoRequiresPost",
          "url": "https://fedoraproject.org/wiki/Packaging:Java"
        },
        {
          "result": "pending",
          "text": "If package contains pom.xml files install it (including metadata) even when building with ant",
          "note": null,
          "name": "CheckPomInstalled",
          "url": "https://fedoraproject.org/wiki/Packaging:Java#Maven_pom.xml_files"
        },
        {
          "result": "pass",
          "text": "Package DOES NOT use %update_maven_depmap in %post/%postun",
          "note": null,
          "name": "CheckUpdateDepmap",
          "url": "https://fedoraproject.org/wiki/Packaging:Java#Maven_pom.xml_files"
        },
        {
          "result": "pass",
          "text": "Packages use .mfiles file list instead of %{_datadir}/maven2/poms",
          "note": null,
          "name": "CheckUseMavenpomdirMacro",
          "url": "https://fedoraproject.org/wiki/Packaging:Java#Maven_pom.xml_files"
        }
      ]
    },
    "SHOULD": {
      "Generic": [
        {
          "result": "fail",
          "text": "Reviewer should test that the package builds in mock.",
          "note": null,
          "name": "CheckBuildInMock",
          "url": "https://fedoraproject.org/wiki/PackageMaintainers/MockTricks"
        },
        {
          "result": "pass",
          "text": "Buildroot is not present",
          "note": null,
          "name": "CheckBuildroot",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/"
        },
        {
          "result": "pass",
          "text": "Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)",
          "note": null,
          "name": "CheckClean",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections"
        },
        {
          "result": "pending",
          "text": "If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.",
          "note": null,
          "name": "CheckContainsLicenseText",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text"
        },
        {
          "result": "pass",
          "text": "No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.",
          "note": null,
          "name": "CheckFileRequires",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies"
        },
        {
          "result": "pending",
          "text": "Final provides and requires are sane (see attachments).",
          "note": null,
          "name": "CheckFinalRequiresProvides",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/"
        },
        {
          "result": "pending",
          "text": "Package functions as described.",
          "note": null,
          "name": "CheckFunctionAsDescribed",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/"
        },
        {
          "result": "pass",
          "text": "Packager, Vendor, PreReq, Copyright tags should not be in spec file",
          "note": null,
          "name": "CheckIllegalSpecTags",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections"
        },
        {
          "result": "pending",
          "text": "Latest version is packaged.",
          "note": null,
          "name": "CheckLatestVersionIsPackaged",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/"
        },
        {
          "result": "pending",
          "text": "Package does not include license text files separate from upstream.",
          "note": null,
          "name": "CheckLicenseUpstream",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text"
        },
        {
          "result": "pending",
          "text": "SourceX tarball generation or download is documented.",
          "note": "Package contains tarball without URL, check comments",
          "name": "CheckSourceComment",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/"
        },
        {
          "result": "fail",
          "text": "Sources can be downloaded from URI in Source: tag",
          "note": "Could not download Source0: https://github.com/jmdns/jmdns/archive/jmdns-3.5.9/jmdns-3.5.9.tar.gz",
          "name": "CheckSourceDownloads",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/"
        },
        {
          "result": "pass",
          "text": "SourceX is a working URL.",
          "note": null,
          "name": "CheckSourceUrl",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/"
        },
        {
          "result": "pending",
          "text": "Sources are verified with gpgverify first in %prep if upstream publishes signatures.",
          "note": "gpgverify is not used.",
          "name": "CheckSourceVerification",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_file_verification"
        },
        {
          "result": "pending",
          "text": "Package should compile and build into binary rpms on all supported architectures.",
          "note": null,
          "name": "CheckSupportAllArchs",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support"
        },
        {
          "result": "pending",
          "text": "%check is present and all tests pass.",
          "note": null,
          "name": "CheckTestSuites",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites"
        },
        {
          "result": "pending",
          "text": "Packages should try to preserve timestamps of original installed files.",
          "note": null,
          "name": "CheckTimeStamps",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps"
        },
        {
          "result": "pass",
          "text": "Spec use %global instead of %define unless justified.",
          "note": null,
          "name": "CheckUseGlobal",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define"
        }
      ],
      "Java": [
        {
          "result": "pass",
          "text": "Packages are noarch unless they use JNI",
          "note": null,
          "name": "CheckNoArch",
          "url": "https://fedoraproject.org/wiki/Packaging:Java"
        },
        {
          "result": "pending",
          "text": "Package uses upstream build method (ant/maven/etc.)",
          "note": null,
          "name": "CheckUpstremBuildMethod",
          "url": "https://fedoraproject.org/wiki/Packaging:Java"
        }
      ]
    },
    "EXTRA": {
      "Generic": [
        {
          "result": "pass",
          "text": "Rpmlint is run on all installed packages.",
          "note": "No rpmlint messages.",
          "name": "CheckRpmlintInstalled",
          "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint"
        }
      ]
    }
  },
  "attachments": [
    {
      "header": "Rpmlint",
      "text": "Checking: jmdns-3.5.9-1.fc38.noarch.rpm\n          jmdns-3.5.9-1.fc38.src.rpm\n============================ rpmlint session starts ============================\nrpmlint: 2.4.0\nconfiguration:\n    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml\n    /etc/xdg/rpmlint/fedora-legacy-licenses.toml\n    /etc/xdg/rpmlint/fedora-spdx-licenses.toml\n    /etc/xdg/rpmlint/fedora.toml\n    /etc/xdg/rpmlint/scoring.toml\n    /etc/xdg/rpmlint/users-groups.toml\n    /etc/xdg/rpmlint/warn-on-functions.toml\nrpmlintrc: [PosixPath('/tmp/tmpx3n43qe0')]\nchecks: 31, packages: 2\n\n 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s \n\n\n"
    },
    {
      "header": "Rpmlint (installed packages)",
      "text": "(none): E: there is no installed rpm \"jmdns\".\nThere are no files to process nor additional arguments.\nNothing to do, aborting.\n============================ rpmlint session starts ============================\nrpmlint: 2.4.0\nconfiguration:\n    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml\n    /etc/xdg/rpmlint/fedora-legacy-licenses.toml\n    /etc/xdg/rpmlint/fedora-spdx-licenses.toml\n    /etc/xdg/rpmlint/fedora.toml\n    /etc/xdg/rpmlint/scoring.toml\n    /etc/xdg/rpmlint/users-groups.toml\n    /etc/xdg/rpmlint/warn-on-functions.toml\nchecks: 31, packages: 1\n\n 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s \n\n"
    },
    {
      "header": "",
      "text": "Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24\nCommand line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name jmdns --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg\nBuildroot used: fedora-38-x86_64\nActive plugins: Generic, Shell-api, Java\nDisabled plugins: Perl, C/C++, SugarActivity, fonts, Python, Haskell, PHP, Ocaml, R\nDisabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH\n"
    },
    {
      "header": "Requires",
      "text": "jmdns (rpmlib, GLIBC filtered):\n    (java-headless or java-17-headless or java-11-headless or java-1.8.0-headless)\n    javapackages-filesystem\n    mvn(org.slf4j:slf4j-api)\n\n"
    },
    {
      "header": "Provides",
      "text": "jmdns:\n    jmdns\n    mvn(org.jmdns:jmdns)\n    mvn(org.jmdns:jmdns:pom:)\n    osgi(javax.jmdns)\n\n"
    }
  ]
}