This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 52824 bytes in 8 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: basalt-2.0.1-1.20240913git94ae6b6.fc39.x86_64.rpm basalt-devel-2.0.1-1.20240913git94ae6b6.fc39.x86_64.rpm basalt-debuginfo-2.0.1-1.20240913git94ae6b6.fc39.x86_64.rpm basalt-debugsource-2.0.1-1.20240913git94ae6b6.fc39.x86_64.rpm basalt-2.0.1-1.20240913git94ae6b6.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpyjt2smpx')] checks: 32, packages: 5 basalt.spec:103: W: unversioned-explicit-provides bundled(basalt-headers) basalt.spec:107: W: unversioned-explicit-provides bundled(opengv) basalt.spec:114: W: unversioned-explicit-provides bundled(ros_com) basalt.spec:116: W: unversioned-explicit-provides bundled(roscpp_core) basalt.src: E: spelling-error ('odometry', '%description -l en_US odometry -> odometer') basalt.x86_64: E: spelling-error ('odometry', '%description -l en_US odometry -> odometer') basalt-devel.x86_64: W: no-documentation basalt.spec:143: W: macro-in-comment %{SOURCE1} basalt.spec:147: W: macro-in-comment %{SOURCE4} basalt.spec:173: W: macro-in-comment %{_includedir} basalt.spec:174: W: macro-in-comment %{_includedir} 5 packages and 0 specfiles checked; 2 errors, 9 warnings, 41 filtered, 2 badness; has taken 2.1 s Rpmlint (debuginfo) ------------------- Checking: basalt-debuginfo-2.0.1-1.20240913git94ae6b6.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9m4e6xbq')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 1.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "basalt-debugsource". (none): E: there is no installed rpm "basalt". (none): E: there is no installed rpm "basalt-debuginfo". (none): E: there is no installed rpm "basalt-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/google/googletest//archive/e2239ee6043f73722e7aa812a459f54a28552929/googletest-e2239ee6043f73722e7aa812a459f54a28552929.tar.gz : CHECKSUM(SHA256) this package : 2765fbfaa978e90d1c8477bc2f2b9705be65b1b562bb215dbfaa76567d508fe1 CHECKSUM(SHA256) upstream package : 2765fbfaa978e90d1c8477bc2f2b9705be65b1b562bb215dbfaa76567d508fe1 https://github.com/google/benchmark/archive/f91b6b42b1b9854772a90ae9501464a161707d1e/benchmark-f91b6b42b1b9854772a90ae9501464a161707d1e.tar.gz : CHECKSUM(SHA256) this package : ea419b2946bac97468b3a9ed1d8a900be6bf8adf934b5da9a6ccf81a47f30c61 CHECKSUM(SHA256) upstream package : ea419b2946bac97468b3a9ed1d8a900be6bf8adf934b5da9a6ccf81a47f30c61 https://github.com/NikolausDemmel/roscpp_core//archive/1a74781ce707b1a2198d1bd6799b892b3c1fa195/roscpp_core-1a74781ce707b1a2198d1bd6799b892b3c1fa195.tar.gz : CHECKSUM(SHA256) this package : e71563b60b177e8ee607944a2dfd60615f53966359fc1a0f771a6eecbbfb6703 CHECKSUM(SHA256) upstream package : e71563b60b177e8ee607944a2dfd60615f53966359fc1a0f771a6eecbbfb6703 https://github.com/ros/ros_comm//archive/194c776737134a429619f6851f1850734843e210/ros_comm-194c776737134a429619f6851f1850734843e210.tar.gz : CHECKSUM(SHA256) this package : 27f9f6c9b744baa377c89b27d1c3c0dad25265ca4d335cf00af5778d2e2f7d9c CHECKSUM(SHA256) upstream package : 27f9f6c9b744baa377c89b27d1c3c0dad25265ca4d335cf00af5778d2e2f7d9c https://github.com/ros/console_bridge//archive/f0b423c0c2d02651db1776c96887c0a314908063/console_bridge-f0b423c0c2d02651db1776c96887c0a314908063.tar.gz : CHECKSUM(SHA256) this package : 84bfe8fa600940e335a9187cd2ed5f3ccbadfa807553f36e85c604c03bd1bab2 CHECKSUM(SHA256) upstream package : 84bfe8fa600940e335a9187cd2ed5f3ccbadfa807553f36e85c604c03bd1bab2 https://gitlab.com/libeigen/eigen//-/archive/3147391d946bb4b6c68edd901f2add6ac1f31f8c/eigen-3147391d946bb4b6c68edd901f2add6ac1f31f8c.tar.bz2 : CHECKSUM(SHA256) this package : f4f464a2f866324cd181eeac378e74ed377aee570e8bb909b415fd5b00b9de74 CHECKSUM(SHA256) upstream package : f4f464a2f866324cd181eeac378e74ed377aee570e8bb909b415fd5b00b9de74 https://github.com/USCiLab/cereal//archive/ebef1e929807629befafbb2918ea1a08c7194554/cereal-ebef1e929807629befafbb2918ea1a08c7194554.tar.gz : CHECKSUM(SHA256) this package : ce52ae6abcdbda5fecd63abbaa7ab57e54b814b24d7cb6f5096f5753d1975d24 CHECKSUM(SHA256) upstream package : ce52ae6abcdbda5fecd63abbaa7ab57e54b814b24d7cb6f5096f5753d1975d24 https://github.com/strasdat/Sophus//archive/8e1941677ef214aab0397608f42b18fbe1a19885/Sophus-8e1941677ef214aab0397608f42b18fbe1a19885.tar.gz : CHECKSUM(SHA256) this package : 5fc399dc5a8a7f30603fc1bbda380e4c1e79a47b477319e0cb7a4762b5d94007 CHECKSUM(SHA256) upstream package : 5fc399dc5a8a7f30603fc1bbda380e4c1e79a47b477319e0cb7a4762b5d94007 https://github.com/laurentkneip/opengv//archive/91f4b19c73450833a40e463ad3648aae80b3a7f3/opengv-91f4b19c73450833a40e463ad3648aae80b3a7f3.tar.gz : CHECKSUM(SHA256) this package : b03f61ff597a6c16a32b8939c3e49e9f240ae7b4da3358f1430e9743e093d596 CHECKSUM(SHA256) upstream package : b03f61ff597a6c16a32b8939c3e49e9f240ae7b4da3358f1430e9743e093d596 https://github.com/Neargye/magic_enum//archive/3d1f6a5a2a3fbcba077e00ad0ccc2dd9fefc2ca7/magic_enum-3d1f6a5a2a3fbcba077e00ad0ccc2dd9fefc2ca7.tar.gz : CHECKSUM(SHA256) this package : b789aa44f21c772e291a32ea20521729e79bd59c131d4f6b521a7133af37924c CHECKSUM(SHA256) upstream package : b789aa44f21c772e291a32ea20521729e79bd59c131d4f6b521a7133af37924c https://gitlab.freedesktop.org/mateosss/basalt-headers//-/archive/81face5662edc2f08d8df796e26f78ba475557db/basalt-headers-81face5662edc2f08d8df796e26f78ba475557db.tar.bz2 : CHECKSUM(SHA256) this package : 5fc135c7f6519e3eb03a9fcec054f34ba6ffc67d277a3017dc8b3189e3d62136 CHECKSUM(SHA256) upstream package : 5fc135c7f6519e3eb03a9fcec054f34ba6ffc67d277a3017dc8b3189e3d62136 https://github.com/stevenlovegrove/Pangolin//archive/2e67335fde01e25328160d92de660566806e92fa/Pangolin-2e67335fde01e25328160d92de660566806e92fa.tar.gz : CHECKSUM(SHA256) this package : 93b88df12b82853f28aa51ff7f35c76637f2e5be538a29b9956dd7edbfb689fe CHECKSUM(SHA256) upstream package : 93b88df12b82853f28aa51ff7f35c76637f2e5be538a29b9956dd7edbfb689fe https://github.com/CLIUtils/CLI11//archive/4af78beef777e313814b4daff70e2da9171a385a/CLI11-4af78beef777e313814b4daff70e2da9171a385a.tar.gz : CHECKSUM(SHA256) this package : eb9de112f9859aecb5a4f389f48816995b5a922933a1d34818aeaa156680f566 CHECKSUM(SHA256) upstream package : eb9de112f9859aecb5a4f389f48816995b5a922933a1d34818aeaa156680f566 https://gitlab.freedesktop.org/mateosss/basalt//-/archive/94ae6b6945798c85127aa6d43240ebaee70a8352/basalt-94ae6b6945798c85127aa6d43240ebaee70a8352.tar.bz2 : CHECKSUM(SHA256) this package : e37b22ff7050dcd2b2852885576df493606a1521efe446760fbc4922de8a0e8c CHECKSUM(SHA256) upstream package : e37b22ff7050dcd2b2852885576df493606a1521efe446760fbc4922de8a0e8c Requires -------- basalt (rpmlib, GLIBC filtered): libc.so.6()(64bit) libepoxy.so.0()(64bit) libfmt.so.10()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libopencv_core.so.408()(64bit) libopencv_features2d.so.408()(64bit) libopencv_imgproc.so.408()(64bit) libpango_core.so.0()(64bit) libpango_display.so.0()(64bit) libpango_opengl.so.0()(64bit) libpango_plot.so.0()(64bit) libpango_vars.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtbb.so.2()(64bit) rtld(GNU_HASH) basalt-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config basalt(x86-64) libbasalt.so.2()(64bit) basalt-debuginfo (rpmlib, GLIBC filtered): basalt-debugsource (rpmlib, GLIBC filtered): Provides -------- basalt: basalt basalt(x86-64) bundled(basalt-headers) bundled(benchmark) bundled(cereal) bundled(console_bridge) bundled(eigen3) bundled(gtest) bundled(opengv) bundled(pangolin) bundled(ros_com) bundled(roscpp_core) bundled(sophus) libbasalt.so.2()(64bit) libbasalt.so.2(BASALT_2.0.1)(64bit) basalt-devel: basalt-devel basalt-devel(x86-64) pkgconfig(basalt) basalt-debuginfo: basalt-debuginfo basalt-debuginfo(x86-64) debuginfo(build-id) libbasalt.so.2.0.1-2.0.1-1.20240913git94ae6b6.fc39.x86_64.debug()(64bit) basalt-debugsource: basalt-debugsource basalt-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name basalt --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Java, Ocaml, Perl, SugarActivity, Haskell, fonts, R, Python, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH