This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in signal-cli [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build Maven: [ ]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil}, %define pname signal-cli, %define version_jar $(ls -1 %{buildroot}%{basedir}/lib/libsignal-client-*.jar | %{__sed} 's/.*-\\([0-9.]*\\).jar/\\1/g') [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. Java: [ ]: Packages are noarch unless they use JNI Note: signal-cli subpackage is not noarch. Please verify manually [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: signal-cli-0.13.22-2.fc44.x86_64.rpm signal-cli-0.13.22-2.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpm2_xtj_3')] checks: 32, packages: 2 signal-cli.spec:89: W: unversioned-explicit-provides user(%scuser) signal-cli.spec:90: W: unversioned-explicit-provides group(%scuser) signal-cli.src: W: summary-not-capitalized signal-cli commandline, dbus and JSON-RPC interface for the Signal messenger signal-cli.x86_64: W: summary-not-capitalized signal-cli commandline, dbus and JSON-RPC interface for the Signal messenger signal-cli.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1 signal-cli.x86_64: E: standard-dir-owned-by-package /usr/share/man/man5 signal-cli.src: E: spelling-error ('commandline', 'Summary(en_US) commandline -> command line, command-line, commandment') signal-cli.src: E: spelling-error ('dbus', 'Summary(en_US) dbus -> dubs, bus, buds') signal-cli.src: E: spelling-error ('commandline', '%description -l en_US commandline -> command line, command-line, commandment') signal-cli.src: E: spelling-error ('dbus', '%description -l en_US dbus -> dubs, bus, buds') signal-cli.src: E: spelling-error ('usr', '%description -l en_US usr -> use, us, user') signal-cli.x86_64: E: spelling-error ('commandline', 'Summary(en_US) commandline -> command line, command-line, commandment') signal-cli.x86_64: E: spelling-error ('dbus', 'Summary(en_US) dbus -> dubs, bus, buds') signal-cli.x86_64: E: spelling-error ('commandline', '%description -l en_US commandline -> command line, command-line, commandment') signal-cli.x86_64: E: spelling-error ('dbus', '%description -l en_US dbus -> dubs, bus, buds') signal-cli.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory signal-cli.spec:273: W: shared-dir-glob-in-files %attr(755,-,-) %{_bindir}/* signal-cli.spec:288: W: shared-dir-glob-in-files %{_mandir}/* signal-cli.x86_64: W: non-standard-uid /var/lib/signal-cli signal-cli signal-cli.x86_64: W: non-standard-uid /var/lib/signal-cli/.local signal-cli signal-cli.x86_64: W: non-standard-uid /var/lib/signal-cli/.local/share signal-cli signal-cli.x86_64: W: non-standard-uid /var/lib/signal-cli/.local/share/signal-cli signal-cli signal-cli.x86_64: W: non-standard-uid /var/lib/signal-cli/.local/share/signal-cli/avatars signal-cli signal-cli.x86_64: W: non-standard-uid /var/lib/signal-cli/.local/share/signal-cli/data signal-cli signal-cli.x86_64: W: non-standard-gid /var/lib/signal-cli signal-cli signal-cli.x86_64: W: non-standard-gid /var/lib/signal-cli/.local signal-cli signal-cli.x86_64: W: non-standard-gid /var/lib/signal-cli/.local/share signal-cli signal-cli.x86_64: W: non-standard-gid /var/lib/signal-cli/.local/share/signal-cli signal-cli signal-cli.x86_64: W: non-standard-gid /var/lib/signal-cli/.local/share/signal-cli/avatars signal-cli signal-cli.x86_64: W: non-standard-gid /var/lib/signal-cli/.local/share/signal-cli/data signal-cli signal-cli.x86_64: E: non-standard-dir-perm /var/lib/signal-cli 770 signal-cli.x86_64: E: non-standard-dir-perm /var/lib/signal-cli/.local 770 signal-cli.x86_64: E: non-standard-dir-perm /var/lib/signal-cli/.local/share 770 signal-cli.x86_64: E: non-standard-dir-perm /var/lib/signal-cli/.local/share/signal-cli 770 signal-cli.x86_64: E: non-standard-dir-perm /var/lib/signal-cli/.local/share/signal-cli/avatars 770 signal-cli.x86_64: E: non-standard-dir-perm /var/lib/signal-cli/.local/share/signal-cli/data 770 signal-cli.x86_64: E: no-binary signal-cli.src: W: name-repeated-in-summary signal-cli signal-cli.x86_64: W: name-repeated-in-summary signal-cli signal-cli.spec:32: W: mixed-use-of-spaces-and-tabs (spaces: line 32, tab: line 21) signal-cli.spec:134: W: macro-in-comment %{__tar} signal-cli.spec:134: W: macro-in-comment %{SOURCE1} signal-cli.spec:134: W: macro-in-comment %{buildroot} signal-cli.spec:134: W: macro-in-comment %{basedir} signal-cli.x86_64: W: hidden-file-or-dir /var/lib/signal-cli/.local signal-cli.x86_64: W: hidden-file-or-dir /var/lib/signal-cli/.local signal-cli.x86_64: E: file-parent-ownership-mismatch Path "/var/lib/signal-cli/avatars" owned by "root" is stored in directory owned by "signal-cli" signal-cli.x86_64: E: file-parent-ownership-mismatch Path "/var/lib/signal-cli/data" owned by "root" is stored in directory owned by "signal-cli" signal-cli.src: E: description-line-too-long signal-cli provides an unofficial commandline, dbus and JSON-RPC interface for the Signal messenger. signal-cli.x86_64: E: description-line-too-long signal-cli provides an unofficial commandline, dbus and JSON-RPC interface for the Signal messenger. signal-cli.x86_64: W: dbus-policy-allow-receive /usr/share/dbus-1/system.d/org.asamk.Signal.conf signal-cli.x86_64: W: dbus-policy-allow-receive /usr/share/dbus-1/system.d/org.asamk.Signal.conf signal-cli.x86_64: W: dangerous-command-in-%pre mv 2 packages and 0 specfiles checked; 22 errors, 31 warnings, 40 filtered, 22 badness; has taken 5.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "signal-cli". There are no files to process nor additional arguments. Nothing to do, aborting. Source checksums ---------------- https://media.projektzentrisch.de/temp/signal-cli/tests/libsignal_jni_so0861_ubuntu1804_amd64.gz : CHECKSUM(SHA256) this package : d80c2f2d5260f24716f9cb0d6433c92fadf4048f2824ea30a108f18caee20aa8 CHECKSUM(SHA256) upstream package : d80c2f2d5260f24716f9cb0d6433c92fadf4048f2824ea30a108f18caee20aa8 https://github.com/AsamK/signal-cli/releases/download/v0.13.22/signal-cli-0.13.22.tar.gz : CHECKSUM(SHA256) this package : 1453c2870d30d10a97f19267aa9c314b999fd8e7839555bc410c838d3a33380b CHECKSUM(SHA256) upstream package : 1453c2870d30d10a97f19267aa9c314b999fd8e7839555bc410c838d3a33380b Requires -------- signal-cli (rpmlib, GLIBC filtered): /bin/sh /usr/bin/sh dbus-common dbus-tools group(signal-cli) java-21-openjdk-headless shadow-utils systemd user(signal-cli) Provides -------- signal-cli: group(signal-cli) signal-cli signal-cli(x86-64) user(signal-cli) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name signal-cli --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, SugarActivity, Haskell, PHP, Perl, Python, R, Ocaml, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH