This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/bluechi
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
- systemd_user_post is invoked in %post and systemd_user_preun in %preun
for Systemd user units service files.
Note: Systemd user unit service file(s) in bluechi-agent
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Scriptlets/#_user_units
===== MUST items =====
C/C++:
[ ]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[ ]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License,
Version 2.1", "*No copyright* GNU Lesser General Public License,
Version 2.1", "BSD 3-Clause License", "*No copyright* MIT No
Attribution", "*No copyright* MIT License", "*No copyright* GNU Lesser
General Public License v2.1 or later and/or MIT License and/or MIT No
Attribution", "GNU Lesser General Public License v2.1 or later and/or
MIT License and/or MIT No Attribution", "MIT No Attribution", "MIT
License", "*No copyright* BSD 3-Clause License". 306 files have
unknown license. Detailed output of licensecheck in /var/lib/copr-
rpmbuild/results/bluechi/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/bluechi-agent, /usr/share/bluechi,
/usr/share/bluechi/config, /usr/share/bluechi-agent/config
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.12,
/usr/share/selinux/devel, /usr/share/dbus-1,
/usr/share/bluechi/config, /usr/share/dbus-1/system.d,
/usr/share/selinux/devel/include, /usr/lib/python3.12/site-packages,
/usr/share/bluechi-agent, /usr/share/selinux/devel/include/services,
/usr/share/bluechi-agent/config, /usr/share/bluechi
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 23550 bytes in 6 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in bluechi-controller, bluechi-agent
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[ ]: Python eggs must not download any dependencies during the build
process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in bluechi-
controller , bluechi-agent , bluechi-selinux , bluechi-ctl , bluechi-
is-online , python3-bluechi
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Scriptlets must be sane, if used.
[ ]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: bluechi-controller-0.10.0-0.202411261116.git9a485ab.fc40.ppc64le.rpm
bluechi-agent-0.10.0-0.202411261116.git9a485ab.fc40.ppc64le.rpm
bluechi-selinux-0.10.0-0.202411261116.git9a485ab.fc40.noarch.rpm
bluechi-ctl-0.10.0-0.202411261116.git9a485ab.fc40.ppc64le.rpm
bluechi-is-online-0.10.0-0.202411261116.git9a485ab.fc40.ppc64le.rpm
python3-bluechi-0.10.0-0.202411261116.git9a485ab.fc40.noarch.rpm
bluechi-0.10.0-0.202411261116.git9a485ab.fc40.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpnhuqzyfk')]
checks: 32, packages: 7
bluechi.src: E: spelling-error ('systemd', 'Summary(en_US) systemd -> systems, system, system d')
bluechi.src: E: spelling-error ('systemd', '%description -l en_US systemd -> systems, system, system d')
bluechi.src: E: spelling-error ('environements', '%description -l en_US environements -> environments, environmentalists, environment')
bluechi-agent.ppc64le: E: spelling-error ('environements', '%description -l en_US environements -> environments, environmentalists, environment')
bluechi-controller.ppc64le: E: spelling-error ('environements', '%description -l en_US environements -> environments, environmentalists, environment')
bluechi-ctl.ppc64le: E: spelling-error ('systemd', '%description -l en_US systemd -> systems, system, system d')
bluechi-ctl.ppc64le: E: spelling-error ('environements', '%description -l en_US environements -> environments, environmentalists, environment')
bluechi-is-online.ppc64le: E: spelling-error ('systemd', '%description -l en_US systemd -> systems, system, system d')
bluechi-is-online.ppc64le: E: spelling-error ('environements', '%description -l en_US environements -> environments, environmentalists, environment')
bluechi-agent.ppc64le: E: non-readable /etc/bluechi/agent.conf 0
bluechi-controller.ppc64le: E: non-readable /etc/bluechi/controller.conf 0
bluechi-agent.ppc64le: W: non-conffile-in-etc /etc/bluechi/agent.conf.d/README.md
bluechi-controller.ppc64le: W: non-conffile-in-etc /etc/bluechi/controller.conf.d/README.md
bluechi.spec: W: invalid-url Source0: bluechi-0.10.0.tar.gz
bluechi-agent.ppc64le: W: files-duplicate /usr/lib/systemd/user/bluechi-dep@.service /usr/lib/systemd/system/bluechi-dep@.service
bluechi-agent.ppc64le: W: dbus-policy-allow-receive /usr/share/dbus-1/system.d/org.eclipse.bluechi.Agent.conf
bluechi-agent.ppc64le: W: dbus-policy-allow-receive /usr/share/dbus-1/system.d/org.eclipse.bluechi.Agent.conf
bluechi-controller.ppc64le: W: dbus-policy-allow-receive /usr/share/dbus-1/system.d/org.eclipse.bluechi.conf
bluechi-controller.ppc64le: W: dbus-policy-allow-receive /usr/share/dbus-1/system.d/org.eclipse.bluechi.conf
bluechi-selinux.noarch: W: dangerous-command-in-%postun rm
bluechi-selinux.noarch: W: dangerous-command-in-%post rm
7 packages and 0 specfiles checked; 11 errors, 10 warnings, 26 filtered, 11 badness; has taken 1.4 s
Rpmlint (debuginfo)
-------------------
Checking: bluechi-debuginfo-0.10.0-0.202411261116.git9a485ab.fc40.ppc64le.rpm
bluechi-ctl-debuginfo-0.10.0-0.202411261116.git9a485ab.fc40.ppc64le.rpm
bluechi-is-online-debuginfo-0.10.0-0.202411261116.git9a485ab.fc40.ppc64le.rpm
bluechi-controller-debuginfo-0.10.0-0.202411261116.git9a485ab.fc40.ppc64le.rpm
bluechi-agent-debuginfo-0.10.0-0.202411261116.git9a485ab.fc40.ppc64le.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpwl0z97hs')]
checks: 32, packages: 5
5 packages and 0 specfiles checked; 0 errors, 0 warnings, 33 filtered, 0 badness; has taken 0.8 s
Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "bluechi-ctl-debuginfo".
(none): E: there is no installed rpm "bluechi-is-online-debuginfo".
(none): E: there is no installed rpm "bluechi-is-online".
(none): E: there is no installed rpm "bluechi-agent".
(none): E: there is no installed rpm "bluechi-debuginfo".
(none): E: there is no installed rpm "python3-bluechi".
(none): E: there is no installed rpm "bluechi-controller".
(none): E: there is no installed rpm "bluechi-selinux".
(none): E: there is no installed rpm "bluechi-controller-debuginfo".
(none): E: there is no installed rpm "bluechi-agent-debuginfo".
(none): E: there is no installed rpm "bluechi-ctl".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 11
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s
Requires
--------
bluechi-controller (rpmlib, GLIBC filtered):
/bin/sh
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libsystemd.so.0()(64bit)
libsystemd.so.0(LIBSYSTEMD_209)(64bit)
libsystemd.so.0(LIBSYSTEMD_221)(64bit)
libsystemd.so.0(LIBSYSTEMD_237)(64bit)
libsystemd.so.0(LIBSYSTEMD_240)(64bit)
libsystemd.so.0(LIBSYSTEMD_243)(64bit)
libsystemd.so.0(LIBSYSTEMD_248)(64bit)
rtld(GNU_HASH)
systemd
bluechi-agent (rpmlib, GLIBC filtered):
/bin/sh
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libsystemd.so.0()(64bit)
libsystemd.so.0(LIBSYSTEMD_209)(64bit)
libsystemd.so.0(LIBSYSTEMD_221)(64bit)
libsystemd.so.0(LIBSYSTEMD_237)(64bit)
libsystemd.so.0(LIBSYSTEMD_240)(64bit)
libsystemd.so.0(LIBSYSTEMD_241)(64bit)
libsystemd.so.0(LIBSYSTEMD_243)(64bit)
libsystemd.so.0(LIBSYSTEMD_248)(64bit)
rtld(GNU_HASH)
systemd
bluechi-selinux (rpmlib, GLIBC filtered):
/bin/sh
policycoreutils
selinux-policy
bluechi-ctl (rpmlib, GLIBC filtered):
bluechi
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libsystemd.so.0()(64bit)
libsystemd.so.0(LIBSYSTEMD_221)(64bit)
libsystemd.so.0(LIBSYSTEMD_237)(64bit)
rtld(GNU_HASH)
bluechi-is-online (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libsystemd.so.0()(64bit)
libsystemd.so.0(LIBSYSTEMD_221)(64bit)
libsystemd.so.0(LIBSYSTEMD_237)(64bit)
libsystemd.so.0(LIBSYSTEMD_240)(64bit)
rtld(GNU_HASH)
python3-bluechi (rpmlib, GLIBC filtered):
python(abi)
python3-dasbus
python3.12dist(dasbus)
Provides
--------
bluechi-controller:
bluechi
bluechi-controller
bluechi-controller(ppc-64)
hirte
bluechi-agent:
bluechi-agent
bluechi-agent(ppc-64)
hirte-agent
bluechi-selinux:
bluechi-selinux
hirte-selinux
bluechi-ctl:
bluechi-ctl
bluechi-ctl(ppc-64)
hirte-ctl
bluechi-is-online:
bluechi-is-online
bluechi-is-online(ppc-64)
python3-bluechi:
python-bluechi
python3-bluechi
python3-hirte
python3.12-bluechi
python3.12dist(bluechi)
python3dist(bluechi)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name bluechi --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-40-ppc64le
Active plugins: Generic, C/C++, Shell-api, Python
Disabled plugins: R, Haskell, Java, Ocaml, PHP, fonts, SugarActivity, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH