This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "GNU Lesser General Public License v2.1 or later", "ISC License", "*No copyright* [generated file]", "MIT License [generated file]", "*No copyright* ISC License". 535 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/oidc-agent/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc/X11/Xsession.d, /etc/oidc-agent [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/X11/Xsession.d, /etc/oidc-agent [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name} See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oidc- agent-cli , liboidc-agent4 , liboidc-agent-devel , oidc-agent-desktop [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: oidc-agent-4.3.2-1.fc37.x86_64.rpm oidc-agent-cli-4.3.2-1.fc37.x86_64.rpm liboidc-agent4-4.3.2-1.fc37.x86_64.rpm liboidc-agent-devel-4.3.2-1.fc37.x86_64.rpm oidc-agent-desktop-4.3.2-1.fc37.x86_64.rpm oidc-agent-debuginfo-4.3.2-1.fc37.x86_64.rpm oidc-agent-debugsource-4.3.2-1.fc37.x86_64.rpm oidc-agent-4.3.2-1.fc37.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplxeidla1')] checks: 31, packages: 8 liboidc-agent-devel.x86_64: W: summary-not-capitalized oidc-agent library development files liboidc-agent4.x86_64: W: summary-not-capitalized oidc-agent library oidc-agent-desktop.x86_64: W: position-independent-executable-suggested /usr/bin/oidc-prompt oidc-agent.x86_64: E: no-binary oidc-agent-desktop.x86_64: W: desktopfile-without-binary /usr/share/applications/oidc-gen.desktop bash 8 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.6 s Rpmlint (debuginfo) ------------------- Checking: oidc-agent-cli-debuginfo-4.3.2-1.fc37.x86_64.rpm oidc-agent-desktop-debuginfo-4.3.2-1.fc37.x86_64.rpm oidc-agent-debuginfo-4.3.2-1.fc37.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqslca17i')] checks: 31, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 9 oidc-agent-cli.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-gen /lib64/libmicrohttpd.so.12 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libgdk-3.so.0 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libz.so.1 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libpangocairo-1.0.so.0 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libpango-1.0.so.0 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libharfbuzz.so.0 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libatk-1.0.so.0 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libcairo-gobject.so.2 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libcairo.so.2 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libgdk_pixbuf-2.0.so.0 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libsoup-2.4.so.1 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libgmodule-2.0.so.0 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libgio-2.0.so.0 oidc-agent-desktop.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-prompt /lib64/libm.so.6 liboidc-agent4.x86_64: W: summary-not-capitalized oidc-agent library liboidc-agent-devel.x86_64: W: summary-not-capitalized oidc-agent library development files oidc-agent-desktop.x86_64: W: position-independent-executable-suggested /usr/bin/oidc-prompt oidc-agent.x86_64: E: no-binary 9 packages and 0 specfiles checked; 1 errors, 17 warnings, 1 badness; has taken 1.5 s Source checksums ---------------- https://github.com/indigo-dc/oidc-agent/archive/refs/tags/v4.3.2.tar.gz : CHECKSUM(SHA256) this package : 8f18afa7a066e7a781d3c239afd183115205edacfd58806906c9f48f24bfe2b0 CHECKSUM(SHA256) upstream package : 8f18afa7a066e7a781d3c239afd183115205edacfd58806906c9f48f24bfe2b0 Requires -------- oidc-agent (rpmlib, GLIBC filtered): oidc-agent-desktop(x86-64) oidc-agent-cli (rpmlib, GLIBC filtered): /usr/bin/bash config(oidc-agent-cli) jq libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libmicrohttpd.so.12()(64bit) liboidc-agent4(x86-64) libqrencode.so.4()(64bit) libsecret-1.so.0()(64bit) libsodium.so.23()(64bit) rtld(GNU_HASH) liboidc-agent4 (rpmlib, GLIBC filtered): libc.so.6()(64bit) libsodium.so.23()(64bit) rtld(GNU_HASH) liboidc-agent-devel (rpmlib, GLIBC filtered): liboidc-agent.so.4()(64bit) liboidc-agent4(x86-64) oidc-agent-desktop (rpmlib, GLIBC filtered): config(oidc-agent-desktop) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libharfbuzz.so.0()(64bit) libjavascriptcoregtk-4.0.so.18()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libsodium.so.23()(64bit) libsoup-2.4.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwebkit2gtk-4.0.so.37()(64bit) libz.so.1()(64bit) oidc-agent-cli(x86-64) rtld(GNU_HASH) webkitgtk4 xterm oidc-agent-debuginfo (rpmlib, GLIBC filtered): oidc-agent-debugsource (rpmlib, GLIBC filtered): Provides -------- oidc-agent: oidc-agent oidc-agent(x86-64) oidc-agent-cli: config(oidc-agent-cli) oidc-agent-cli oidc-agent-cli(x86-64) liboidc-agent4: liboidc-agent.so.4()(64bit) liboidc-agent4 liboidc-agent4(x86-64) liboidc-agent-devel: liboidc-agent-devel liboidc-agent-devel(x86-64) oidc-agent-desktop: application() application(oidc-gen.desktop) config(oidc-agent-desktop) mimehandler(x-scheme-handler/edu.kit.data.oidc-agent) oidc-agent-desktop oidc-agent-desktop(x86-64) oidc-agent-debuginfo: oidc-agent-debuginfo oidc-agent-debuginfo(x86-64) oidc-agent-debugsource: oidc-agent-debugsource oidc-agent-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name oidc-agent --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-37-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, Ocaml, R, Haskell, fonts, SugarActivity, Perl, Python, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH