This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: openssl1.1-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License", "*No copyright* BSD 3-Clause License", "*No copyright* The Unlicense", "*No copyright* Apache License 2.0", "*No copyright* Public domain", "*No copyright* MIT License [generated file]", "*No copyright* Creative Commons CC0 1.0", "CMU License". 1482 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/liboqs/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: liboqs-0.8.0-1.fc38.x86_64.rpm liboqs-devel-0.8.0-1.fc38.x86_64.rpm liboqs-debuginfo-0.8.0-1.fc38.x86_64.rpm liboqs-debugsource-0.8.0-1.fc38.x86_64.rpm liboqs-0.8.0-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0vctvz2j')] checks: 31, packages: 5 liboqs.src: W: summary-not-capitalized liboqs is an open source C library for quantum-safe cryptographic algorithms. liboqs.x86_64: W: summary-not-capitalized liboqs is an open source C library for quantum-safe cryptographic algorithms. liboqs.src: W: summary-ended-with-dot liboqs is an open source C library for quantum-safe cryptographic algorithms. liboqs.x86_64: W: summary-ended-with-dot liboqs is an open source C library for quantum-safe cryptographic algorithms. liboqs.src: W: name-repeated-in-summary liboqs liboqs.x86_64: W: name-repeated-in-summary liboqs liboqs.spec:103: W: macro-in-comment %dir liboqs.spec:104: W: macro-in-comment %doc liboqs.spec:105: W: macro-in-comment %doc liboqs.src: W: invalid-license Apache 2.0 liboqs.src: W: invalid-license BSD 3-Clause liboqs.x86_64: W: invalid-license Apache 2.0 liboqs.x86_64: W: invalid-license BSD 3-Clause liboqs-debuginfo.x86_64: W: invalid-license Apache 2.0 liboqs-debuginfo.x86_64: W: invalid-license BSD 3-Clause liboqs-debugsource.x86_64: W: invalid-license Apache 2.0 liboqs-debugsource.x86_64: W: invalid-license BSD 3-Clause liboqs-devel.x86_64: W: invalid-license Apache 2.0 liboqs-devel.x86_64: W: invalid-license BSD 3-Clause liboqs-debugsource.x86_64: E: files-duplicated-waste 973391 liboqs.src: E: description-line-too-long - a collection of open source implementations of quantum-safe key encapsulation mechanism (KEM) and digital signature algorithms; the full list can be found below liboqs.src: E: description-line-too-long liboqs is part of the Open Quantum Safe (OQS) project led by Douglas Stebila and Michele Mosca, which aims to develop and integrate into applications quantum-safe cryptography to facilitate deployment and testing in real world contexts. In particular, OQS provides prototype integrations of liboqs into TLS and SSH, through OpenSSL and OpenSSH. liboqs.x86_64: E: description-line-too-long - a collection of open source implementations of quantum-safe key encapsulation mechanism (KEM) and digital signature algorithms; the full list can be found below liboqs.x86_64: E: description-line-too-long liboqs is part of the Open Quantum Safe (OQS) project led by Douglas Stebila and Michele Mosca, which aims to develop and integrate into applications quantum-safe cryptography to facilitate deployment and testing in real world contexts. In particular, OQS provides prototype integrations of liboqs into TLS and SSH, through OpenSSL and OpenSSH. 5 packages and 0 specfiles checked; 5 errors, 19 warnings, 5 badness; has taken 1.4 s Rpmlint (debuginfo) ------------------- Checking: liboqs-debuginfo-0.8.0-1.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphik8avc8')] checks: 31, packages: 1 liboqs-debuginfo.x86_64: W: invalid-license Apache 2.0 liboqs-debuginfo.x86_64: W: invalid-license BSD 3-Clause 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 liboqs.x86_64: W: summary-not-capitalized liboqs is an open source C library for quantum-safe cryptographic algorithms. liboqs.x86_64: W: summary-ended-with-dot liboqs is an open source C library for quantum-safe cryptographic algorithms. liboqs.x86_64: W: name-repeated-in-summary liboqs liboqs-devel.x86_64: W: invalid-license Apache 2.0 liboqs-devel.x86_64: W: invalid-license BSD 3-Clause liboqs.x86_64: W: invalid-license Apache 2.0 liboqs.x86_64: W: invalid-license BSD 3-Clause liboqs-debugsource.x86_64: W: invalid-license Apache 2.0 liboqs-debugsource.x86_64: W: invalid-license BSD 3-Clause liboqs-debuginfo.x86_64: W: invalid-license Apache 2.0 liboqs-debuginfo.x86_64: W: invalid-license BSD 3-Clause liboqs-debugsource.x86_64: E: files-duplicated-waste 973391 liboqs.x86_64: E: description-line-too-long - a collection of open source implementations of quantum-safe key encapsulation mechanism (KEM) and digital signature algorithms; the full list can be found below liboqs.x86_64: E: description-line-too-long liboqs is part of the Open Quantum Safe (OQS) project led by Douglas Stebila and Michele Mosca, which aims to develop and integrate into applications quantum-safe cryptography to facilitate deployment and testing in real world contexts. In particular, OQS provides prototype integrations of liboqs into TLS and SSH, through OpenSSL and OpenSSH. 4 packages and 0 specfiles checked; 3 errors, 11 warnings, 3 badness; has taken 1.2 s Source checksums ---------------- https://github.com/open-quantum-safe/liboqs/archive/refs/tags/0.8.0.tar.gz : CHECKSUM(SHA256) this package : 542e2d6cd4d3013bc4f97843cb1e9521b1b8d8ea72a55c9f5f040857486b0157 CHECKSUM(SHA256) upstream package : 542e2d6cd4d3013bc4f97843cb1e9521b1b8d8ea72a55c9f5f040857486b0157 Requires -------- liboqs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) rtld(GNU_HASH) liboqs-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) liboqs(x86-64) liboqs.so.3()(64bit) pkgconfig(openssl) liboqs-debuginfo (rpmlib, GLIBC filtered): liboqs-debugsource (rpmlib, GLIBC filtered): Provides -------- liboqs: liboqs liboqs(x86-64) liboqs.so.3()(64bit) liboqs-devel: cmake(liboqs) liboqs-devel liboqs-devel(x86-64) pkgconfig(liboqs) liboqs-debuginfo: debuginfo(build-id) liboqs-debuginfo liboqs-debuginfo(x86-64) liboqs.so.0.8.0-0.8.0-1.fc38.x86_64.debug()(64bit) liboqs-debugsource: liboqs-debugsource liboqs-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name liboqs --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-38-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: R, PHP, SugarActivity, Haskell, Ocaml, Java, fonts, Perl, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH