This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0", "BSD 3-Clause License", "MIT License", "BSD 2-Clause License", "*No copyright* MIT License", "GNU Lesser General Public License v2.1 or later", "GNU General Public License v3.0 or later", "DSDP License", "Mozilla Public License 2.0", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "zlib License", "*No copyright* GNU General Public License and/or Mozilla Public License 2.0", "GNU General Public License and/or Mozilla Public License 2.0", "BSD 3-Clause License and/or Mozilla Public License 2.0", "Boehm GC License and/or Mozilla Public License 2.0", "Apache License 2.0". 858 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/gismo/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/.build-id/05, /usr/lib/.build-id/23, /usr/lib/.build-id/50, /usr/lib/.build-id/18, /usr/lib/.build-id/4c, /usr/lib/.build-id/78, /usr/lib/.build-id/28, /usr/lib/.build-id/d5, /usr/lib/.build-id/f1, /usr/lib/.build-id/fa, /usr/lib/.build-id/e0, /usr/lib/.build-id/2f [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 58332 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/gismo/gismo/archive/25.07.0/gismo-25.07.0.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gismo- examples , gismo-data , gismo-openmpi , gismo-openmpi-devel , gismo- openmpi-examples , gismo-mpich , gismo-mpich-devel , gismo-mpich- examples [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: gismo-25.07.0-1.fc45.x86_64.rpm gismo-devel-25.07.0-1.fc45.x86_64.rpm gismo-examples-25.07.0-1.fc45.x86_64.rpm gismo-data-25.07.0-1.fc45.noarch.rpm gismo-openmpi-25.07.0-1.fc45.x86_64.rpm gismo-openmpi-devel-25.07.0-1.fc45.x86_64.rpm gismo-openmpi-examples-25.07.0-1.fc45.x86_64.rpm gismo-mpich-25.07.0-1.fc45.x86_64.rpm gismo-mpich-devel-25.07.0-1.fc45.x86_64.rpm gismo-mpich-examples-25.07.0-1.fc45.x86_64.rpm gismo-25.07.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpguidu4s_')] checks: 32, packages: 11 gismo-devel.x86_64: E: zero-length /usr/include/gismo/gsCore/gsConfigExt.h gismo.src: E: spelling-error ('isogeometric', 'Summary(en_US) isogeometric -> isometrics, isometric, geometric') gismo.src: E: spelling-error ('isogeometric', '%description -l en_US isogeometric -> isometrics, isometric, geometric') gismo.x86_64: E: spelling-error ('isogeometric', 'Summary(en_US) isogeometric -> isometrics, isometric, geometric') gismo.x86_64: E: spelling-error ('isogeometric', '%description -l en_US isogeometric -> isometrics, isometric, geometric') gismo-mpich-devel.x86_64: W: only-non-binary-in-usr-lib gismo-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib gismo-examples.x86_64: W: no-manual-page-for-binary L2projection_example gismo-examples.x86_64: W: no-manual-page-for-binary adaptRefinementThb_example gismo-examples.x86_64: W: no-manual-page-for-binary adaptiveConvectionDiffusionReaction_example gismo-examples.x86_64: W: no-manual-page-for-binary as_parameterization_example gismo-examples.x86_64: W: no-manual-page-for-binary assembly_example gismo-examples.x86_64: W: no-manual-page-for-binary bSplineBasis_example gismo-examples.x86_64: W: no-manual-page-for-binary bSplineCurve_example gismo-examples.x86_64: W: no-manual-page-for-binary bSplineSurface_example gismo-examples.x86_64: W: no-manual-page-for-binary basis_example gismo-examples.x86_64: W: no-manual-page-for-binary biharmonic2_example gismo-examples.x86_64: W: no-manual-page-for-binary biharmonic_example gismo-examples.x86_64: W: no-manual-page-for-binary commandLineArg_example gismo-examples.x86_64: W: no-manual-page-for-binary compositions_example gismo-examples.x86_64: W: no-manual-page-for-binary constrained_fitting gismo-examples.x86_64: W: no-manual-page-for-binary domains_example gismo-examples.x86_64: W: no-manual-page-for-binary fileIo_example gismo-examples.x86_64: W: no-manual-page-for-binary fitting_example gismo-examples.x86_64: W: no-manual-page-for-binary fitting_mspline gismo-examples.x86_64: W: no-manual-page-for-binary geometry_example gismo-examples.x86_64: W: no-manual-page-for-binary gsAdaptiveMeshing_example gismo-examples.x86_64: W: no-manual-page-for-binary gsHBox_example gismo-examples.x86_64: W: no-manual-page-for-binary gsInterpolateMap gismo-examples.x86_64: W: no-manual-page-for-binary gsMakeMultiPatch gismo-examples.x86_64: W: no-manual-page-for-binary gsMappedSpline_example gismo-examples.x86_64: W: no-manual-page-for-binary gsPatchFromBoundary gismo-examples.x86_64: W: no-manual-page-for-binary gsView gismo-examples.x86_64: W: no-manual-page-for-binary heatEquation_example gismo-examples.x86_64: W: no-manual-page-for-binary ieti2_example gismo-examples.x86_64: W: no-manual-page-for-binary ieti_example gismo-examples.x86_64: W: no-manual-page-for-binary inputOutput_example gismo-examples.x86_64: W: no-manual-page-for-binary kirchhoff-Love_example gismo-examples.x86_64: W: no-manual-page-for-binary knotVector_example gismo-examples.x86_64: W: no-manual-page-for-binary linearAlgebra_example gismo-examples.x86_64: W: no-manual-page-for-binary linearSolvers_example gismo-examples.x86_64: W: no-manual-page-for-binary linear_elasticity_example gismo-examples.x86_64: W: no-manual-page-for-binary mpi_example gismo-examples.x86_64: W: no-manual-page-for-binary multiGrid_example gismo-examples.x86_64: W: no-manual-page-for-binary nonlinear_example gismo-examples.x86_64: W: no-manual-page-for-binary optimizer_example gismo-examples.x86_64: W: no-manual-page-for-binary pMultiGrid_example gismo-examples.x86_64: W: no-manual-page-for-binary parametrization_example gismo-examples.x86_64: W: no-manual-page-for-binary paraview_example gismo-examples.x86_64: W: no-manual-page-for-binary patches_from_mesh gismo-examples.x86_64: W: no-manual-page-for-binary poisson2_example gismo-examples.x86_64: W: no-manual-page-for-binary poissonTHB_example gismo-examples.x86_64: W: no-manual-page-for-binary precision_example gismo-examples.x86_64: W: no-manual-page-for-binary quadrature_example gismo-examples.x86_64: W: no-manual-page-for-binary quasiInterpolation_example gismo-examples.x86_64: W: no-manual-page-for-binary refitting_example gismo-examples.x86_64: W: no-manual-page-for-binary sparseSolvers_example gismo-examples.x86_64: W: no-manual-page-for-binary stokes_ieti_example gismo-examples.x86_64: W: no-manual-page-for-binary surfaceReparametrization_example gismo-examples.x86_64: W: no-manual-page-for-binary thbRefinement_example gismo-examples.x86_64: W: no-manual-page-for-binary thbSplineBasis_example gismo-examples.x86_64: W: no-manual-page-for-binary triangulatedMeshToSolid_example gismo-examples.x86_64: W: no-manual-page-for-binary trilinos_example gismo-data.noarch: W: no-documentation gismo-devel.x86_64: W: no-documentation gismo-examples.x86_64: W: no-documentation gismo-mpich-devel.x86_64: W: no-documentation gismo-mpich-examples.x86_64: W: no-documentation gismo-openmpi-devel.x86_64: W: no-documentation gismo-openmpi-examples.x86_64: W: no-documentation gismo.spec:168: W: macro-in-comment %{buildroot} gismo.spec:168: W: macro-in-comment %{_prefix} gismo-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/pkgconfig/gismo.pc libdir=${prefix}//usr/lib64 gismo-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/pkgconfig/gismo.pc includedir=${prefix}//usr/include gismo-mpich-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/mpich/lib/pkgconfig/gismo.pc libdir=${prefix}//usr/lib64/mpich/lib gismo-mpich-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/mpich/lib/pkgconfig/gismo.pc includedir=${prefix}//usr/include/mpich-x86_64 gismo-openmpi-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/openmpi/lib/pkgconfig/gismo.pc libdir=${prefix}//usr/lib64/openmpi/lib gismo-openmpi-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/openmpi/lib/pkgconfig/gismo.pc includedir=${prefix}//usr/include/openmpi-x86_64 11 packages and 0 specfiles checked; 11 errors, 67 warnings, 92 filtered, 11 badness; has taken 8.3 s Rpmlint (debuginfo) ------------------- Checking: gismo-examples-debuginfo-25.07.0-1.fc45.x86_64.rpm gismo-mpich-debuginfo-25.07.0-1.fc45.x86_64.rpm gismo-openmpi-examples-debuginfo-25.07.0-1.fc45.x86_64.rpm gismo-debuginfo-25.07.0-1.fc45.x86_64.rpm gismo-mpich-examples-debuginfo-25.07.0-1.fc45.x86_64.rpm gismo-openmpi-debuginfo-25.07.0-1.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpok9287qu')] checks: 32, packages: 6 6 packages and 0 specfiles checked; 0 errors, 0 warnings, 370 filtered, 0 badness; has taken 44.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "gismo-mpich-devel". (none): E: there is no installed rpm "gismo-openmpi-examples-debuginfo". (none): E: there is no installed rpm "gismo-mpich-examples-debuginfo". (none): E: there is no installed rpm "gismo-openmpi-examples". (none): E: there is no installed rpm "gismo-data". (none): E: there is no installed rpm "gismo-mpich-debuginfo". (none): E: there is no installed rpm "gismo". (none): E: there is no installed rpm "gismo-openmpi-debuginfo". (none): E: there is no installed rpm "gismo-mpich". (none): E: there is no installed rpm "gismo-mpich-examples". (none): E: there is no installed rpm "gismo-examples-debuginfo". (none): E: there is no installed rpm "gismo-openmpi-devel". (none): E: there is no installed rpm "gismo-devel". (none): E: there is no installed rpm "gismo-examples". (none): E: there is no installed rpm "gismo-openmpi". ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 16 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "gismo-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. Requires -------- gismo (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsuperlu.so.7()(64bit) rtld(GNU_HASH) gismo-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) gismo(x86-64) gismo-examples (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgismo.so.25()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsuperlu.so.7()(64bit) rtld(GNU_HASH) gismo-data (rpmlib, GLIBC filtered): gismo-openmpi (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libmpi.so.40()(64bit)(openmpi-x86_64) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsuperlu.so.7()(64bit) openmpi(x86-64) rtld(GNU_HASH) gismo-openmpi-devel (rpmlib, GLIBC filtered): gismo-openmpi(x86-64) openmpi-devel(x86-64) gismo-openmpi-examples (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgismo.so.25()(64bit)(openmpi-x86_64) libm.so.6()(64bit) libmpi.so.40()(64bit)(openmpi-x86_64) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsuperlu.so.7()(64bit) rtld(GNU_HASH) gismo-mpich (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libmpi.so.12()(64bit)(mpich-x86_64) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsuperlu.so.7()(64bit) mpich(x86-64) rtld(GNU_HASH) gismo-mpich-devel (rpmlib, GLIBC filtered): gismo-mpich(x86-64) mpich-devel(x86-64) gismo-mpich-examples (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgismo.so.25()(64bit)(mpich-x86_64) libm.so.6()(64bit) libmpi.so.12()(64bit)(mpich-x86_64) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsuperlu.so.7()(64bit) rtld(GNU_HASH) Provides -------- gismo: gismo gismo(x86-64) libgismo.so.25()(64bit) gismo-devel: cmake(gismo) cmake(gs) gismo-devel gismo-devel(x86-64) pkgconfig(gismo) gismo-examples: gismo-examples gismo-examples(x86-64) gismo-data: gismo-data gismo-openmpi: gismo-openmpi gismo-openmpi(x86-64) libgismo.so.25()(64bit)(openmpi-x86_64) gismo-openmpi-devel: gismo-openmpi-devel gismo-openmpi-devel(x86-64) gismo-openmpi-examples: gismo-openmpi-examples gismo-openmpi-examples(x86-64) gismo-mpich: gismo-mpich gismo-mpich(x86-64) libgismo.so.25()(64bit)(mpich-x86_64) gismo-mpich-devel: gismo-mpich-devel gismo-mpich-devel(x86-64) gismo-mpich-examples: gismo-mpich-examples gismo-mpich-examples(x86-64) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name gismo --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: R, Perl, Java, PHP, Haskell, SugarActivity, fonts, Ocaml, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH