This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 32389120 bytes in 1342 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make %{?_smp_mflags} macro. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libobjfw , libobjfwrt , libobjfwrt-devel , libobjfwtls , libobjfwtls-devel , ofarc , ofdns , ofhash , ofhttp , objfw-docs [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 33341440 bytes in /usr/share objfw- docs-1.0-1.fc40.x86_64.rpm:32552960 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: objfw-1.0-1.fc40.x86_64.rpm libobjfw-1.0-1.fc40.x86_64.rpm libobjfw-devel-1.0-1.fc40.x86_64.rpm libobjfwrt-1.0-1.fc40.x86_64.rpm libobjfwrt-devel-1.0-1.fc40.x86_64.rpm libobjfwtls-1.0-1.fc40.x86_64.rpm libobjfwtls-devel-1.0-1.fc40.x86_64.rpm ofarc-1.0-1.fc40.x86_64.rpm ofdns-1.0-1.fc40.x86_64.rpm ofhash-1.0-1.fc40.x86_64.rpm ofhttp-1.0-1.fc40.x86_64.rpm objfw-docs-1.0-1.fc40.x86_64.rpm objfw-debuginfo-1.0-1.fc40.x86_64.rpm objfw-debugsource-1.0-1.fc40.x86_64.rpm objfw-1.0-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1s7pib9t')] checks: 31, packages: 15 libobjfw-devel.x86_64: E: rpath-in-buildconfig /usr/bin/objfw-config lines 69 libobjfw-devel.x86_64: W: position-independent-executable-suggested /usr/bin/objfw-new ofarc.x86_64: W: position-independent-executable-suggested /usr/bin/ofarc ofdns.x86_64: W: position-independent-executable-suggested /usr/bin/ofdns ofhash.x86_64: W: position-independent-executable-suggested /usr/bin/ofhash ofhttp.x86_64: W: position-independent-executable-suggested /usr/bin/ofhttp libobjfw-devel.x86_64: W: no-manual-page-for-binary objfw-compile libobjfw-devel.x86_64: W: no-manual-page-for-binary objfw-config libobjfw-devel.x86_64: W: no-manual-page-for-binary objfw-embed libobjfw-devel.x86_64: W: no-manual-page-for-binary objfw-new ofarc.x86_64: W: no-manual-page-for-binary ofarc ofdns.x86_64: W: no-manual-page-for-binary ofdns ofhash.x86_64: W: no-manual-page-for-binary ofhash ofhttp.x86_64: W: no-manual-page-for-binary ofhttp objfw.x86_64: W: no-documentation ofarc.x86_64: W: no-documentation ofdns.x86_64: W: no-documentation ofhash.x86_64: W: no-documentation ofhttp.x86_64: W: no-documentation objfw.x86_64: E: no-binary objfw-docs.x86_64: E: no-binary objfw.spec:143: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 143) objfw-docs.x86_64: W: files-duplicate /usr/share/doc/objfw/search/functions_0.js /usr/share/doc/objfw/search/all_0.js 15 packages and 0 specfiles checked; 3 errors, 20 warnings, 3 badness; has taken 1.4 s Rpmlint (debuginfo) ------------------- Checking: objfw-debuginfo-1.0-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfgneuv15')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 14 libobjfw-devel.x86_64: E: rpath-in-buildconfig /usr/bin/objfw-config lines 69 ofhash.x86_64: W: position-independent-executable-suggested /usr/bin/ofhash ofdns.x86_64: W: position-independent-executable-suggested /usr/bin/ofdns libobjfw-devel.x86_64: W: position-independent-executable-suggested /usr/bin/objfw-new ofarc.x86_64: W: position-independent-executable-suggested /usr/bin/ofarc ofhttp.x86_64: W: position-independent-executable-suggested /usr/bin/ofhttp ofhash.x86_64: W: no-manual-page-for-binary ofhash ofdns.x86_64: W: no-manual-page-for-binary ofdns libobjfw-devel.x86_64: W: no-manual-page-for-binary objfw-compile libobjfw-devel.x86_64: W: no-manual-page-for-binary objfw-config libobjfw-devel.x86_64: W: no-manual-page-for-binary objfw-embed libobjfw-devel.x86_64: W: no-manual-page-for-binary objfw-new ofarc.x86_64: W: no-manual-page-for-binary ofarc ofhttp.x86_64: W: no-manual-page-for-binary ofhttp ofhash.x86_64: W: no-documentation ofdns.x86_64: W: no-documentation ofarc.x86_64: W: no-documentation ofhttp.x86_64: W: no-documentation objfw.x86_64: W: no-documentation objfw-docs.x86_64: E: no-binary objfw.x86_64: E: no-binary objfw-docs.x86_64: W: files-duplicate /usr/share/doc/objfw/search/functions_0.js /usr/share/doc/objfw/search/all_0.js 14 packages and 0 specfiles checked; 3 errors, 19 warnings, 3 badness; has taken 1.2 s Source checksums ---------------- https://objfw.nil.im/downloads/objfw-1.0.tar.gz.sig : CHECKSUM(SHA256) this package : b5092f72ecf93492f70b1c6ce26ce127bf638981227f7472685bcf0c94899d01 CHECKSUM(SHA256) upstream package : b5092f72ecf93492f70b1c6ce26ce127bf638981227f7472685bcf0c94899d01 https://objfw.nil.im/downloads/objfw-1.0.tar.gz : CHECKSUM(SHA256) this package : a6aa3bf590c6a7ae21cf13dbaa94a72926e67af5c7d5aef4a2b172543d1f26a3 CHECKSUM(SHA256) upstream package : a6aa3bf590c6a7ae21cf13dbaa94a72926e67af5c7d5aef4a2b172543d1f26a3 Requires -------- objfw (rpmlib, GLIBC filtered): libobjfw(x86-64) libobjfw-devel(x86-64) libobjfwrt(x86-64) libobjfwrt-devel(x86-64) libobjfwtls(x86-64) libobjfwtls-devel(x86-64) ofarc(x86-64) ofdns(x86-64) ofhash(x86-64) ofhttp(x86-64) libobjfw (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libm.so.6()(64bit) libobjfwrt(x86-64) libobjfwrt.so.1()(64bit) rtld(GNU_HASH) libobjfw-devel (rpmlib, GLIBC filtered): /usr/bin/sh libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libobjfw(x86-64) libobjfw.so.1()(64bit) libobjfwrt-devel(x86-64) libobjfwrt.so.1()(64bit) rtld(GNU_HASH) libobjfwrt (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) rtld(GNU_HASH) libobjfwrt-devel (rpmlib, GLIBC filtered): libobjfwrt(x86-64) libobjfwrt.so.1()(64bit) libobjfwtls (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgnutls.so.30()(64bit) libgnutls.so.30(GNUTLS_3_4)(64bit) libobjfw.so.1()(64bit) libobjfwrt.so.1()(64bit) rtld(GNU_HASH) libobjfwtls-devel (rpmlib, GLIBC filtered): libobjfw-devel(x86-64) libobjfwrt-devel(x86-64) libobjfwtls(x86-64) libobjfwtls.so.1()(64bit) ofarc (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libobjfw.so.1()(64bit) libobjfwrt.so.1()(64bit) rtld(GNU_HASH) ofdns (rpmlib, GLIBC filtered): libc.so.6()(64bit) libobjfw.so.1()(64bit) libobjfwrt.so.1()(64bit) rtld(GNU_HASH) ofhash (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libobjfw.so.1()(64bit) libobjfwrt.so.1()(64bit) rtld(GNU_HASH) ofhttp (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libobjfw.so.1()(64bit) libobjfwrt.so.1()(64bit) libobjfwtls.so.1()(64bit) rtld(GNU_HASH) objfw-docs (rpmlib, GLIBC filtered): objfw-debuginfo (rpmlib, GLIBC filtered): objfw-debugsource (rpmlib, GLIBC filtered): Provides -------- objfw: objfw objfw(x86-64) libobjfw: libobjfw libobjfw(x86-64) libobjfw.so.1()(64bit) libobjfw-devel: libobjfw-devel libobjfw-devel(x86-64) libobjfwrt: libobjfwrt libobjfwrt(x86-64) libobjfwrt.so.1()(64bit) libobjfwrt-devel: libobjfwrt-devel libobjfwrt-devel(x86-64) libobjfwtls: libobjfwtls libobjfwtls(x86-64) libobjfwtls.so.1()(64bit) libobjfwtls-devel: libobjfwtls-devel libobjfwtls-devel(x86-64) ofarc: ofarc ofarc(x86-64) ofdns: ofdns ofdns(x86-64) ofhash: ofhash ofhash(x86-64) ofhttp: ofhttp ofhttp(x86-64) objfw-docs: objfw-docs objfw-docs(x86-64) objfw-debuginfo: objfw-debuginfo objfw-debuginfo(x86-64) objfw-debugsource: objfw-debugsource objfw-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name objfw --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Python, Haskell, Java, fonts, Perl, Ocaml, R, SugarActivity, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH