This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* GNU General Public License v3.0 or later and/or MIT License", "*No copyright* MIT License". 800 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/rust- coreutils/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr, /usr/share, /usr/share/doc, /usr/src, /usr/lib, /usr/share/licenses, /usr/bin, /usr/src/debug [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib, /usr/share/licenses, /usr/bin, /usr/share/doc, /usr, /usr/share, /usr/src, /usr/src/debug [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 37563 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in coreutils [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: coreutils-0.0.23-1.fc41.x86_64.rpm rust-coreutils-debugsource-0.0.23-1.fc41.x86_64.rpm rust-coreutils-0.0.23-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpf6ikylk7')] checks: 32, packages: 3 coreutils.x86_64: W: summary-not-capitalized coreutils ~ GNU coreutils reimplementation in Rust rust-coreutils.src: W: summary-not-capitalized coreutils ~ GNU coreutils reimplementation in Rust coreutils.x86_64: E: spelling-error ('reimplementation', 'Summary(en_US) reimplementation -> re implementation, re-implementation, implementation') rust-coreutils.src: E: spelling-error ('reimplementation', 'Summary(en_US) reimplementation -> re implementation, re-implementation, implementation') coreutils.x86_64: W: no-manual-page-for-binary uutils-coreutils coreutils.x86_64: W: name-repeated-in-summary coreutils 3 packages and 0 specfiles checked; 2 errors, 4 warnings, 11 filtered, 2 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rust-coreutils-debugsource". ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 coreutils.x86_64: E: spelling-error ('fileutils', '%description -l en_US fileutils -> fillets') coreutils.x86_64: E: spelling-error ('textutils', '%description -l en_US textutils -> textiles') coreutils.x86_64: W: no-manual-page-for-binary [ coreutils.x86_64: W: no-manual-page-for-binary arch coreutils.x86_64: W: no-manual-page-for-binary b2sum coreutils.x86_64: W: no-manual-page-for-binary base32 coreutils.x86_64: W: no-manual-page-for-binary base64 coreutils.x86_64: W: no-manual-page-for-binary basename coreutils.x86_64: W: no-manual-page-for-binary basenc coreutils.x86_64: W: no-manual-page-for-binary cat coreutils.x86_64: W: no-manual-page-for-binary chcon coreutils.x86_64: W: no-manual-page-for-binary chgrp coreutils.x86_64: W: no-manual-page-for-binary chmod coreutils.x86_64: W: no-manual-page-for-binary chown coreutils.x86_64: W: no-manual-page-for-binary cksum coreutils.x86_64: W: no-manual-page-for-binary comm coreutils.x86_64: W: no-manual-page-for-binary cp coreutils.x86_64: W: no-manual-page-for-binary csplit coreutils.x86_64: W: no-manual-page-for-binary cut coreutils.x86_64: W: no-manual-page-for-binary date coreutils.x86_64: W: no-manual-page-for-binary dd coreutils.x86_64: W: no-manual-page-for-binary df coreutils.x86_64: W: no-manual-page-for-binary dir coreutils.x86_64: W: no-manual-page-for-binary dircolors coreutils.x86_64: W: no-manual-page-for-binary dirname coreutils.x86_64: W: no-manual-page-for-binary du coreutils.x86_64: W: no-manual-page-for-binary echo coreutils.x86_64: W: no-manual-page-for-binary env coreutils.x86_64: W: no-manual-page-for-binary expand coreutils.x86_64: W: no-manual-page-for-binary expr coreutils.x86_64: W: no-manual-page-for-binary factor coreutils.x86_64: W: no-manual-page-for-binary false coreutils.x86_64: W: no-manual-page-for-binary fmt coreutils.x86_64: W: no-manual-page-for-binary fold coreutils.x86_64: W: no-manual-page-for-binary groups coreutils.x86_64: W: no-manual-page-for-binary head coreutils.x86_64: W: no-manual-page-for-binary hostid coreutils.x86_64: W: no-manual-page-for-binary id coreutils.x86_64: W: no-manual-page-for-binary install coreutils.x86_64: W: no-manual-page-for-binary join coreutils.x86_64: W: no-manual-page-for-binary link coreutils.x86_64: W: no-manual-page-for-binary ln coreutils.x86_64: W: no-manual-page-for-binary logname coreutils.x86_64: W: no-manual-page-for-binary ls coreutils.x86_64: W: no-manual-page-for-binary md5sum coreutils.x86_64: W: no-manual-page-for-binary mkdir coreutils.x86_64: W: no-manual-page-for-binary mkfifo coreutils.x86_64: W: no-manual-page-for-binary mknod coreutils.x86_64: W: no-manual-page-for-binary mktemp coreutils.x86_64: W: no-manual-page-for-binary mv coreutils.x86_64: W: no-manual-page-for-binary nice coreutils.x86_64: W: no-manual-page-for-binary nl coreutils.x86_64: W: no-manual-page-for-binary nohup coreutils.x86_64: W: no-manual-page-for-binary nproc coreutils.x86_64: W: no-manual-page-for-binary numfmt coreutils.x86_64: W: no-manual-page-for-binary od coreutils.x86_64: W: no-manual-page-for-binary paste coreutils.x86_64: W: no-manual-page-for-binary pathchk coreutils.x86_64: W: no-manual-page-for-binary pinky coreutils.x86_64: W: no-manual-page-for-binary pr coreutils.x86_64: W: no-manual-page-for-binary printenv coreutils.x86_64: W: no-manual-page-for-binary printf coreutils.x86_64: W: no-manual-page-for-binary ptx coreutils.x86_64: W: no-manual-page-for-binary pwd coreutils.x86_64: W: no-manual-page-for-binary readlink coreutils.x86_64: W: no-manual-page-for-binary realpath coreutils.x86_64: W: no-manual-page-for-binary rm coreutils.x86_64: W: no-manual-page-for-binary rmdir coreutils.x86_64: W: no-manual-page-for-binary runcon coreutils.x86_64: W: no-manual-page-for-binary seq coreutils.x86_64: W: no-manual-page-for-binary sha1sum coreutils.x86_64: W: no-manual-page-for-binary sha224sum coreutils.x86_64: W: no-manual-page-for-binary sha256sum coreutils.x86_64: W: no-manual-page-for-binary sha384sum coreutils.x86_64: W: no-manual-page-for-binary sha512sum coreutils.x86_64: W: no-manual-page-for-binary shred coreutils.x86_64: W: no-manual-page-for-binary shuf coreutils.x86_64: W: no-manual-page-for-binary sleep coreutils.x86_64: W: no-manual-page-for-binary sort coreutils.x86_64: W: no-manual-page-for-binary split coreutils.x86_64: W: no-manual-page-for-binary stat coreutils.x86_64: W: no-manual-page-for-binary stdbuf coreutils.x86_64: W: no-manual-page-for-binary stty coreutils.x86_64: W: no-manual-page-for-binary sum coreutils.x86_64: W: no-manual-page-for-binary sync coreutils.x86_64: W: no-manual-page-for-binary tac coreutils.x86_64: W: no-manual-page-for-binary tail coreutils.x86_64: W: no-manual-page-for-binary tee coreutils.x86_64: W: no-manual-page-for-binary test coreutils.x86_64: W: no-manual-page-for-binary timeout coreutils.x86_64: W: no-manual-page-for-binary touch coreutils.x86_64: W: no-manual-page-for-binary tr coreutils.x86_64: W: no-manual-page-for-binary true coreutils.x86_64: W: no-manual-page-for-binary truncate coreutils.x86_64: W: no-manual-page-for-binary tsort coreutils.x86_64: W: no-manual-page-for-binary tty coreutils.x86_64: W: no-manual-page-for-binary uname coreutils.x86_64: W: no-manual-page-for-binary unexpand coreutils.x86_64: W: no-manual-page-for-binary uniq coreutils.x86_64: W: no-manual-page-for-binary unlink coreutils.x86_64: W: no-manual-page-for-binary users coreutils.x86_64: W: no-manual-page-for-binary vdir coreutils.x86_64: W: no-manual-page-for-binary wc coreutils.x86_64: W: no-manual-page-for-binary who coreutils.x86_64: W: no-manual-page-for-binary whoami coreutils.x86_64: W: no-manual-page-for-binary yes coreutils.x86_64: W: no-manual-page-for-binary chroot coreutils.x86_64: W: no-documentation coreutils.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/4a/c9b183e917e4751a56ae4a758ec2017afaf2af ../../../../usr/bin/coreutils.single 1 packages and 0 specfiles checked; 2 errors, 107 warnings, 3 filtered, 2 badness; has taken 4.7 s Source checksums ---------------- https://crates.io/api/v1/crates/coreutils/0.0.23/download#/coreutils-0.0.23.crate : CHECKSUM(SHA256) this package : 5054835867054de17d86139c363651316d08bc0414640d4ef287f934f10f3d17 CHECKSUM(SHA256) upstream package : 5054835867054de17d86139c363651316d08bc0414640d4ef287f934f10f3d17 Requires -------- coreutils (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libonig.so.5()(64bit) rtld(GNU_HASH) rust-coreutils-debugsource (rpmlib, GLIBC filtered): Provides -------- coreutils: coreutils coreutils(x86-64) rust-coreutils-debugsource: rust-coreutils-debugsource rust-coreutils-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-coreutils --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Java, PHP, Haskell, C/C++, Perl, SugarActivity, Python, fonts, R, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH