This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'BSD'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/cros-guest-tools See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in cros-host-fonts See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in cros-garcon, cros- notificationd, cros-sommelier, cros-sommelier-config See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc/skel/.config/pulse [ ]: Package must own all directories that it creates. Note: Directories without known owners: /var/lib/polkit-1/localauthority/10-vendor.d, /var/lib/polkit-1/localauthority, /etc/profile.d, /etc/gtk-2.0, /etc/skel/.config, /var/lib/polkit-1, /etc/skel/.config/pulse [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7371 bytes in 13 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cros- systemd-overrides , cros-logging , cros-adapta , cros-garcon , cros- host-fonts , cros-notificationd , cros-pulse-config , cros-sommelier , cros-sommelier-config , cros-sudo-config , cros-ui-config , cros- wayland [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr-rpmbuild/results/cros-guest- tools/srpm-unpacked/cros-guest-tools.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: cros-guest-tools-121-1.fc39.noarch.rpm cros-systemd-overrides-121-1.fc39.noarch.rpm cros-logging-121-1.fc39.noarch.rpm cros-adapta-121-1.fc39.noarch.rpm cros-garcon-121-1.fc39.noarch.rpm cros-host-fonts-121-1.fc39.noarch.rpm cros-notificationd-121-1.fc39.noarch.rpm cros-pulse-config-121-1.fc39.noarch.rpm cros-sommelier-121-1.fc39.noarch.rpm cros-sommelier-config-121-1.fc39.noarch.rpm cros-sudo-config-121-1.fc39.noarch.rpm cros-ui-config-121-1.fc39.noarch.rpm cros-wayland-121-1.fc39.noarch.rpm cros-guest-tools-121-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpd0j1ebwr')] checks: 32, packages: 14 cros-logging.noarch: W: tmpfiles-conf-in-etc /etc/tmpfiles.d/00-create-logs-dir.conf cros-sudo-config.noarch: W: summary-not-capitalized sudo config for Chromium OS integration. cros-pulse-config.noarch: W: summary-ended-with-dot PulseAudio helper for Chromium OS integration. cros-sudo-config.noarch: W: summary-ended-with-dot sudo config for Chromium OS integration. cros-adapta.noarch: E: spelling-error ('symlinks', '%description -l en_US symlinks -> slinks') cros-logging.noarch: E: spelling-error ('Journald', 'Summary(en_US) Journald -> Journals, Journal, Journal d') cros-pulse-config.noarch: E: spelling-error ('pulseaudio', '%description -l en_US pulseaudio -> pulse audio, pulse-audio, audiovisuals') cros-sudo-config.noarch: E: spelling-error ('passwordless', '%description -l en_US passwordless -> pass wordless, pass-wordless, password less') cros-sudo-config.noarch: E: spelling-error ('pkexec', '%description -l en_US pkexec -> pk exec, pk-exec, exec') cros-wayland.noarch: E: spelling-error ('virtwl', 'Summary(en_US) virtwl -> virtual') cros-wayland.noarch: W: only-non-binary-in-usr-lib cros-guest-tools.noarch: W: obsolete-not-provided cros-sftp cros-sudo-config.noarch: E: non-readable /etc/sudoers.d/10-cros-nopasswd 440 cros-sudo-config.noarch: E: non-readable /var/lib/polkit-1/localauthority/10-vendor.d/10-cros-nopasswd.pkla 440 cros-sommelier.noarch: E: non-executable-script /etc/sommelierrc 644 /bin/sh cros-garcon.noarch: W: non-conffile-in-etc /etc/skel/.config/cros-garcon.conf cros-logging.noarch: W: non-conffile-in-etc /etc/tmpfiles.d/00-create-logs-dir.conf cros-pulse-config.noarch: W: non-conffile-in-etc /etc/skel/.config/pulse/daemon.conf cros-pulse-config.noarch: W: non-conffile-in-etc /etc/skel/.config/pulse/default.pa cros-sommelier.noarch: W: non-conffile-in-etc /etc/skel/.sommelierrc cros-garcon.noarch: W: no-manual-page-for-binary garcon-terminal-handler cros-garcon.noarch: W: no-manual-page-for-binary garcon-url-handler cros-sommelier.noarch: W: no-manual-page-for-binary sommelier cros-guest-tools.noarch: W: hidden-file-or-dir /etc/skel/.config cros-sommelier-config.noarch: W: files-duplicate /usr/lib/systemd/user/sommelier@1.service.d/cros-sommelier-low-density-override.conf /usr/lib/systemd/user/sommelier-x@1.service.d/cros-sommelier-low-density-override.conf cros-garcon.noarch: W: desktopfile-without-binary /usr/share/applications/garcon_host_browser.desktop /opt/google/cros-containers/bin/garcon cros-adapta.noarch: W: dangling-symlink /usr/share/themes/CrosAdapta /opt/google/cros-containers/cros-adapta cros-sommelier.noarch: W: dangling-symlink /usr/bin/sommelier /opt/google/cros-containers/bin/sommelier 14 packages and 0 specfiles checked; 9 errors, 19 warnings, 61 filtered, 9 badness; has taken 1.1 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "cros-systemd-overrides". (none): E: there is no installed rpm "cros-logging". (none): E: there is no installed rpm "cros-sommelier-config". (none): E: there is no installed rpm "cros-garcon". (none): E: there is no installed rpm "cros-guest-tools". (none): E: there is no installed rpm "cros-host-fonts". (none): E: there is no installed rpm "cros-ui-config". (none): E: there is no installed rpm "cros-pulse-config". (none): E: there is no installed rpm "cros-sudo-config". (none): E: there is no installed rpm "cros-notificationd". (none): E: there is no installed rpm "cros-adapta". (none): E: there is no installed rpm "cros-wayland". (none): E: there is no installed rpm "cros-sommelier". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 13 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools/+archive/28f39c6.tar.gz#/cros-guest-tools-28f39c6.tar.gz : CHECKSUM(SHA256) this package : d820bc118343e31a8cfce56ec9e90e8cfe668516f0c26cbc461fd9daf3752da5 CHECKSUM(SHA256) upstream package : 8d7d2d7fff5bd72decb93394c7168844039ffb82ee32b31f0f88e22a16b3f376 However, diff -r shows no differences Requires -------- cros-guest-tools (rpmlib, GLIBC filtered): cros-adapta cros-garcon cros-host-fonts cros-logging cros-notificationd cros-pulse-config cros-sommelier cros-sommelier-config cros-sudo-config cros-systemd-overrides cros-ui-config cros-wayland cros-systemd-overrides (rpmlib, GLIBC filtered): /bin/sh systemd cros-logging (rpmlib, GLIBC filtered): systemd cros-adapta (rpmlib, GLIBC filtered): filesystem gtk-murrine-engine gtk2 gtk2-engines gtk3 qt5-qtstyleplugins cros-garcon (rpmlib, GLIBC filtered): /bin/sh /usr/bin/sh PackageKit ansible mailcap systemd cros-host-fonts (rpmlib, GLIBC filtered): fontpackages-filesystem cros-notificationd (rpmlib, GLIBC filtered): /bin/sh dbus-common cros-pulse-config (rpmlib, GLIBC filtered): alsa-plugins-pulseaudio pulseaudio-utils cros-sommelier (rpmlib, GLIBC filtered): /bin/sh config(cros-sommelier) gtk2 vim-common xorg-x11-fonts-100dpi xorg-x11-fonts-75dpi xorg-x11-fonts-ISO8859-1-100dpi xorg-x11-fonts-ISO8859-1-75dpi xorg-x11-fonts-ISO8859-14-100dpi xorg-x11-fonts-ISO8859-14-75dpi xorg-x11-fonts-ISO8859-15-100dpi xorg-x11-fonts-ISO8859-15-75dpi xorg-x11-fonts-ISO8859-2-100dpi xorg-x11-fonts-ISO8859-2-75dpi xorg-x11-fonts-ISO8859-9-100dpi xorg-x11-fonts-ISO8859-9-75dpi xorg-x11-fonts-Type1 xorg-x11-fonts-cyrillic xorg-x11-fonts-misc xorg-x11-xauth cros-sommelier-config (rpmlib, GLIBC filtered): cros-sommelier cros-sudo-config (rpmlib, GLIBC filtered): config(cros-sudo-config) sudo cros-ui-config (rpmlib, GLIBC filtered): config(cros-ui-config) dconf gtk2 gtk3 cros-wayland (rpmlib, GLIBC filtered): config(cros-wayland) systemd-udev Provides -------- cros-guest-tools: cros-guest-tools cros-systemd-overrides: cros-systemd-overrides cros-logging: cros-logging cros-adapta: cros-adapta cros-garcon: application() application(garcon_host_browser.desktop) cros-garcon mimehandler(x-scheme-handler/ftp) mimehandler(x-scheme-handler/http) mimehandler(x-scheme-handler/https) mimehandler(x-scheme-handler/mailto) cros-host-fonts: cros-host-fonts cros-notificationd: cros-notificationd cros-pulse-config: cros-pulse-config cros-sommelier: config(cros-sommelier) cros-sommelier cros-sommelier-config: cros-sommelier-config cros-sudo-config: config(cros-sudo-config) cros-sudo-config cros-ui-config: config(cros-ui-config) cros-ui-config cros-wayland: config(cros-wayland) cros-wayland Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name cros-guest-tools --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Generic, Shell-api Disabled plugins: R, PHP, Perl, fonts, Python, Haskell, Java, Ocaml, SugarActivity, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH