This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE-SELECT2.md is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in osh-worker, osh-hub See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 3", "*No copyright* GNU General Public License, Version 3". 113 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/osh/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr, /usr/sbin, /etc/httpd, /etc, /usr/bin, /usr/lib/python3.12/site-packages, /var/lib, /usr/lib/systemd/system, /var, /usr/lib/python3.12, /etc/httpd/conf.d, /usr/share/bash- completion, /usr/share/zsh, /var/log, /usr/lib/systemd, /usr/lib, /usr/share, /usr/share/licenses [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr, /usr/lib/python3.12, /usr/sbin, /etc/httpd/conf.d, /usr/bin, /usr/lib/python3.12/site- packages, /etc/httpd, /usr/share/bash-completion, /var/lib, /etc, /usr/lib/systemd/system, /etc/osh, /usr/lib/systemd, /usr/lib, /var, /usr/share, /usr/share/zsh, /usr/share/licenses, /var/log [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/openscanhub/openscanhub/archive/refs/tags/osh-1.0.0.20240523.115004.g305cd56.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in osh- client , osh-common , osh-worker , osh-hub , osh-hub-conf-devel , osh- worker-conf-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: osh-client-1.0.0.20240523.115004.g305cd56-1.fc40.noarch.rpm osh-common-1.0.0.20240523.115004.g305cd56-1.fc40.noarch.rpm osh-worker-1.0.0.20240523.115004.g305cd56-1.fc40.noarch.rpm osh-hub-1.0.0.20240523.115004.g305cd56-1.fc40.noarch.rpm osh-hub-conf-devel-1.0.0.20240523.115004.g305cd56-1.fc40.noarch.rpm osh-worker-conf-devel-1.0.0.20240523.115004.g305cd56-1.fc40.noarch.rpm osh-1.0.0.20240523.115004.g305cd56-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvrh2f5gj')] checks: 32, packages: 7 osh.src: E: spelling-error ('cli', '%description -l en_US cli -> cl, clii, clit') osh-hub.noarch: E: spelling-error ('xml', 'Summary(en_US) xml -> XML, ml') osh-hub.noarch: E: spelling-error ('rpc', 'Summary(en_US) rpc -> rec, rps, rpm') osh-hub.noarch: E: spelling-error ('xml', '%description -l en_US xml -> XML, ml') osh-hub.noarch: E: spelling-error ('rpc', '%description -l en_US rpc -> rec, rps, rpm') osh-hub.noarch: W: python-bytecode-without-source /usr/lib/python3.12/site-packages/osh/hub/scripts/__pycache__/osh-xmlrpc-client.cpython-312.opt-1.pyc osh-hub.noarch: W: python-bytecode-without-source /usr/lib/python3.12/site-packages/osh/hub/scripts/__pycache__/osh-xmlrpc-client.cpython-312.pyc osh-hub.noarch: W: python-bytecode-without-source /usr/lib/python3.12/site-packages/osh/hub/scripts/__pycache__/umb-emit.cpython-312.opt-1.pyc osh-hub.noarch: W: python-bytecode-without-source /usr/lib/python3.12/site-packages/osh/hub/scripts/__pycache__/umb-emit.cpython-312.pyc osh-common.noarch: W: obsolete-not-provided covscan-common osh-hub.noarch: W: obsolete-not-provided covscan-hub osh-worker.noarch: W: obsolete-not-provided covscan-worker osh-hub.noarch: E: non-standard-dir-perm /var/lib/osh/hub 775 osh-hub.noarch: E: non-standard-dir-perm /var/lib/osh/hub/tasks 775 osh-hub.noarch: E: non-standard-dir-perm /var/lib/osh/hub/upload 775 osh-hub.noarch: E: non-standard-dir-perm /var/lib/osh/hub/worker 775 osh-hub.noarch: E: non-standard-dir-perm /var/log/osh/hub 775 osh-hub.noarch: E: non-readable /etc/osh/hub/secrets/bugzilla_secret 640 osh-hub.noarch: E: non-readable /etc/osh/hub/secrets/jira_secret 640 osh-hub.noarch: E: non-readable /var/lib/osh/hub/secret_key 640 osh-hub-conf-devel.noarch: E: non-readable /etc/osh/hub/secrets/db_password 640 osh-worker-conf-devel.noarch: E: non-readable /etc/osh/worker.conf 640 osh-client.noarch: W: no-manual-page-for-binary covscan osh-client.noarch: W: no-manual-page-for-binary osh-cli osh-hub.noarch: W: no-manual-page-for-binary osh-retention osh-hub.noarch: W: no-manual-page-for-binary osh-stats osh-worker.noarch: W: no-manual-page-for-binary osh-worker osh-client.noarch: W: no-documentation osh-common.noarch: W: no-documentation osh-hub.noarch: W: no-documentation osh-hub-conf-devel.noarch: W: no-documentation osh-worker.noarch: W: no-documentation osh-worker-conf-devel.noarch: W: no-documentation osh-hub.noarch: W: log-files-without-logrotate ['/var/log/osh'] osh-worker.noarch: W: log-files-without-logrotate ['/var/log/osh'] osh-hub.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/osh/hub/static/Add2_32.png /usr/lib/python3.12/site-packages/osh/hub/static-assets/Add2_32.png osh-hub.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/osh/hub/static/Add_32.png /usr/lib/python3.12/site-packages/osh/hub/static-assets/Add_32.png osh-hub.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/osh/hub/static/Document_content_32.png /usr/lib/python3.12/site-packages/osh/hub/static-assets/Document_content_32.png osh-hub.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/osh/hub/static/Message_log_32.png /usr/lib/python3.12/site-packages/osh/hub/static-assets/Message_log_32.png osh-hub.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/osh/hub/static/Ok_32.png /usr/lib/python3.12/site-packages/osh/hub/static-assets/Ok_32.png osh-hub.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/osh/hub/static/Warning_32.png /usr/lib/python3.12/site-packages/osh/hub/static-assets/Warning_32.png osh-hub.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/osh/hub/static/css/redhat.css /usr/lib/python3.12/site-packages/osh/hub/static-assets/css/redhat.css osh-hub.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/osh/hub/static/admin/js/vendor/select2/LICENSE.md /usr/lib/python3.12/site-packages/osh/hub/static/admin/css/vendor/select2/LICENSE-SELECT2.md osh-hub.noarch: W: empty-%postun osh-client.noarch: W: dangerous-command-in-%post mv 7 packages and 0 specfiles checked; 15 errors, 30 warnings, 34 filtered, 15 badness; has taken 1.1 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "osh-common". (none): E: there is no installed rpm "osh-worker-conf-devel". (none): E: there is no installed rpm "osh-worker". (none): E: there is no installed rpm "osh-client". (none): E: there is no installed rpm "osh-hub". (none): E: there is no installed rpm "osh-hub-conf-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Requires -------- osh-client (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python3 config(osh-client) koji osh-common python(abi) python3-kobo-client osh-common (rpmlib, GLIBC filtered): python(abi) osh-worker (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python3 csmock file koji osh-common python(abi) python3-kobo-client python3-kobo-worker osh-hub (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python3 csdiff gzip httpd koji mod_auth_gssapi mod_ssl osh-common postgresql python(abi) python3-bugzilla python3-csdiff python3-django python3-jira python3-kobo-client python3-kobo-django python3-kobo-hub python3-mod_wsgi python3-psycopg2 python3-qpid-proton xz osh-hub-conf-devel (rpmlib, GLIBC filtered): config(osh-hub-conf-devel) httpd-filesystem osh-hub python(abi) osh-worker-conf-devel (rpmlib, GLIBC filtered): config(osh-worker-conf-devel) Provides -------- osh-client: config(osh-client) covscan-client osh-cli osh-client python3.12dist(osh) python3dist(osh) osh-common: osh-common osh-worker: osh-worker osh-hub: osh-hub osh-hub-conf-devel: config(osh-hub-conf-devel) osh-hub-conf osh-hub-conf-devel osh-worker-conf-devel: config(osh-worker-conf-devel) osh-worker-conf osh-worker-conf-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name osh --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-40-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Java, R, SugarActivity, PHP, Ocaml, C/C++, fonts, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH