This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/nodejs-aw-webui/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "ISC License and/or MIT License", "*No copyright* ISC License", "MIT License", "*No copyright* MIT License", "MIT License [generated file]", "*No copyright* Apache License 2.0", "ISC License", "Apache License 2.0 and/or MIT License", "BSD 2-Clause License", "*No copyright* BSD 2-Clause License", "Apache License 2.0", "*No copyright* Creative Commons Attribution 4.0", "Apache License 2.0 and/or ISC License", "Apache License 2.0 and/or BSD 2-Clause License", "*No copyright* Artistic License 2.0", "*No copyright* The Unlicense", "*No copyright* DON'T BE A DICK PUBLIC LICENSE", "W3C License", "*No copyright* W3C Software and Document Notice and License (2015-05-13)", "Academic Free License v2.1 and/or BSD 3-Clause License", "*No copyright* Academic Free License", "*No copyright* Academic Free License v2.1", "*No copyright* Creative Commons CC0 1.0", "MIT License and/or X11 License", "Do What The Fuck You Want To Public License, Version 2 and/or MIT License", "*No copyright* MIT License and/or X11 License", "Creative Commons CC0 1.0", "BSD 3-Clause License and/or MIT License", "Creative Commons Attribution 3.0", "*No copyright* Creative Commons Attribution 3.0", "*No copyright* BSD 2-Clause License and/or BSD 3-Clause License and/or GNU Lesser General Public License, Version 2.1 and/or MIT License", "*No copyright* BSD 3-Clause Clear License", "BSD 0-Clause License", "*No copyright* BSD 0-Clause License", "BSD 2-Clause with views sentence", "*No copyright* Creative Commons Attribution-ShareAlike 4.0", "Apache License 2.0 and/or BSD 3-Clause License", "GNU Library General Public License v2 or later", "*No copyright* MIT License [generated file]". 42429 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/nodejs-aw-webui/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses, /usr/share, /usr/share/doc, /usr [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc, /usr/share/licenses, /usr/share, /usr [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4211 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr-rpmbuild/results/nodejs-aw- webui/srpm-unpacked/nodejs-aw-webui.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: nodejs-aw-webui-0^20240518.05c25c9-1.fc38.noarch.rpm nodejs-aw-webui-0^20240518.05c25c9-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzn0zrgl3')] checks: 32, packages: 2 nodejs-aw-webui.spec: W: invalid-url Source2: aw-webui-05c25c9-nm-dev.tgz nodejs-aw-webui.spec: W: invalid-url Source1: aw-webui-05c25c9-nm-prod.tgz 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 1.7 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "nodejs-aw-webui". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/ActivityWatch/media/blob/cb597f7c2e2b135505fe5d6b3042960a638892cf/logo/logo.svg : CHECKSUM(SHA256) this package : e2d2e1f00beb882c32de7a124bb91e433bbbb55a765580d7a169ca0260a5231a CHECKSUM(SHA256) upstream package : 9d58fec07411378e6742b3d4e81bf3cbf04a08103c959af9a8f719f66250aac0 https://github.com/ActivityWatch/media/blob/cb597f7c2e2b135505fe5d6b3042960a638892cf/logo/logo.png : CHECKSUM(SHA256) this package : ac6e91b8373362f2c141f2b8045906a69c77bc9781d71491754630ce217e9641 CHECKSUM(SHA256) upstream package : 3e8ee693c3db42592439d38740ed0409299f515e60d38027a9609dd6f68d0162 https://github.com/ActivityWatch/aw-webui/archive/05c25c98b172fcb72e2ae7cbf40be6bc77526c65/aw-webui-05c25c9.tar.gz : CHECKSUM(SHA256) this package : 82a113b95db0ce98c4ddc076971b37e224ae835ec5f0bbae6e8589c21623a827 CHECKSUM(SHA256) upstream package : 82a113b95db0ce98c4ddc076971b37e224ae835ec5f0bbae6e8589c21623a827 diff -r also reports differences Requires -------- nodejs-aw-webui (rpmlib, GLIBC filtered): Provides -------- nodejs-aw-webui: nodejs-aw-webui Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nodejs-aw-webui --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-38-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Python, PHP, Java, R, Ocaml, C/C++, Haskell, Perl, fonts, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH