This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression '0BSD and Apache-2.0 and (Apache-2.0 OR MIT) and Artistic-2.0 and BSD-2-Clause and BSD-3-Clause and CC-BY-4.0 and ISC and MIT and MPL-2.0 and (MPL-2.0 OR Apache-2.0) and Unlicense and W3C-20150513"'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "ISC License and/or MIT License", "*No copyright* ISC License", "MIT License", "*No copyright* MIT License", "MIT License [generated file]", "*No copyright* Apache License 2.0", "ISC License", "Apache License 2.0 and/or MIT License", "BSD 2-Clause License", "*No copyright* BSD 2-Clause License", "Apache License 2.0", "*No copyright* Creative Commons Attribution 4.0", "Apache License 2.0 and/or ISC License", "Apache License 2.0 and/or BSD 2-Clause License", "*No copyright* Artistic License 2.0", "*No copyright* The Unlicense", "*No copyright* DON'T BE A DICK PUBLIC LICENSE", "W3C License", "*No copyright* W3C Software and Document Notice and License (2015-05-13)", "Academic Free License v2.1 and/or BSD 3-Clause License", "*No copyright* Academic Free License", "*No copyright* Academic Free License v2.1", "*No copyright* Creative Commons CC0 1.0", "MIT License and/or X11 License", "Do What The Fuck You Want To Public License, Version 2 and/or MIT License", "*No copyright* MIT License and/or X11 License", "Creative Commons CC0 1.0", "BSD 3-Clause License and/or MIT License", "Creative Commons Attribution 3.0", "*No copyright* Creative Commons Attribution 3.0", "*No copyright* BSD 2-Clause License and/or BSD 3-Clause License and/or GNU Lesser General Public License, Version 2.1 and/or MIT License", "*No copyright* BSD 3-Clause Clear License", "BSD 0-Clause License", "*No copyright* BSD 0-Clause License", "BSD 2-Clause with views sentence", "*No copyright* Creative Commons Attribution-ShareAlike 4.0", "Apache License 2.0 and/or BSD 3-Clause License", "GNU Library General Public License v2 or later". 41388 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/nodejs-aw-webui/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib, /usr/lib/node_modules_20, /usr/share/doc, /usr, /usr/share/licenses, /usr/share [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib, /usr/share/doc, /usr/lib/node_modules_20, /usr, /usr/share/licenses, /usr/share [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4211 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: nodejs-aw-webui-7de395b-1.fc39.noarch.rpm nodejs-aw-webui-7de395b-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp55ww8wzk')] checks: 32, packages: 2 nodejs-aw-webui.noarch: E: script-without-shebang /usr/share/licenses/nodejs-aw-webui/aw-webui-7de395b-bundled-licenses.txt nodejs-aw-webui.noarch: W: only-non-binary-in-usr-lib nodejs-aw-webui.noarch: W: invalid-license W3C-20150513" nodejs-aw-webui.src: W: invalid-license W3C-20150513" nodejs-aw-webui.noarch: W: files-duplicate /usr/lib/node_modules_20/aw-webui/dist/css/9412.0e21fe03.css /usr/lib/node_modules_20/aw-webui/dist/css/3729.0e21fe03.css:/usr/lib/node_modules_20/aw-webui/dist/css/495.0e21fe03.css:/usr/lib/node_modules_20/aw-webui/dist/css/5912.0e21fe03.css:/usr/lib/node_modules_20/aw-webui/dist/css/7362.0e21fe03.css:/usr/lib/node_modules_20/aw-webui/dist/css/782.0e21fe03.css:(and 2 more) 2 packages and 0 specfiles checked; 1 errors, 4 warnings, 7 filtered, 1 badness; has taken 1.7 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "nodejs-aw-webui". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/ActivityWatch/media/archive/ae8d3737a4984cc891076dc830ad117b13288a9f/media-ae8d373.tar.gz : CHECKSUM(SHA256) this package : 2e2daddeb61cf3289b2894f3d21e6e8edc997a777c2cb1c995841dc276368872 CHECKSUM(SHA256) upstream package : 2e2daddeb61cf3289b2894f3d21e6e8edc997a777c2cb1c995841dc276368872 https://github.com/wojnilowicz/activitywatch-copr/releases/download/7de395b/aw-webui-7de395b-nm-dev.tgz : CHECKSUM(SHA256) this package : a50a010cf2da9bd7eeac1cf1540a7121235aa54ac96014390855e1c77b4ceacd CHECKSUM(SHA256) upstream package : a50a010cf2da9bd7eeac1cf1540a7121235aa54ac96014390855e1c77b4ceacd https://github.com/wojnilowicz/activitywatch-copr/releases/download/7de395b/aw-webui-7de395b-nm-prod.tgz : CHECKSUM(SHA256) this package : 528a71afeed9cf9eebb204eeb62c7718812f145489a0d1b4d3be8a6293d58c7d CHECKSUM(SHA256) upstream package : 528a71afeed9cf9eebb204eeb62c7718812f145489a0d1b4d3be8a6293d58c7d https://github.com/ActivityWatch/aw-webui/archive/7de395b4b5d9097c2ee6fd2afcc9876bc969df66/aw-webui-7de395b.tar.gz : CHECKSUM(SHA256) this package : 924f1b897924493695a3b93b65fba25fb5c3f8c858c312e5e9e8a409e5ca03eb CHECKSUM(SHA256) upstream package : 924f1b897924493695a3b93b65fba25fb5c3f8c858c312e5e9e8a409e5ca03eb Requires -------- nodejs-aw-webui (rpmlib, GLIBC filtered): nodejs Provides -------- nodejs-aw-webui: nodejs-aw-webui Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nodejs-aw-webui --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, R, SugarActivity, Java, Haskell, Ocaml, PHP, Python, fonts, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH