This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.page is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text


===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "*No copyright* GNU General Public License", "GNU General Public
     License v3.0 or later", "*No copyright* GNU General Public License,
     Version 2", "GNU General Public License v2.0 or later", "GNU Lesser
     General Public License v2.1 or later", "*No copyright* GNU Lesser
     General Public License v2.1 or later", "*No copyright* GNU General
     Public License v2.0 or later [obsolete FSF postal address (Temple
     Place)]", "*No copyright* GNU General Public License v2.0 or later",
     "*No copyright* GNU Free Documentation License v1.1 or later", "GNU
     Free Documentation License v1.1", "*No copyright* MIT License", "MIT
     License", "GNU Library General Public License v2 or later", "libtiff
     License". 682 files have unknown license. Detailed output of
     licensecheck in /var/lib/copr-rpmbuild/results/papers/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/mjw, /usr/share/help/fa,
     /usr/share/locale/mjw/LC_MESSAGES
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/help/oc,
     /usr/share/help/en_GB, /usr/share/help/tr, /usr/share/help/uk,
     /usr/share/help/fi, /usr/share/help/pt_BR, /usr/share/help/fa,
     /usr/share/help/zh_HK, /usr/share/help/ja, /usr/share/help/id,
     /usr/share/help/bg, /usr/share/help/te, /usr/share/help/zh_CN,
     /usr/share/help/de, /usr/share/help/ko, /usr/share/help/ru,
     /usr/share/help/vi, /usr/share/help/ca, /usr/share/help/C,
     /usr/share/help/sl, /usr/share/help/cs, /usr/share/help/da,
     /usr/share/help/lv, /usr/share/help/it, /usr/share/help/fr,
     /usr/share/help/nl, /usr/share/locale/mjw, /usr/share/help/pl,
     /usr/share/help/hu, /usr/share/help/el, /usr/share/help/zh_TW,
     /usr/share/locale/mjw/LC_MESSAGES, /usr/share/help/es,
     /usr/share/help/gl, /usr/share/help/ro, /usr/share/help/sr,
     /usr/share/help/eu, /usr/share/help/sv
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 1469 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in papers-
     libs , papers-devel , papers-nautilus , papers-previewer , papers-
     thumbnailer
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[ ]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 11243520 bytes in /usr/share
     papers-47.0-3.fc42.x86_64.rpm:11120640
     See:
     https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: papers-47.0-3.fc42.x86_64.rpm
          papers-libs-47.0-3.fc42.x86_64.rpm
          papers-devel-47.0-3.fc42.x86_64.rpm
          papers-nautilus-47.0-3.fc42.x86_64.rpm
          papers-previewer-47.0-3.fc42.x86_64.rpm
          papers-thumbnailer-47.0-3.fc42.x86_64.rpm
          papers-debuginfo-47.0-3.fc42.x86_64.rpm
          papers-debugsource-47.0-3.fc42.x86_64.rpm
          papers-47.0-3.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpex3tkm7s')]
checks: 32, packages: 9

papers-devel.x86_64: W: no-documentation
papers-nautilus.x86_64: W: no-documentation
papers.x86_64: W: files-duplicate /usr/share/help/zh_TW/papers/legal-unported.xml /usr/share/help/bg/papers/legal-unported.xml:/usr/share/help/ca/papers/legal-unported.xml:/usr/share/help/cs/papers/legal-unported.xml:/usr/share/help/da/papers/legal-unported.xml:/usr/share/help/de/papers/legal-unported.xml:(and 22 more)
papers.x86_64: W: files-duplicate /usr/share/help/zh_TW/papers/legal.xml /usr/share/help/bg/papers/legal.xml:/usr/share/help/ca/papers/legal.xml:/usr/share/help/cs/papers/legal.xml:/usr/share/help/da/papers/legal.xml:/usr/share/help/de/papers/legal.xml:(and 22 more)
 9 packages and 0 specfiles checked; 0 errors, 4 warnings, 2016 filtered, 0 badness; has taken 3.5 s 




Rpmlint (debuginfo)
-------------------
Checking: papers-debuginfo-47.0-3.fc42.x86_64.rpm
          papers-libs-debuginfo-47.0-3.fc42.x86_64.rpm
          papers-nautilus-debuginfo-47.0-3.fc42.x86_64.rpm
          papers-previewer-debuginfo-47.0-3.fc42.x86_64.rpm
          papers-thumbnailer-debuginfo-47.0-3.fc42.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpcjjr5td6')]
checks: 32, packages: 5

 5 packages and 0 specfiles checked; 0 errors, 0 warnings, 47 filtered, 0 badness; has taken 1.3 s 





Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "papers-nautilus-debuginfo".
(none): E: there is no installed rpm "papers-thumbnailer-debuginfo".
(none): E: there is no installed rpm "papers-previewer-debuginfo".
(none): E: there is no installed rpm "papers-libs".
(none): E: there is no installed rpm "papers-thumbnailer".
(none): E: there is no installed rpm "papers-previewer".
(none): E: there is no installed rpm "papers-devel".
(none): E: there is no installed rpm "papers-debugsource".
(none): E: there is no installed rpm "papers-debuginfo".
(none): E: there is no installed rpm "papers-nautilus".
(none): E: there is no installed rpm "papers-libs-debuginfo".
(none): E: there is no installed rpm "papers".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 12

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 



Unversioned so-files
--------------------
papers-libs: /usr/lib64/papers/5/backends/libcomicsdocument.so
papers-libs: /usr/lib64/papers/5/backends/libdjvudocument.so
papers-libs: /usr/lib64/papers/5/backends/libpdfdocument.so
papers-libs: /usr/lib64/papers/5/backends/libtiffdocument.so
papers-libs: /usr/lib64/papers/5/backends/libxpsdocument.so
papers-nautilus: /usr/lib64/nautilus/extensions-4/libpapers-document-properties.so

Source checksums
----------------
https://download.gnome.org/sources/papers/47/papers-47.0.tar.xz :
  CHECKSUM(SHA256) this package     : cf69eb0a3717fe354011616e2f602383814ff57b7a9eacf306c676e64d8f6666
  CHECKSUM(SHA256) upstream package : cf69eb0a3717fe354011616e2f602383814ff57b7a9eacf306c676e64d8f6666


Requires
--------
papers (rpmlib, GLIBC filtered):
    hicolor-icon-theme
    libadwaita-1.so.0()(64bit)
    libadwaita-1.so.0(LIBADWAITA_1_0)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgcc_s.so.1(GCC_4.2.0)(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgraphene-1.0.so.0()(64bit)
    libgtk-4.so.1()(64bit)
    libpango-1.0.so.0()(64bit)
    libppsdocument-4.0.so.5()(64bit)
    libppsshell-4.0.so.4()(64bit)
    libppsview-4.0.so.4()(64bit)
    papers-libs(x86-64)
    papers-previewer(x86-64)
    papers-thumbnailer(x86-64)
    rtld(GNU_HASH)

papers-libs (rpmlib, GLIBC filtered):
    libadwaita-1.so.0()(64bit)
    libadwaita-1.so.0(LIBADWAITA_1_0)(64bit)
    libarchive.so.13()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libdjvulibre.so.21()(64bit)
    libexempi.so.8()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-4.so.1()(64bit)
    libgxps.so.2()(64bit)
    libm.so.6()(64bit)
    libpango-1.0.so.0()(64bit)
    libpoppler-glib.so.8()(64bit)
    libppsdocument-4.0.so.5()(64bit)
    libtiff.so.6()(64bit)
    libtiff.so.6(LIBTIFF_4.0)(64bit)
    rtld(GNU_HASH)

papers-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libppsdocument-4.0.so.5()(64bit)
    libppsview-4.0.so.4()(64bit)
    papers-libs(x86-64)
    pkgconfig(gio-2.0)
    pkgconfig(gthread-2.0)
    pkgconfig(gtk4)
    pkgconfig(libadwaita-1)
    pkgconfig(papers-document-4.0)

papers-nautilus (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libnautilus-extension.so.4()(64bit)
    libppsdocument-4.0.so.5()(64bit)
    nautilus(x86-64)
    papers-libs(x86-64)
    rtld(GNU_HASH)

papers-previewer (rpmlib, GLIBC filtered):
    libadwaita-1.so.0()(64bit)
    libadwaita-1.so.0(LIBADWAITA_1_0)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-4.so.1()(64bit)
    libppsdocument-4.0.so.5()(64bit)
    libppsview-4.0.so.4()(64bit)
    papers-libs(x86-64)
    rtld(GNU_HASH)

papers-thumbnailer (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libppsdocument-4.0.so.5()(64bit)
    papers-libs(x86-64)
    rtld(GNU_HASH)

papers-debuginfo (rpmlib, GLIBC filtered):

papers-debugsource (rpmlib, GLIBC filtered):



Provides
--------
papers:
    application()
    application(org.gnome.Papers.desktop)
    libppsshell-4.0.so.4()(64bit)
    metainfo()
    metainfo(org.gnome.Papers.metainfo.xml)
    mimehandler(application/oxps)
    mimehandler(application/pdf)
    mimehandler(application/vnd.comicbook+zip)
    mimehandler(application/vnd.comicbook-rar)
    mimehandler(application/vnd.ms-xpsdocument)
    mimehandler(application/x-bzpdf)
    mimehandler(application/x-cb7)
    mimehandler(application/x-cbr)
    mimehandler(application/x-cbt)
    mimehandler(application/x-cbz)
    mimehandler(application/x-ext-cb7)
    mimehandler(application/x-ext-cbr)
    mimehandler(application/x-ext-cbt)
    mimehandler(application/x-ext-cbz)
    mimehandler(application/x-ext-djv)
    mimehandler(application/x-ext-djvu)
    mimehandler(application/x-ext-pdf)
    mimehandler(application/x-gzpdf)
    mimehandler(application/x-xzpdf)
    mimehandler(image/tiff)
    mimehandler(image/vnd.djvu)
    papers
    papers(x86-64)

papers-libs:
    libppsdocument-4.0.so.5()(64bit)
    libppsview-4.0.so.4()(64bit)
    metainfo()
    metainfo(papers-comicsdocument.metainfo.xml)
    metainfo(papers-djvudocument.metainfo.xml)
    metainfo(papers-pdfdocument.metainfo.xml)
    metainfo(papers-tiffdocument.metainfo.xml)
    metainfo(papers-xpsdocument.metainfo.xml)
    papers-libs
    papers-libs(x86-64)

papers-devel:
    papers-devel
    papers-devel(x86-64)
    pkgconfig(papers-document-4.0)
    pkgconfig(papers-view-4.0)

papers-nautilus:
    libpapers-document-properties.so()(64bit)
    papers-nautilus
    papers-nautilus(x86-64)

papers-previewer:
    application()
    application(org.gnome.Papers-previewer.desktop)
    papers-previewer
    papers-previewer(x86-64)

papers-thumbnailer:
    papers-thumbnailer
    papers-thumbnailer(x86-64)

papers-debuginfo:
    debuginfo(build-id)
    libppsshell-4.0.so.4.0.0-47.0-3.fc42.x86_64.debug()(64bit)
    papers-debuginfo
    papers-debuginfo(x86-64)

papers-debugsource:
    papers-debugsource
    papers-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name papers --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: SugarActivity, Ocaml, fonts, R, Java, Haskell, Python, PHP, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH