This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-2.0-or-later AND NTP AND MIT and BSD-2-Clause AND BSD-3-Clause'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2 [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later", "*No copyright* GNU General Public License, Version 2", "*No copyright* GNU General Public License", "*No copyright* GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "NTP License (legal disclaimer)", "GNU Library General Public License v2 or later", "GNU General Public License v2.0 or later and/or NTP License", "ISC License", "MIT License", "BSD 3-Clause License", "BSD 2-Clause License". 380 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/fvwm3/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 82868 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: fvwm3-1.1.0-1.fc40.x86_64.rpm fvwm3-debuginfo-1.1.0-1.fc40.x86_64.rpm fvwm3-debugsource-1.1.0-1.fc40.x86_64.rpm fvwm3-1.1.0-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2cucrciy')] checks: 32, packages: 4 fvwm3.x86_64: W: no-manual-page-for-binary fvwm-convert-2.6 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 53 filtered, 0 badness; has taken 2.4 s Rpmlint (debuginfo) ------------------- Checking: fvwm3-debuginfo-1.1.0-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2q7otavw')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 40 filtered, 0 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "fvwm3-debugsource". (none): E: there is no installed rpm "fvwm3". (none): E: there is no installed rpm "fvwm3-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/fvwmorg/fvwm3/archive/1.1.0/fvwm3-1.1.0.tar.gz : CHECKSUM(SHA256) this package : c119fcc666d2cae281322aaf3578bfb9beed2d6d0383bd71073e29ea90a0f53b CHECKSUM(SHA256) upstream package : c119fcc666d2cae281322aaf3578bfb9beed2d6d0383bd71073e29ea90a0f53b Requires -------- fvwm3 (rpmlib, GLIBC filtered): /usr/bin/mimeopen /usr/bin/perl /usr/bin/python3 /usr/bin/sh libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXcursor.so.1()(64bit) libXext.so.6()(64bit) libXft.so.2()(64bit) libXpm.so.4()(64bit) libXrandr.so.2()(64bit) libXrender.so.1()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libevent-2.1.so.7()(64bit) libfontconfig.so.1()(64bit) libfribidi.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libreadline.so.8()(64bit) librsvg-2.so.2()(64bit) perl(:VERSION) perl(Config) perl(Cwd) perl(Exporter) perl(FVWM::Constants) perl(FVWM::Event) perl(FVWM::EventNames) perl(FVWM::Module) perl(FVWM::Module::Toolkit) perl(FVWM::Tracker) perl(File::Basename) perl(File::Copy) perl(General::FileSystem) perl(General::Parse) perl(Getopt::Long) perl(IO::File) perl(constant) perl(lib) perl(strict) perl(vars) python3-pyxdg rtld(GNU_HASH) xlockmore xterm fvwm3-debuginfo (rpmlib, GLIBC filtered): fvwm3-debugsource (rpmlib, GLIBC filtered): Provides -------- fvwm3: fvwm3 fvwm3(x86-64) perl(FVWM::Commands) perl(FVWM::Constants) perl(FVWM::Event) perl(FVWM::EventNames) perl(FVWM::Module) perl(FVWM::Module::Terminal) perl(FVWM::Module::Toolkit) perl(FVWM::Tracker) perl(FVWM::Tracker::Colorsets) perl(FVWM::Tracker::GlobalConfig) perl(FVWM::Tracker::ModuleConfig) perl(FVWM::Tracker::PageInfo) perl(FVWM::Tracker::Scheduler) perl(FVWM::Tracker::WindowList) perl(FVWM::Window) perl(General::FileSystem) perl(General::Parse) fvwm3-debuginfo: debuginfo(build-id) fvwm3-debuginfo fvwm3-debuginfo(x86-64) fvwm3-debugsource: fvwm3-debugsource fvwm3-debugsource(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AM_CONFIG_HEADER found in: /var/lib/copr-rpmbuild/results/fvwm3/upstream- unpacked/Source0/fvwm3-1.1.0/configure.ac:22 Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name fvwm3 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-40-x86_64 Active plugins: Shell-api, Perl, Generic, C/C++ Disabled plugins: Python, R, Java, fonts, PHP, SugarActivity, Ocaml, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH