This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file JKQTMathText6_FIRAMATH_LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "GNU Lesser General Public License v3.0 or later", "SIL Open Font License 1.1", "GNU General Public License", "SIL Open Font License", "*No copyright* SIL Open Font License 1.1 with Reserved Font Name", "*No copyright* SIL Open Font License". 2859 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/JKQtPlotter/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 12264 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: JKQtPlotter-5.0.0~20251013.050100.d243218-1.fc43.x86_64.rpm JKQtPlotter-devel-5.0.0~20251013.050100.d243218-1.fc43.x86_64.rpm JKQtPlotter-doc-5.0.0~20251013.050100.d243218-1.fc43.x86_64.rpm JKQtPlotter-5.0.0~20251013.050100.d243218-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2az4ksd0')] checks: 32, packages: 4 JKQtPlotter.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/JKQtPlotter/README.md JKQtPlotter.src: E: spelling-error ('renderer', '%description -l en_US renderer -> tenderer, rendered, render') JKQtPlotter.x86_64: E: spelling-error ('renderer', '%description -l en_US renderer -> tenderer, rendered, render') JKQtPlotter.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPCSSParser_test JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPDataCache_benchmark JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPDataCache_test JKQtPlotter.x86_64: W: no-manual-page-for-binary JKQTPStringTools_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtmathtext_render JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtplot_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtplotter_doc_imagegenerator JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtpstatisticstools_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_advplotstyling JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_customdrawfunctor JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_errorbars JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_functorfill JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_barchart_twocolor JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_boxplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_contourplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_groupedstat JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_iterators JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_regression JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_statistics JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_datastore_statistics_2d JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_dateaxes JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_distributionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_errorbarstyles JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_evalcurve JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_filledgraphs JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_filledgraphs_errors JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_financialgraphs JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_functionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_arrows JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_bezier JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_coordinateaxis0 JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geo_simple JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_geometric JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_graphlabels JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_cimg JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_modifier JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_nodatastore JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_opencv JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_imageplot_userpal JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_impulsesplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtfastplotter_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtmathtext_simpletest JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_jkqtmathtext_test JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_logaxes JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_mandelbrot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_multiplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_multithreaded JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_parametriccurve JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot_customsymbol JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramscatterplot_image JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_paramvectorfield JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_parsedfunctionplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_cimg JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_opencv JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_rgbimageplot_qt JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_scatter JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_scatter_customsymbol JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_second_axis JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_simpletest JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_speed JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_stackedbars JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_stepplots JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_styledboxplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_styling JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_symbols_and_errors JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_symbols_and_styles JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_ui JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_ui_bind_scrollbar JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_user_interaction JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_vectorfield JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_violinplot JKQtPlotter.x86_64: W: no-manual-page-for-binary jkqtptest_wiggleplots JKQtPlotter.x86_64: W: no-manual-page-for-binary test_jkqtpdatastore JKQtPlotter-devel.x86_64: W: no-documentation JKQtPlotter-doc.x86_64: E: no-binary JKQtPlotter.spec: W: no-%check-section JKQtPlotter.x86_64: E: incorrect-fsf-address /usr/share/licenses/JKQtPlotter/LICENSE JKQtPlotter-doc.x86_64: E: incorrect-fsf-address /usr/share/doc/JKQTPlotter/LICENSE JKQtPlotter-devel.x86_64: W: files-duplicate /usr/lib64/cmake/JKQTPlotter6/JKQTPlotter6Version.cmake /usr/lib64/cmake/JKQTPlotter6/JKQTCommon6Version.cmake:/usr/lib64/cmake/JKQTPlotter6/JKQTFastPlotter6Version.cmake:/usr/lib64/cmake/JKQTPlotter6/JKQTMath6Version.cmake:/usr/lib64/cmake/JKQTPlotter6/JKQTMathText6Version.cmake JKQtPlotter-doc.x86_64: W: files-duplicate /usr/share/licenses/JKQtPlotter-doc/LICENSE /usr/share/doc/JKQTPlotter/JKQTMathText6_FIRAMATH_LICENSE 4 packages and 0 specfiles checked; 5 errors, 84 warnings, 124 filtered, 5 badness; has taken 4.7 s Rpmlint (debuginfo) ------------------- Checking: JKQtPlotter-debuginfo-5.0.0~20251013.050100.d243218-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8trzilla')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 174 filtered, 0 badness; has taken 5.9 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "JKQtPlotter-debuginfo". (none): E: there is no installed rpm "JKQtPlotter". (none): E: there is no installed rpm "JKQtPlotter-doc". (none): E: there is no installed rpm "JKQtPlotter-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/jkriege2/JKQtPlotter/archive/d243218119b1632987df26baea0d4bc6ccdee533.tar.gz : CHECKSUM(SHA256) this package : 1a5cd3e84493f969bfaea5e761e28b128b978cb8a18df8c83240f39922e82825 CHECKSUM(SHA256) upstream package : 1a5cd3e84493f969bfaea5e761e28b128b978cb8a18df8c83240f39922e82825 Requires -------- JKQtPlotter (rpmlib, GLIBC filtered): libJKQTCommon6_Debug.so.5.0.0()(64bit) libJKQTFastPlotter6_Debug.so.5.0.0()(64bit) libJKQTMath6_Debug.so.5.0.0()(64bit) libJKQTMathText6_Debug.so.5.0.0()(64bit) libJKQTPlotter6_Debug.so.5.0.0()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.10)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6OpenGLWidgets.so.6()(64bit) libQt6OpenGLWidgets.so.6(Qt_6)(64bit) libQt6PrintSupport.so.6()(64bit) libQt6PrintSupport.so.6(Qt_6)(64bit) libQt6Svg.so.6()(64bit) libQt6Svg.so.6(Qt_6)(64bit) libQt6Test.so.6()(64bit) libQt6Test.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libQt6Xml.so.6()(64bit) libQt6Xml.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libopencv_core.so.411()(64bit) libopencv_imgcodecs.so.411()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) JKQtPlotter-devel (rpmlib, GLIBC filtered): JKQtPlotter(x86-64) cmake-filesystem(x86-64) libJKQTCommon6_Debug.so.5.0.0()(64bit) libJKQTFastPlotter6_Debug.so.5.0.0()(64bit) libJKQTMath6_Debug.so.5.0.0()(64bit) libJKQTMathText6_Debug.so.5.0.0()(64bit) libJKQTPlotter6_Debug.so.5.0.0()(64bit) JKQtPlotter-doc (rpmlib, GLIBC filtered): Provides -------- JKQtPlotter: JKQtPlotter JKQtPlotter(x86-64) libJKQTCommon6_Debug.so.5.0.0()(64bit) libJKQTFastPlotter6_Debug.so.5.0.0()(64bit) libJKQTMath6_Debug.so.5.0.0()(64bit) libJKQTMathText6_Debug.so.5.0.0()(64bit) libJKQTPlotter6_Debug.so.5.0.0()(64bit) JKQtPlotter-devel: JKQtPlotter-devel JKQtPlotter-devel(x86-64) cmake(JKQTCommon6) cmake(JKQTFastPlotter6) cmake(JKQTMath6) cmake(JKQTMathText6) cmake(JKQTPlotter6) cmake(jkqtcommon6) cmake(jkqtfastplotter6) cmake(jkqtmath6) cmake(jkqtmathtext6) cmake(jkqtplotter6) JKQtPlotter-doc: JKQtPlotter-doc JKQtPlotter-doc(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name JKQtPlotter --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-43-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: SugarActivity, R, Java, Perl, Ocaml, PHP, Python, fonts, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH