This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 2-Clause License", "*No copyright* Creative Commons CC0 1.0", "GNU Free Documentation License v1.3", "LaTeX Project Public License 1.3c", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 3", "GNU Lesser General Public License, Version 2.1", "LaTeX Project Public License 1.1", "LaTeX Project Public License 1.2", "LaTeX Project Public License 1", "SIL Open Font License 1.1". 11 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/texlive-collection-binextra/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/texlive/texmf-dist/doc/support [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/texlive/texmf- dist/doc/support [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: texlive-hook-pre-commit-pkg (description), texlive- runtexfile (description) [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in texlive- ctan_chk , texlive-hook-pre-commit-pkg , texlive-runtexfile , texlive- show-pdf-tags [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: texlive-collection-binextra-svn75830-3.fc44.noarch.rpm texlive-ctan_chk-svn36304-3.fc44.noarch.rpm texlive-hook-pre-commit-pkg-svn76790-3.fc44.noarch.rpm texlive-runtexfile-svn76526-3.fc44.noarch.rpm texlive-show-pdf-tags-svn76606-3.fc44.noarch.rpm texlive-collection-binextra-svn75830-3.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7werbyww')] checks: 32, packages: 6 texlive-runtexfile.noarch: E: summary-too-long Automate the process of compiling (La)TeX documents with index, bibliography, ... texlive-runtexfile.noarch: W: summary-ended-with-dot Automate the process of compiling (La)TeX documents with index, bibliography, ... texlive-collection-binextra.noarch: E: spelling-error ('patgen', '%description -l en_US patgen -> pat gen, pat-gen, pathogen') texlive-collection-binextra.src: E: spelling-error ('patgen', '%description -l en_US patgen -> pat gen, pat-gen, pathogen') texlive-ctan_chk.noarch: E: spelling-error ('verifier', 'Summary(en_US) verifier -> versifier, verifies, verified') texlive-hook-pre-commit-pkg.noarch: E: spelling-error ('dtx', '%description -l en_US dtx -> DDT') texlive-hook-pre-commit-pkg.noarch: E: spelling-error ('bbx', '%description -l en_US bbx -> bx, box, bbl') texlive-hook-pre-commit-pkg.noarch: E: spelling-error ('cbx', '%description -l en_US cbx -> bx, cox, c bx') texlive-hook-pre-commit-pkg.noarch: E: spelling-error ('lbx', '%description -l en_US lbx -> lb, bx, lbs') texlive-hook-pre-commit-pkg.noarch: E: spelling-error ('macrocode', '%description -l en_US macrocode -> microcode, macro code, macro-code') texlive-runtexfile.noarch: E: spelling-error ('latexmk', '%description -l en_US latexmk -> latex') texlive-runtexfile.noarch: E: spelling-error ('lualatex', '%description -l en_US lualatex -> latex, textual') texlive-runtexfile.noarch: E: spelling-error ('biber', '%description -l en_US biber -> bier, briber, bribe') texlive-runtexfile.noarch: E: spelling-error ('xindex', '%description -l en_US xindex -> index, Windex, x index') texlive-runtexfile.noarch: E: spelling-error ('vwd', '%description -l en_US vwd -> fwd, FWD') texlive-runtexfile.noarch: E: spelling-error ('dbd', '%description -l en_US dbd -> db, dd, did') texlive-runtexfile.noarch: E: spelling-error ('documentclass', '%description -l en_US documentclass -> document class, document-class, documentations') texlive-show-pdf-tags.noarch: E: spelling-error ('schemas', '%description -l en_US schemas -> schema, sachems, schemes') texlive-ctan_chk.noarch: W: package-with-huge-docs 87% texlive-runtexfile.noarch: W: package-with-huge-docs 97% texlive-show-pdf-tags.noarch: W: package-with-huge-docs 86% texlive-collection-binextra.noarch: W: no-documentation texlive-collection-binextra.spec: W: no-%check-section texlive-collection-binextra.spec: W: invalid-url Source1: texlive-licenses.tar.xz 6 packages and 0 specfiles checked; 17 errors, 7 warnings, 21 filtered, 17 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "texlive-show-pdf-tags". (none): E: there is no installed rpm "texlive-hook-pre-commit-pkg". (none): E: there is no installed rpm "texlive-runtexfile". (none): E: there is no installed rpm "texlive-ctan_chk". (none): E: there is no installed rpm "texlive-collection-binextra". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://ctan.math.illinois.edu/systems/texlive/tlnet/archive/show-pdf-tags.doc.tar.xz : CHECKSUM(SHA256) this package : 8e35f62a440a2b82bfc7247d18ef3d8933e9e43cd1d7a07c860d7d230c3fd0a7 CHECKSUM(SHA256) upstream package : 8e35f62a440a2b82bfc7247d18ef3d8933e9e43cd1d7a07c860d7d230c3fd0a7 https://ctan.math.illinois.edu/systems/texlive/tlnet/archive/show-pdf-tags.tar.xz : CHECKSUM(SHA256) this package : c5c8af40f45c138e06b108532bd81081fb7cb3d2f4fe3799eba2e11035d7aece CHECKSUM(SHA256) upstream package : c5c8af40f45c138e06b108532bd81081fb7cb3d2f4fe3799eba2e11035d7aece https://ctan.math.illinois.edu/systems/texlive/tlnet/archive/runtexfile.doc.tar.xz : CHECKSUM(SHA256) this package : b830896bf7238b0783149093c0e303875280c3e2d54b97ff803f9c12a51dd529 CHECKSUM(SHA256) upstream package : b830896bf7238b0783149093c0e303875280c3e2d54b97ff803f9c12a51dd529 https://ctan.math.illinois.edu/systems/texlive/tlnet/archive/runtexfile.tar.xz : CHECKSUM(SHA256) this package : 8a98226a8f51f42aef8f02d22d3be75b716e2d8ffdcc5fb080e8ff9da3699f76 CHECKSUM(SHA256) upstream package : 8a98226a8f51f42aef8f02d22d3be75b716e2d8ffdcc5fb080e8ff9da3699f76 https://ctan.math.illinois.edu/systems/texlive/tlnet/archive/hook-pre-commit-pkg.doc.tar.xz : CHECKSUM(SHA256) this package : cbcadbb751fee8e3f639a5368b5840d86b36685e88b6809b2430ed915d3b5408 CHECKSUM(SHA256) upstream package : cbcadbb751fee8e3f639a5368b5840d86b36685e88b6809b2430ed915d3b5408 https://ctan.math.illinois.edu/systems/texlive/tlnet/archive/hook-pre-commit-pkg.tar.xz : CHECKSUM(SHA256) this package : 7b23439e6eb80339fa057da2bb347e728bc4ea7cca5fe770fe37a0ae3a73b51f CHECKSUM(SHA256) upstream package : 7b23439e6eb80339fa057da2bb347e728bc4ea7cca5fe770fe37a0ae3a73b51f https://ctan.math.illinois.edu/systems/texlive/tlnet/archive/ctan_chk.doc.tar.xz : CHECKSUM(SHA256) this package : 61139d9c8eb1e7bd7abcf68d0046e466794fa8264db918aafcd251b04505ca15 CHECKSUM(SHA256) upstream package : 61139d9c8eb1e7bd7abcf68d0046e466794fa8264db918aafcd251b04505ca15 https://ctan.math.illinois.edu/systems/texlive/tlnet/archive/ctan_chk.tar.xz : CHECKSUM(SHA256) this package : 3b267df17594e5c26f2a9a75051f1cf235e39dc848837bee302f930304b73954 CHECKSUM(SHA256) upstream package : 3b267df17594e5c26f2a9a75051f1cf235e39dc848837bee302f930304b73954 https://ctan.math.illinois.edu/systems/texlive/tlnet/archive/collection-binextra.tar.xz : CHECKSUM(SHA256) this package : b7667b88e18441493d0880aed243da96a1363bc4deca37f6331ef8c64b13be1e CHECKSUM(SHA256) upstream package : b7667b88e18441493d0880aed243da96a1363bc4deca37f6331ef8c64b13be1e Requires -------- texlive-collection-binextra (rpmlib, GLIBC filtered): asymptote latexmk texlive-a2ping texlive-adhocfilelist texlive-arara texlive-base texlive-bibtex8 texlive-bibtexu texlive-bundledoc texlive-checklistings texlive-chklref texlive-chktex texlive-clojure-pamphlet texlive-cluttex texlive-collection-basic texlive-ctan-o-mat texlive-ctan_chk texlive-ctanbib texlive-ctanify texlive-ctanupload texlive-ctie texlive-cweb texlive-de-macro texlive-detex texlive-digestif texlive-dtl texlive-dtxgen texlive-dvi2tty texlive-dviasm texlive-dvicopy texlive-dvidvi texlive-dviinfox texlive-dviljk texlive-dviout-util texlive-dvipng texlive-dvipos texlive-dvisvgm texlive-easydtx texlive-expltools texlive-findhyph texlive-fragmaster texlive-git-latexdiff texlive-gsftopk texlive-hook-pre-commit-pkg texlive-installfont texlive-ketcindy texlive-l3sys-query texlive-lacheck texlive-latex-git-log texlive-latex-papersize texlive-latex2man texlive-latex2nemeth texlive-latexdiff texlive-latexfileversion texlive-latexindent texlive-latexpand texlive-light-latex-make texlive-listings-ext texlive-ltxfileinfo texlive-ltximg texlive-make4ht texlive-match_parens texlive-mflua texlive-mkjobtexmf texlive-optexcount texlive-patgen texlive-pdfbook2 texlive-pdfcrop texlive-pdfjam texlive-pdflatexpicscale texlive-pdftex-quiet texlive-pdftosrc texlive-pdfxup texlive-pfarrei texlive-pkfix texlive-pkfix-helper texlive-ppmcheckpdf texlive-purifyeps texlive-pythontex texlive-runtexfile texlive-runtexshebang texlive-seetexk texlive-show-pdf-tags texlive-spix texlive-sqltex texlive-srcredact texlive-sty2dtx texlive-synctex texlive-tex4ebook texlive-texaccents texlive-texblend texlive-texcount texlive-texdef texlive-texdiff texlive-texdirflatten texlive-texdoc texlive-texdoctk texlive-texfot texlive-texlive-scripts-extra texlive-texliveonfly texlive-texloganalyser texlive-texlogfilter texlive-texlogsieve texlive-texosquery texlive-texplate texlive-texware texlive-tie texlive-tpic2pdftex texlive-typeoutfileinfo texlive-upmendex texlive-web texlive-xindex texlive-xindy texlive-xpdfopen texlive-ctan_chk (rpmlib, GLIBC filtered): texlive-base texlive-kpathsea texlive-hook-pre-commit-pkg (rpmlib, GLIBC filtered): texlive-base texlive-kpathsea texlive-runtexfile (rpmlib, GLIBC filtered): /usr/bin/texlua texlive-base texlive-kpathsea texlive-runtexfile texlive-show-pdf-tags (rpmlib, GLIBC filtered): texlive-base texlive-kpathsea texlive-show-pdf-tags Provides -------- texlive-collection-binextra: texlive-collection-binextra texlive-ctan_chk: texlive-ctan_chk texlive-ctan_chk-doc texlive-hook-pre-commit-pkg: texlive-hook-pre-commit-pkg texlive-hook-pre-commit-pkg-doc texlive-runtexfile: texlive-runtexfile texlive-show-pdf-tags: texlive-show-pdf-tags Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name texlive-collection-binextra --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, fonts, C/C++, Java, Haskell, PHP, Python, SugarActivity, Ocaml, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH