This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Dist tag is present. - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/microshift/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "Apache License 2.0", "BSD 3-Clause License", "MIT License", "*No copyright* MIT License", "BSD 2-Clause License", "MIT License Apache License 2.0", "MIT License BSD 3-Clause License", "*No copyright* [generated file]", "ISC License", "Creative Commons Attribution 4.0 Apache License 2.0", "*No copyright* Creative Commons CC0 1.0", "*No copyright* Mozilla Public License 2.0", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 3", "*No copyright* BSD 2-Clause License", "MIT License BSD 2-Clause License", "Creative Commons CC0 1.0", "OpenSSL License", "Apache License 2.0 [generated file]", "*No copyright* Public domain", "*No copyright* GNU Lesser General Public License, Version 3". 6469 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/microshift/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /var/lib/selinux/targeted/active/modules/200, /usr/share/selinux/packages/targeted, /var/run/secrets, /etc/crio/crio.conf.d, /var/run/secrets/kubernetes.io [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/selinux/packages/targeted, /var/lib/selinux/targeted/active/modules/200, /var/run/secrets, /etc/crio/crio.conf.d, /var/run/secrets/kubernetes.io, /var/lib/kubelet [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in microshift [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make %{?_smp_mflags} macro. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in microshift-selinux [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define selinux_policyver 3.14.3-67, %define container_policyver 2.167.0-1, %define container_policy_epoch 2, %define microshift_relabel_files() mkdir -p /var/hpvolumes; mkdir -p /var/run/flannel; mkdir -p /var/run/kubelet; mkdir -p /var/lib/kubelet/pods; mkdir -p /var/run/secrets/kubernetes.io/serviceaccount; restorecon -R /var/hpvolumes; restorecon -R /var/run/kubelet; restorecon -R /var/run/flannel; restorecon -R /var/lib/kubelet/pods; restorecon -R /var/run/secrets/kubernetes.io/serviceaccount [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 3.0 starting (python version = 3.10.2, NVR = mock-3.0-1.fc35)... Start(bootstrap): init plugins INFO: tmpfs initialized INFO: selinux enabled INFO: chroot_scan: initialized INFO: compress_logs: initialized Finish(bootstrap): init plugins Start: init plugins INFO: tmpfs initialized INFO: selinux enabled INFO: chroot_scan: initialized INFO: compress_logs: initialized Finish: init plugins INFO: Signal handler active Start: run Start(bootstrap): chroot init INFO: mounting tmpfs at /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root. INFO: reusing tmpfs at /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root. INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 3.0 INFO: Mock Version: 3.0 Finish(bootstrap): chroot init Start: chroot init INFO: mounting tmpfs at /var/lib/mock/fedora-rawhide-x86_64/root. INFO: reusing tmpfs at /var/lib/mock/fedora-rawhide-x86_64/root. INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 3.0 INFO: Mock Version: 3.0 Finish: chroot init INFO: installing package(s): /builddir/microshift-4.8.0-2022_04_20_141053.fc37.x86_64.rpm /builddir/microshift-selinux-4.8.0-2022_04_20_141053.fc37.noarch.rpm WARNING: Dnf command failed, retrying, attempt #2, sleeping 10s WARNING: Dnf command failed, retrying, attempt #3, sleeping 10s ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M ce9f681ed8ae451784e0e5cbf09bfd14 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --rlimit=RLIMIT_NOFILE=10240 --capability=cap_ipc_lock --bind=/tmp/mock-resolv.fdeplrwa:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;\007" --setenv=PS1= \s-\v\$ --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --setenv=SYSTEMD_NSPAWN_TMPFS_TMP=0 --setenv=SYSTEMD_SECCOMP=0 --resolv-conf=off /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 37 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /builddir/microshift-4.8.0-2022_04_20_141053.fc37.x86_64.rpm /builddir/microshift-selinux-4.8.0-2022_04_20_141053.fc37.noarch.rpm --setopt=tsflags=nocontexts --setopt=tsflags=nocontexts --setopt=tsflags=nocontexts Rpmlint ------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/redhat-et/microshift/archive/48863ff4cf9146906a7d7879c2ca93265c7ad662/microshift-48863ff.tar.gz : CHECKSUM(SHA256) this package : e77201d3204d8464a0489ec991bdccb31dc7b25342aa27057a686b0b172314ac CHECKSUM(SHA256) upstream package : 58be07958efb379360360c7c252284eb5a91992d341ab399ed7897f0e16efe39 diff -r also reports differences Requires -------- microshift (rpmlib, GLIBC filtered): /bin/sh conntrack-tools cri-o cri-tools iptables libc.so.6()(64bit) microshift-selinux rtld(GNU_HASH) systemd microshift-selinux (rpmlib, GLIBC filtered): /bin/sh container-selinux libselinux-utils policycoreutils policycoreutils-python-utils selinux-policy selinux-policy-base Provides -------- microshift: microshift microshift(x86-64) microshift-selinux: microshift-selinux Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name microshift --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: PHP, SugarActivity, Perl, fonts, R, Haskell, Ocaml, Python, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH