This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-2.0-or-later AND LicenseRef- Callaway-BSD AND LGPL-2.1-or-later AND LGPL-2.0-or-later'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/uboot-tools See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 2", "GNU General Public License, Version 2", "SIL Open Font License 1.1", "*No copyright* BSD 2-Clause License", "*No copyright* BSD 3-Clause License", "GNU General Public License and/or eCos license version 2.0", "IBM PowerPC Initialization and Boot Software", "ISC License", "GNU Library General Public License, Version 2.0", "GNU Lesser General Public License, Version 2.1", "MIT License", "X11 License", "BSD 2-Clause License", "GNU General Public License v2.0 or later", "BSD 3-Clause License", "GNU General Public License v2.0 only and/or GNU General Public License v2.0 or later", "GNU General Public License, Version 2 and/or Public domain", "GNU General Public License v2.0 or later and/or Public domain", "*No copyright* GNU General Public License, Version 2 and/or Public domain", "*No copyright* Public domain", "GNU General Public License, Version 2 and/or GNU Library General Public License v2 or later", "*No copyright* eCos license version 2.0", "Intel Open Source License", "*No copyright* Unicode License Agreement - Data Files and Software (2016)", "GNU General Public License, Version 2 [obsolete FSF postal address (Mass Ave)]", "GNU General Public License, Version 2 [generated file]", "GNU General Public License", "Beerware License", "GNU General Public License, Version 2 [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU General Public License, Version 2 [obsolete FSF postal address (Mass Ave)]", "BSD 2-Clause License and/or GNU General Public License, Version 2", "*No copyright* GNU Lesser General Public License, Version 2.1", "*No copyright* GNU General Public License", "Historical Permission Notice and Disclaimer - sell variant", "GNU General Public License, Version 2 and/or eCos license version 2.0", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "MIT License and/or The Unlicense", "*No copyright* GNU General Public License v2.0 or later", "*No copyright* GNU General Public License v2.0 only", "GNU General Public License v2.0 or later and/or eCos license version 2.0 [obsolete FSF postal address (Temple Place)]", "GNU General Public License, Version 2 and/or Red Hat eCos Public License v1.1", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "Creative Commons CC0 1.0", "zlib License", "bzip2 and libbzip2 License v1.0.6", "*No copyright* Creative Commons CC0 1.0", "GNU General Public License, Version 2 and/or RealNetworks Public Source License", "Creative Commons Attribution-ShareAlike 4.0", "GNU General Public License, Version 2 and/or MIT License", "GNU General Public License v2.0 or later and/or MIT License", "GNU General Public License v2.0 only", "*No copyright* GNU General Public License, Version 2 [generated file]", "BSD 2-Clause Plus Patent License", "BSD 3-Clause License and/or GNU General Public License, Version 2", "Creative Commons Attribution 4.0", "*No copyright* GNU General Public License, Version 3 and/or SIL Open Font License", "GNU General Public License, Version 1", "*No copyright* MIT License", "Apache License 2.0", "*No copyright* Apache License 2.0", "*No copyright* GNU General Public License, Version 2 and/or MIT License", "*No copyright* GNU General Public License v2.0 or later and/or MIT License", "Intel Open Source License [generated file]", "*No copyright* ISC License", "Apache License 1.0 and/or BSD 3-Clause License", "Apache License 1.0", "BSD 2-clause NetBSD License and/or BSD 4-Clause License", "Apache License 2.0 [generated file]", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]". 14319 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/uboot-tools/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 749711 bytes in 166 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file Note: Found : Vendor: Gravity Linux See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_tags_and_sections [!]: Uses parallel make %{?_smp_mflags} macro. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in uboot- images-armv8 [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1024000 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: uboot-tools-2026.07-200.gravity.fc44.aarch64.rpm uboot-images-armv8-2026.07-200.gravity.fc44.noarch.rpm uboot-tools-2026.07-200.gravity.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqpt4720f')] checks: 32, packages: 3 uboot-tools.aarch64: E: spelling-error ('fw', '%description -l en_US fw -> f, w, few') uboot-tools.aarch64: E: spelling-error ('printenv', '%description -l en_US printenv -> printer') uboot-tools.aarch64: E: spelling-error ('setenv', '%description -l en_US setenv -> seventeen') uboot-tools.src: E: spelling-error ('mkimage', '%description -l en_US mkimage -> image') uboot-tools.src: E: spelling-error ('fw', '%description -l en_US fw -> f, w, few') uboot-tools.src: E: spelling-error ('printenv', '%description -l en_US printenv -> printer') uboot-tools.src: E: spelling-error ('setenv', '%description -l en_US setenv -> seventeen') uboot-tools.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory uboot-tools.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory uboot-tools.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory uboot-tools.spec:362: W: shared-dir-glob-in-files %{_bindir}/* uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/dumpimage uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/fdt_add_pubkey uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/fit_check_sign uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/fit_info uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/fw_printenv uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/gdbcont uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/gdbsend uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/gen_eth_addr uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/gen_ethaddr_crc uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/ifwitool uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/img2srec uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/kwboot uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/mkeficapsule uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/mkenvimage uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/mkimage uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/mksunxiboot uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/ncb uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/proftool uboot-tools.aarch64: W: position-independent-executable-suggested /usr/bin/sunxi-spl-image-builder uboot-tools.aarch64: W: no-manual-page-for-binary fdt_add_pubkey uboot-tools.aarch64: W: no-manual-page-for-binary fit_check_sign uboot-tools.aarch64: W: no-manual-page-for-binary fit_info uboot-tools.aarch64: W: no-manual-page-for-binary fw_printenv uboot-tools.aarch64: W: no-manual-page-for-binary fw_setenv uboot-tools.aarch64: W: no-manual-page-for-binary gdbcont uboot-tools.aarch64: W: no-manual-page-for-binary gdbsend uboot-tools.aarch64: W: no-manual-page-for-binary gen_eth_addr uboot-tools.aarch64: W: no-manual-page-for-binary gen_ethaddr_crc uboot-tools.aarch64: W: no-manual-page-for-binary ifwitool uboot-tools.aarch64: W: no-manual-page-for-binary img2srec uboot-tools.aarch64: W: no-manual-page-for-binary mkenvimage uboot-tools.aarch64: W: no-manual-page-for-binary mksunxiboot uboot-tools.aarch64: W: no-manual-page-for-binary ncb uboot-tools.aarch64: W: no-manual-page-for-binary proftool uboot-tools.aarch64: W: no-manual-page-for-binary sunxi-spl-image-builder uboot-images-armv8.noarch: W: no-documentation uboot-tools.spec: W: no-%check-section uboot-images-armv8.noarch: W: invalid-license LicenseRef-Callaway-BSD uboot-tools.aarch64: W: invalid-license LicenseRef-Callaway-BSD uboot-tools.src: W: invalid-license LicenseRef-Callaway-BSD uboot-images-armv8.noarch: E: incorrect-fsf-address /usr/share/licenses/uboot-images-armv8/eCos-2.0.txt uboot-images-armv8.noarch: E: incorrect-fsf-address /usr/share/licenses/uboot-images-armv8/gpl-2.0.txt uboot-images-armv8.noarch: E: incorrect-fsf-address /usr/share/licenses/uboot-images-armv8/lgpl-2.0.txt uboot-images-armv8.noarch: E: incorrect-fsf-address /usr/share/licenses/uboot-images-armv8/lgpl-2.1.txt uboot-tools.aarch64: E: incorrect-fsf-address /usr/share/licenses/uboot-tools/eCos-2.0.txt uboot-tools.aarch64: E: incorrect-fsf-address /usr/share/licenses/uboot-tools/gpl-2.0.txt uboot-tools.aarch64: E: incorrect-fsf-address /usr/share/licenses/uboot-tools/lgpl-2.0.txt uboot-tools.aarch64: E: incorrect-fsf-address /usr/share/licenses/uboot-tools/lgpl-2.1.txt uboot-tools.aarch64: W: incoherent-version-in-changelog 1:2026.07-101 ['1:2026.07-200.gravity.fc44', '1:2026.07-200.gravity'] 3 packages and 0 specfiles checked; 15 errors, 45 warnings, 10 filtered, 15 badness; has taken 6.9 s Rpmlint (debuginfo) ------------------- Checking: uboot-tools-debuginfo-2026.07-200.gravity.fc44.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpkm8u7tqc')] checks: 32, packages: 1 uboot-tools-debuginfo.aarch64: W: invalid-license LicenseRef-Callaway-BSD 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 79 filtered, 0 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "uboot-tools". (none): E: there is no installed rpm "uboot-tools-debuginfo". (none): E: there is no installed rpm "uboot-images-armv8". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://ftp.denx.de/pub/u-boot/u-boot-2026.07.tar.bz2 : CHECKSUM(SHA256) this package : 78e8bfc382fe388f9b55aa1daf8c563522a037779b5d4c349d1415e381f1243e CHECKSUM(SHA256) upstream package : 78e8bfc382fe388f9b55aa1daf8c563522a037779b5d4c349d1415e381f1243e Requires -------- uboot-tools (rpmlib, GLIBC filtered): dtc ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgnutls.so.30()(64bit) libgnutls.so.30(GNUTLS_3_4)(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libtinfo.so.6()(64bit) rtld(GNU_HASH) uboot-images-armv8 (rpmlib, GLIBC filtered): Provides -------- uboot-tools: uboot-tools uboot-tools(aarch-64) uboot-images-armv8: uboot-images-armv8 Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name uboot-tools --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-44-aarch64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, PHP, Perl, fonts, SugarActivity, Haskell, Ocaml, Python, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH