This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "MIT License", "GNU General Public License v2.0 only and/or SIL Open Font License 1.1 with Reserved Font Name", "*No copyright* MIT License", "BSD 2-Clause License", "BSD 3-Clause License", "BSD 3-Clause License and/or GNU General Public License, Version 2", "*No copyright* Creative Commons CC0 1.0", "SIL Open Font License 1.1", "zlib License", "*No copyright* GNU General Public License, Version 2", "*No copyright* Public domain", "FSF All Permissive License". 125 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/gravity-bootloader/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 12711 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file Note: Found : Vendor: Gravity Linux See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_tags_and_sections [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gravity- bootloader-stage1 [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: gravity-bootloader-1.6.1-105.gravity.fc44.noarch.rpm gravity-bootloader-stage1-1.6.1-105.gravity.fc44.noarch.rpm gravity-bootloader-tools-1.6.1-105.gravity.fc44.noarch.rpm gravity-bootloader-1.6.1-105.gravity.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_823_tkg')] checks: 32, packages: 4 gravity-bootloader.spec:90: W: unversioned-explicit-provides bundled(crate(fatfs))= gravity-bootloader.spec:90: W: unversioned-explicit-provides 0.4.0 gravity-bootloader.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory gravity-bootloader.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory gravity-bootloader.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory gravity-bootloader.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory gravity-bootloader.noarch: W: only-non-binary-in-usr-lib gravity-bootloader-stage1.noarch: W: only-non-binary-in-usr-lib gravity-bootloader-tools.noarch: W: only-non-binary-in-usr-lib gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/agx_1tri.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/agx_cancel.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/agx_deps.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/agx_dumpstructs.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/agx_parallel.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/agx_renderframe.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/agx_tlb.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/agx_tracetimings.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/agx_xtest.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/amcc_err_handler.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/dcpext_iboot.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/dmp.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/jpeg.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/lap.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/mtp.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/pmp_init.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/prores.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/experiments/scaler.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/hv/trace_isp.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/m1n1/agx/render.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/m1n1/agx/shim.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/m1n1/agx/uapi.py 644 /usr/bin/env python3 gravity-bootloader-tools.noarch: E: non-executable-script /usr/libexec/m1n1/proxyclient/m1n1/constructutils.py 644 /usr/bin/env python3 gravity-bootloader.noarch: E: noarch-with-lib64 gravity-bootloader-stage1.noarch: E: noarch-with-lib64 gravity-bootloader-tools.noarch: W: no-documentation gravity-bootloader.spec: W: no-%check-section gravity-bootloader.spec:172: W: macro-in-comment %{_libdir} gravity-bootloader.spec:191: W: libdir-macro-in-noarch-package (main package) %{_libdir}/%{upstream_name}/ gravity-bootloader.spec:199: W: libdir-macro-in-noarch-package stage1 %{_libdir}/%{upstream_name}-stage1/ gravity-bootloader.spec: W: invalid-url Source0: gravity-bootloader-1.6.1.tar.gz gravity-bootloader.noarch: E: incorrect-fsf-address /usr/share/licenses/gravity-bootloader/LICENSE.GPL-2 gravity-bootloader.noarch: E: incorrect-fsf-address /usr/share/licenses/gravity-bootloader/LICENSE.GPL2 gravity-bootloader-stage1.noarch: E: incorrect-fsf-address /usr/share/licenses/gravity-bootloader-stage1/LICENSE.GPL-2 gravity-bootloader-stage1.noarch: E: incorrect-fsf-address /usr/share/licenses/gravity-bootloader-stage1/LICENSE.GPL2 gravity-bootloader.noarch: W: files-duplicate /usr/share/licenses/gravity-bootloader/LICENSE.GPL2 /usr/share/licenses/gravity-bootloader/LICENSE.GPL-2 gravity-bootloader-stage1.noarch: W: files-duplicate /usr/share/licenses/gravity-bootloader-stage1/LICENSE.GPL2 /usr/share/licenses/gravity-bootloader-stage1/LICENSE.GPL-2 gravity-bootloader.spec:90: W: comparison-operator-in-deptoken bundled(crate(fatfs))= 4 packages and 0 specfiles checked; 29 errors, 18 warnings, 24 filtered, 29 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "gravity-bootloader-stage1". (none): E: there is no installed rpm "gravity-bootloader-tools". (none): E: there is no installed rpm "gravity-bootloader". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/rafalh/rust-fatfs/archive/4eccb50d011146fbed20e133d33b22f3c27292e7/rust-fatfs-4eccb50d011146fbed20e133d33b22f3c27292e7.tar.gz : CHECKSUM(SHA256) this package : 06302558ed3878e70e51109648e2972faf8ec444c352c31f8272a55d93850e95 CHECKSUM(SHA256) upstream package : 06302558ed3878e70e51109648e2972faf8ec444c352c31f8272a55d93850e95 Requires -------- gravity-bootloader (rpmlib, GLIBC filtered): config(gravity-bootloader) gravity-bootloader-stage1 (rpmlib, GLIBC filtered): gravity-bootloader-tools (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/python3 /usr/bin/sh gravity-bootloader python3 python3dist(construct) python3dist(pyserial) systemd-udev Provides -------- gravity-bootloader: bootloader bundled(PDCLib) bundled(arm-trusted-firmware) bundled(dlmalloc) bundled(dwc3) bundled(libfdt) bundled(minilzlib) bundled(tinf) config(gravity-bootloader) gravity-bootloader m1n1 gravity-bootloader-stage1: 0.4.0 bootloader-stage1 bundled(crate(fatfs))= gravity-bootloader-stage1 m1n1-stage1 gravity-bootloader-tools: bootloader-tools gravity-bootloader-tools m1n1-tools Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name gravity-bootloader --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-44-aarch64 Active plugins: Shell-api, Generic Disabled plugins: Perl, C/C++, fonts, Haskell, R, PHP, Java, SugarActivity, Ocaml, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH