This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. Note: Unversionned Python dependency found. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Python/#_dependencies - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: nwg-shell-config-0.5.14-1.fc40.noarch.rpm nwg-shell-config-0.5.14-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnobamje9')] checks: 31, packages: 2 nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/__about__.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/__init__.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/autotiling.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/help.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/locker.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/main.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/main_hyprland.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/main_sway.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/tools.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/translate.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/ui_components.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/update_indicator.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/updater.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/updates.py.new nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/autotiling.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/help.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/locker.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/main.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/main_hyprland.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/main_sway.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/translate.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/update_indicator.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/updater.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/updates.py 644 /usr/bin/env python3 nwg-shell-config.spec:64: W: non-break-space line 64, char 30 nwg-shell-config.spec:67: W: non-break-space line 67, char 30 nwg-shell-config.spec:70: W: non-break-space line 70, char 30 nwg-shell-config.spec:73: W: non-break-space line 73, char 30 nwg-shell-config.spec:76: W: non-break-space line 76, char 30 nwg-shell-config.spec:79: W: non-break-space line 79, char 30 nwg-shell-config.spec:82: W: non-break-space line 82, char 30 nwg-shell-config.spec:85: W: non-break-space line 85, char 30 nwg-shell-config.spec:88: W: non-break-space line 88, char 30 nwg-shell-config.spec:91: W: non-break-space line 91, char 30 nwg-shell-config.spec:97: W: non-break-space line 97, char 30 nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-autotiling nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-lock nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-config nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-config-hyprland nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-config-sway nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-help nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-translate nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-updater nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-update-indicator nwg-shell-config.noarch: W: devel-file-in-non-devel-package /usr/bin/nwg-shell-config 2 packages and 0 specfiles checked; 24 errors, 21 warnings, 24 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/__about__.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/__init__.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/autotiling.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/help.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/locker.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/main.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/main_hyprland.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/main_sway.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/tools.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/translate.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/ui_components.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/update_indicator.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/updater.py.new nwg-shell-config.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell_config/updates.py.new nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/autotiling.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/help.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/locker.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/main.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/main_hyprland.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/main_sway.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/translate.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/update_indicator.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/updater.py 644 /usr/bin/env python3 nwg-shell-config.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_shell_config/updates.py 644 /usr/bin/env python3 nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-autotiling nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-lock nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-config nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-config-hyprland nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-config-sway nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-help nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-translate nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-shell-updater nwg-shell-config.noarch: W: no-manual-page-for-binary nwg-update-indicator nwg-shell-config.noarch: W: devel-file-in-non-devel-package /usr/bin/nwg-shell-config 1 packages and 0 specfiles checked; 24 errors, 10 warnings, 24 badness; has taken 0.1 s Source checksums ---------------- https://github.com/nwg-piotr/nwg-shell-config/archive/v0.5.14/nwg-shell-config-0.5.14.tar.gz : CHECKSUM(SHA256) this package : 53ca184b18ce3f253e147e0542f68d3f795520e63c02aae513c81b5b1ddc8898 CHECKSUM(SHA256) upstream package : 53ca184b18ce3f253e147e0542f68d3f795520e63c02aae513c81b5b1ddc8898 Requires -------- nwg-shell-config (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python-geopy python-gobject python-i3ipc Provides -------- nwg-shell-config: application() application(nwg-shell-config.desktop) nwg-shell-config python3.12dist(nwg-shell-config) python3dist(nwg-shell-config) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nwg-shell-config --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: PHP, fonts, Perl, R, C/C++, Haskell, Java, SugarActivity, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH