This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/qownnotes See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 614400 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qownnotes-translations [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: qownnotes-23.9.7-1.fc40.x86_64.rpm qownnotes-translations-23.9.7-1.fc40.noarch.rpm qownnotes-debuginfo-23.9.7-1.fc40.x86_64.rpm qownnotes-debugsource-23.9.7-1.fc40.x86_64.rpm qownnotes-23.9.7-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnohmd_xb')] checks: 31, packages: 5 qownnotes.spec:158: E: rpm-buildroot-usage %build PREFIX=%{buildroot}%{_prefix} \ qownnotes.x86_64: W: no-manual-page-for-binary QOwnNotes qownnotes-translations.noarch: W: no-documentation 5 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 1.2 s Rpmlint (debuginfo) ------------------- Checking: qownnotes-debuginfo-23.9.7-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2361h6qc')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 qownnotes.x86_64: W: no-manual-page-for-binary QOwnNotes qownnotes-translations.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s Source checksums ---------------- https://github.com/qownnotes/QHotkey/archive/998c76c21bef8645802804d77e60a7dc8efcaf6f/qhotkey-998c76c.tar.gz : CHECKSUM(SHA256) this package : 71a5f307c4afa628c982c5e9dc82e7e2f34229ab6343d1d3fd00809a85863ef9 CHECKSUM(SHA256) upstream package : 71a5f307c4afa628c982c5e9dc82e7e2f34229ab6343d1d3fd00809a85863ef9 https://github.com/qownnotes/md4c/archive/8c23869db354572b9293f3d166557ad1720d0b51/md4c-8c23869.tar.gz : CHECKSUM(SHA256) this package : cd6305ec5893087b64d48f266c6966fc2108f466fdef8b62b66151f31608363c CHECKSUM(SHA256) upstream package : cd6305ec5893087b64d48f266c6966fc2108f466fdef8b62b66151f31608363c https://github.com/pbek/qkeysequencewidget/archive/8cbb54a12f33e41bf7c4795405f4235db1ee8ff1/qkeysequencewidget-8cbb54a.tar.gz : CHECKSUM(SHA256) this package : 2f1c367915dfacee229f1d74152fa6799ee6baa4e27c255c668d392f9a6d6bf6 CHECKSUM(SHA256) upstream package : 2f1c367915dfacee229f1d74152fa6799ee6baa4e27c255c668d392f9a6d6bf6 https://github.com/pbek/qt-piwik-tracker/archive/925272c2913932f7b0885ef41a12d2d07e9d215d/piwiktracker-925272c.tar.gz : CHECKSUM(SHA256) this package : da213b68fa822a63134511097240bad04a4fbe4a89dc30ec02eacbd93a98d049 CHECKSUM(SHA256) upstream package : da213b68fa822a63134511097240bad04a4fbe4a89dc30ec02eacbd93a98d049 https://github.com/pbek/qtcsv/archive/ae15c33b066fea9373a07bed5dc898c10b45ce2a/qtcsv-ae15c33.tar.gz : CHECKSUM(SHA256) this package : f3cf2d77fb32fbdbc6a6487e5bad7499e96bea825d69cb85fa4aba46449b703b CHECKSUM(SHA256) upstream package : f3cf2d77fb32fbdbc6a6487e5bad7499e96bea825d69cb85fa4aba46449b703b https://github.com/pbek/Qt-Toolbar-Editor/archive/ca0728c9924c6464234f7e477aa9509293d0a324/qttoolbareditor-ca0728c.tar.gz : CHECKSUM(SHA256) this package : 34d8743e74617ade379887711ab9709831bd25d23c6d4ff29b207e0544ea6ad4 CHECKSUM(SHA256) upstream package : 34d8743e74617ade379887711ab9709831bd25d23c6d4ff29b207e0544ea6ad4 https://github.com/pbek/qmarkdowntextedit/archive/235e32410d25acdd62ee9ae038e3884fda1edd45/qmarkdowntextedit-235e324.tar.gz : CHECKSUM(SHA256) this package : 6ae09c811189b8a4ae596f07b64db4e59c70e063360c91561beecc094b5e9ee5 CHECKSUM(SHA256) upstream package : 6ae09c811189b8a4ae596f07b64db4e59c70e063360c91561beecc094b5e9ee5 https://github.com/pbek/QOwnNotes/archive/v23.9.7/qownnotes-23.9.7.tar.gz : CHECKSUM(SHA256) this package : 35b0f0a1b1d7c8b627da8ca2c2468b325cd6209e56c6e3991e9e58278a9338b4 CHECKSUM(SHA256) upstream package : 35b0f0a1b1d7c8b627da8ca2c2468b325cd6209e56c6e3991e9e58278a9338b4 Requires -------- qownnotes (rpmlib, GLIBC filtered): hicolor-icon-theme libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Sql.so.5()(64bit) libQt5Sql.so.5(Qt_5)(64bit) libQt5WebSockets.so.5()(64bit) libQt5WebSockets.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5X11Extras.so.5()(64bit) libQt5X11Extras.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libbotan-2.so.19()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) qt5-qtbase(x86-64) rtld(GNU_HASH) qownnotes-translations (rpmlib, GLIBC filtered): qownnotes qownnotes-debuginfo (rpmlib, GLIBC filtered): qownnotes-debugsource (rpmlib, GLIBC filtered): Provides -------- qownnotes: application() application(PBE.QOwnNotes.desktop) bundled(fakevim) bundled(md4c) bundled(qhotkey) bundled(qkeysequencewidget) bundled(qmarkdowntextedit) bundled(qt-piwik-tracker) bundled(qt-toolbar-editor) bundled(qtcsv) metainfo() metainfo(qownnotes.appdata.xml) qownnotes qownnotes(x86-64) qownnotes-translations: qownnotes-translations qownnotes-debuginfo: debuginfo(build-id) qownnotes-debuginfo qownnotes-debuginfo(x86-64) qownnotes-debugsource: qownnotes-debugsource qownnotes-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name qownnotes --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Perl, Python, Java, Ocaml, PHP, fonts, Haskell, R, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH