This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel - Package is not relocatable. Note: Package has a "Prefix:" tag See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_relocatable_packages ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 20 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/truckersmp- cli/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.11/site- packages/truckersmp_cli, /usr/lib/python3.11/site- packages/truckersmp_cli/__pycache__, /usr/lib/python3.11/site- packages/truckersmp_cli-0.10.1-py3.11.egg-info [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.11/site- packages/truckersmp_cli/__pycache__, /usr/lib/python3.11/site- packages/truckersmp_cli, /usr/lib/python3.11/site- packages/truckersmp_cli-0.10.1-py3.11.egg-info [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-%{release}-buildroot See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file Note: Found : Packager: badlydrawnface See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_tags_and_sections [!]: Uses parallel make %{?_smp_mflags} macro. [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define name truckersmp-cli, %define version 0.10.1, %define release 1 [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: truckersmp-cli-0.10.1-1.fc39.noarch.rpm truckersmp-cli-0.10.1-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpt9lertot')] checks: 31, packages: 2 truckersmp-cli.spec: E: superfluous-%clean-section truckersmp-cli.spec:35: W: setup-not-quiet truckersmp-cli.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/truckersmp_cli/flatpak_helper.py 644 /usr/bin/env python3 truckersmp-cli.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/truckersmp_cli/steamruntime_helper.py 644 /usr/bin/env python3 truckersmp-cli.noarch: W: no-version-in-last-changelog truckersmp-cli.src: W: no-version-in-last-changelog truckersmp-cli.noarch: W: no-manual-page-for-binary truckersmp-cli truckersmp-cli.noarch: W: no-documentation truckersmp-cli.spec:14: W: hardcoded-packager-tag badlydrawnface truckersmp-cli.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/truckersmp_cli-0.10.1-py3.11.egg-info/not-zip-safe /usr/lib/python3.11/site-packages/truckersmp_cli-0.10.1-py3.11.egg-info/dependency_links.txt truckersmp-cli.noarch: E: description-line-too-long truckersmp-cli allows to download TruckersMP and handles starting TruckersMP through Wine while supporting the Windows versions of American Truck Simulator and Euro Truck Simulator 2. truckersmp-cli.noarch: E: description-line-too-long The Windows version of Steam should already be able to run in the same Wine prefix. The Windows versions of ATS and ETS2 can be installed and updated via SteamCMD while all running Steam processes will be stopped to prevent Steam from loosing connection. Your Steam password and guard code are required by SteamCMD once for this to work. truckersmp-cli.noarch: E: description-line-too-long On Linux it's possible to start TruckersMP through Proton. A working native Steam installation is needed for this which has the desired game installed or with an update pending. SteamCMD can use your saved credentials for convenience. truckersmp-cli.src: E: description-line-too-long truckersmp-cli allows to download TruckersMP and handles starting TruckersMP through Wine while supporting the Windows versions of American Truck Simulator and Euro Truck Simulator 2. truckersmp-cli.src: E: description-line-too-long The Windows version of Steam should already be able to run in the same Wine prefix. The Windows versions of ATS and ETS2 can be installed and updated via SteamCMD while all running Steam processes will be stopped to prevent Steam from loosing connection. Your Steam password and guard code are required by SteamCMD once for this to work. truckersmp-cli.src: E: description-line-too-long On Linux it's possible to start TruckersMP through Proton. A working native Steam installation is needed for this which has the desired game installed or with an update pending. SteamCMD can use your saved credentials for convenience. 2 packages and 0 specfiles checked; 9 errors, 7 warnings, 9 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 truckersmp-cli.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/truckersmp_cli/flatpak_helper.py 644 /usr/bin/env python3 truckersmp-cli.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/truckersmp_cli/steamruntime_helper.py 644 /usr/bin/env python3 truckersmp-cli.noarch: W: no-version-in-last-changelog truckersmp-cli.noarch: W: no-manual-page-for-binary truckersmp-cli truckersmp-cli.noarch: W: no-documentation truckersmp-cli.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/truckersmp_cli-0.10.1-py3.11.egg-info/not-zip-safe /usr/lib/python3.11/site-packages/truckersmp_cli-0.10.1-py3.11.egg-info/dependency_links.txt truckersmp-cli.noarch: E: description-line-too-long truckersmp-cli allows to download TruckersMP and handles starting TruckersMP through Wine while supporting the Windows versions of American Truck Simulator and Euro Truck Simulator 2. truckersmp-cli.noarch: E: description-line-too-long The Windows version of Steam should already be able to run in the same Wine prefix. The Windows versions of ATS and ETS2 can be installed and updated via SteamCMD while all running Steam processes will be stopped to prevent Steam from loosing connection. Your Steam password and guard code are required by SteamCMD once for this to work. truckersmp-cli.noarch: E: description-line-too-long On Linux it's possible to start TruckersMP through Proton. A working native Steam installation is needed for this which has the desired game installed or with an update pending. SteamCMD can use your saved credentials for convenience. 1 packages and 0 specfiles checked; 5 errors, 4 warnings, 5 badness; has taken 0.0 s Source checksums ---------------- https://github.com/truckersmp-cli/truckersmp-cli/archive/refs/tags/0.10.1.tar.gz : CHECKSUM(SHA256) this package : 3f5e0289d06d5bdc39f86879283c7184adaa60eb06a3b4e481095da816121c16 CHECKSUM(SHA256) upstream package : 3f5e0289d06d5bdc39f86879283c7184adaa60eb06a3b4e481095da816121c16 Requires -------- truckersmp-cli (rpmlib, GLIBC filtered): /usr/bin/python3 SDL2 python3 python3-setuptools python3-vdf Provides -------- truckersmp-cli: truckersmp-cli Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name truckersmp-cli --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: Java, C/C++, Ocaml, R, fonts, Perl, PHP, SugarActivity, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH