This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'LGPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 3", "*No copyright* GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "GNU Lesser General Public License v3.0 or later", "*No copyright* GNU Lesser General Public License v3.0 or later", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Lesser General Public License, Version 3 GNU General Public License, Version 3", "MIT License", "GNU General Public License, Version 2 GNU General Public License v3.0 or later", "*No copyright* Boost Software License 1.0", "*No copyright* GNU General Public License v2.0 or later", "Boost Software License 1.0", "NTP License BSD 3-Clause License", "NTP License", "MIT License Boost Software License 1.0", "*No copyright* Public domain", "BSD 3-Clause License", "*No copyright* Apache License", "*No copyright* BSD 3-Clause License", "Apache License 2.0", "*No copyright* Apache License 2.0", "BSD 3-Clause License [generated file]". 1730 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/IfcOpenShell/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81765 bytes in 5 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in IfcOpenShell-devel , IfcOpenShell-python3 , IfcOpenShell-blenderbim , IfcOpenShell-ifcsverchok [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 43581440 bytes in /usr/share IfcOpenShell- blenderbim-0.7.0-0.2.20231117git.fc37.x86_64.rpm:23685120, IfcOpenShell- ifcsverchok-0.7.0-0.2.20231117git.fc37.x86_64.rpm:19834880 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: IfcOpenShell-0.7.0-0.2.20231117git.fc37.x86_64.rpm IfcOpenShell-devel-0.7.0-0.2.20231117git.fc37.x86_64.rpm IfcOpenShell-python3-0.7.0-0.2.20231117git.fc37.x86_64.rpm IfcOpenShell-blenderbim-0.7.0-0.2.20231117git.fc37.x86_64.rpm IfcOpenShell-ifcsverchok-0.7.0-0.2.20231117git.fc37.x86_64.rpm IfcOpenShell-debuginfo-0.7.0-0.2.20231117git.fc37.x86_64.rpm IfcOpenShell-debugsource-0.7.0-0.2.20231117git.fc37.x86_64.rpm IfcOpenShell-0.7.0-0.2.20231117git.fc37.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcllffaxb')] checks: 31, packages: 8 IfcOpenShell-python3.x86_64: E: zero-length /usr/lib64/python3.11/site-packages/ifc4d/test.py IfcOpenShell.spec:54: W: unversioned-explicit-provides blenderbim IfcOpenShell-blenderbim.x86_64: W: self-obsoletion blenderbim <= 0.2 obsoletes blenderbim IfcOpenShell-python3.x86_64: E: non-executable-script /usr/lib64/python3.11/site-packages/ifcclash/__main__.py 644 /usr/bin/env python3 IfcOpenShell-python3.x86_64: E: non-executable-script /usr/lib64/python3.11/site-packages/ifcclash/ifcclash.py 644 /usr/bin/env python3 IfcOpenShell-python3.x86_64: E: non-executable-script /usr/lib64/python3.11/site-packages/ifcpatch/__init__.py 644 /usr/bin/env python3 IfcOpenShell-python3.x86_64: E: non-executable-script /usr/lib64/python3.11/site-packages/ifcpatch/__main__.py 644 /usr/bin/env python3 IfcOpenShell-python3.x86_64: E: non-executable-script /usr/lib64/python3.11/site-packages/ifctester/__main__.py 644 /usr/bin/env python3 IfcOpenShell.x86_64: W: no-manual-page-for-binary IfcConvert IfcOpenShell.x86_64: W: no-manual-page-for-binary IfcGeomServer IfcOpenShell.x86_64: W: no-manual-page-for-binary svgfill IfcOpenShell-python3.x86_64: W: no-manual-page-for-binary cli.py IfcOpenShell-python3.x86_64: W: no-manual-page-for-binary gui.py IfcOpenShell-blenderbim.x86_64: E: no-binary IfcOpenShell-ifcsverchok.x86_64: E: no-binary IfcOpenShell.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 1) IfcOpenShell.spec: W: invalid-url Source0: IfcOpenShell-0.7.0.zip IfcOpenShell.x86_64: E: invalid-soname /usr/lib/liblibsvgfill.so liblibsvgfill.so IfcOpenShell-ifcsverchok.x86_64: W: files-duplicate /usr/share/blender/3.6/scripts/addons/ifcsverchok/nodes/ifc/__init__.py /usr/share/blender/3.6/scripts/addons/ifcsverchok/nodes/__init__.py IfcOpenShell-python3.x86_64: W: files-duplicate /usr/lib64/python3.11/site-packages/ifcopenshell/mvd/LICENSE /usr/lib64/python3.11/site-packages/ifccityjson/COPYING.LESSER IfcOpenShell-python3.x86_64: W: files-duplicate /usr/lib64/python3.11/site-packages/ifcopenshell/api/void/__init__.py /usr/lib64/python3.11/site-packages/ifcopenshell/api/attribute/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/classification/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/constraint/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/context/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/control/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/cost/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/document/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/drawing/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/geometry/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/georeference/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/grid/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/group/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/layer/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/library/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/material/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/nest/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/owner/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/profile/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/project/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/pset/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/pset_template/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/resource/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/root/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/sequence/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/spatial/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/structural/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/style/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/system/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/type/__init__.py:/usr/lib64/python3.11/site-packages/ifcopenshell/api/unit/__init__.py 8 packages and 0 specfiles checked; 9 errors, 12 warnings, 9 badness; has taken 17.6 s Rpmlint (debuginfo) ------------------- Checking: IfcOpenShell-python3-debuginfo-0.7.0-0.2.20231117git.fc37.x86_64.rpm IfcOpenShell-debuginfo-0.7.0-0.2.20231117git.fc37.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpovjeemm7')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 8.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "IfcOpenShell-ifcsverchok". (none): E: there is no installed rpm "IfcOpenShell-devel". (none): E: there is no installed rpm "IfcOpenShell-blenderbim". (none): E: there is no installed rpm "IfcOpenShell-python3-debuginfo". (none): E: there is no installed rpm "IfcOpenShell-debuginfo". (none): E: there is no installed rpm "IfcOpenShell". (none): E: there is no installed rpm "IfcOpenShell-python3". (none): E: there is no installed rpm "IfcOpenShell-debugsource". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 8 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Unversioned so-files -------------------- IfcOpenShell: /usr/lib/liblibsvgfill.so IfcOpenShell-python3: /usr/lib64/python3.11/site-packages/ifcopenshell/_ifcopenshell_wrapper.so Requires -------- IfcOpenShell (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libIfcGeom.so.0.7()(64bit) libIfcParse.so.0.7()(64bit) libSerializers.so.0.7()(64bit) libTKBO.so.7()(64bit) libTKBRep.so.7()(64bit) libTKBool.so.7()(64bit) libTKFillet.so.7()(64bit) libTKG2d.so.7()(64bit) libTKG3d.so.7()(64bit) libTKGeomAlgo.so.7()(64bit) libTKGeomBase.so.7()(64bit) libTKHLR.so.7()(64bit) libTKIGES.so.7()(64bit) libTKMath.so.7()(64bit) libTKMesh.so.7()(64bit) libTKOffset.so.7()(64bit) libTKPrim.so.7()(64bit) libTKSTEP.so.7()(64bit) libTKShHealing.so.7()(64bit) libTKTopAlgo.so.7()(64bit) libTKXSBase.so.7()(64bit) libTKernel.so.7()(64bit) libboost_iostreams.so.1.78.0()(64bit) libboost_program_options.so.1.78.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgmp.so.10()(64bit) libhdf5.so.200()(64bit) libhdf5_cpp.so.200()(64bit) liblibsvgfill.so()(64bit) libm.so.6()(64bit) libmpfr.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.9)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) IfcOpenShell-devel (rpmlib, GLIBC filtered): IfcOpenShell boost-devel libicu-devel libxml2-devel pcre-devel python3-devel tbb-devel IfcOpenShell-python3 (rpmlib, GLIBC filtered): /usr/bin/python3 IfcOpenShell hpp-fcl ld-linux-x86-64.so.2()(64bit) libIfcGeom.so.0.7()(64bit) libIfcParse.so.0.7()(64bit) libSerializers.so.0.7()(64bit) libTKBO.so.7()(64bit) libTKBRep.so.7()(64bit) libTKG2d.so.7()(64bit) libTKG3d.so.7()(64bit) libTKGeomBase.so.7()(64bit) libTKMath.so.7()(64bit) libTKTopAlgo.so.7()(64bit) libTKernel.so.7()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libhdf5_cpp.so.200()(64bit) liblibsvgfill.so()(64bit) libm.so.6()(64bit) libpython3.11.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) mysql-connector-python3 python(abi) python3-babel python3-boto3 python3-botocore python3-defusedxml python3-lark-parser python3-lxml python3-networkx python3-odfpy python3-openpyxl python3-ordered-set python3-pandas python3-parse python3-parse_type python3-pyparsing python3-pythonocc-core python3-six python3-xmlschema python3-xsdata rtld(GNU_HASH) IfcOpenShell-blenderbim (rpmlib, GLIBC filtered): /usr/bin/bash IfcOpenShell-python3 blender(ABI) python3-GitPython python3-bpypolyskel python3-cjio python3-dateutil python3-deepdiff python3-elementpath python3-isodate python3-jsonpickle python3-olca python3-pillow python3-pystache python3-shapely python3-svgwrite IfcOpenShell-ifcsverchok (rpmlib, GLIBC filtered): IfcOpenShell-blenderbim blender(ABI) IfcOpenShell-debuginfo (rpmlib, GLIBC filtered): IfcOpenShell-debugsource (rpmlib, GLIBC filtered): Provides -------- IfcOpenShell: IfcOpenShell IfcOpenShell(x86-64) libIfcGeom.so.0.7()(64bit) libIfcParse.so.0.7()(64bit) libSerializers.so.0.7()(64bit) liblibsvgfill.so()(64bit) IfcOpenShell-devel: IfcOpenShell-devel IfcOpenShell-devel(x86-64) IfcOpenShell-python3: IfcOpenShell-python3 IfcOpenShell-python3(x86-64) IfcOpenShell-blenderbim: IfcOpenShell-blenderbim IfcOpenShell-blenderbim(x86-64) blenderbim IfcOpenShell-ifcsverchok: IfcOpenShell-ifcsverchok IfcOpenShell-ifcsverchok(x86-64) IfcOpenShell-debuginfo: IfcOpenShell-debuginfo IfcOpenShell-debuginfo(x86-64) debuginfo(build-id) IfcOpenShell-debugsource: IfcOpenShell-debugsource IfcOpenShell-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name IfcOpenShell --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-37-x86_64 Active plugins: C/C++, Generic, Shell-api, Python Disabled plugins: Haskell, fonts, PHP, Java, SugarActivity, R, Ocaml, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH