This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - ldconfig not called in %post and %postun for Fedora 28 and later. Note: /sbin/ldconfig called in indimail-access See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-3.0+'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License", "FSF Unlimited License (with License Retention) and/or GNU General Public License v2.0 or later [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "X11 License [generated file]", "GNU General Public License v2.0 or later", "Apache License 2.0", "FSF Unlimited License (with License Retention)", "Creative Commons Attribution-NoDerivs 3.0", "Creative Commons Attribution- NoDerivatives 4.0", "*No copyright* GNU General Public License", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "*No copyright* MIT License", "*No copyright* Public domain", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU Lesser General Public License v2.1 or later", "ISC License", "BSD 3-Clause License", "GNU General Public License v2.0 or later and/or MIT License", "GNU General Public License, Version 2", "FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2", "BSD-4-Clause (University of California-Specific) and/or ISC License", "BSD-4-Clause (University of California-Specific)", "*No copyright* GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "MIT License", "GNU General Public License v2.0 or later [generated file, obsolete FSF postal address (Temple Place)]", "FSF Unlimited License (with License Retention) and/or GNU General Public License and/or GNU Lesser General Public License", "FSF All Permissive License", "FSF Unlimited License (with License Retention) [generated file]", "FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2 [generated file]". 1027 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/indimail-access/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc/indimail/tcp, /usr/share/indimail/locale/cs, /usr/share/indimail/locale/sr/LC_MESSAGES, /usr/lib/python3.12, /usr/share/indimail/locale/eo, /usr/share/indimail/locale/sq, /usr/lib/python3.12/site-packages/__pycache__, /usr/share/indimail/doc/courier-imap, /usr/share/indimail/locale/es, /usr/share/indimail/locale/ja, /usr/share/indimail/doc/courier- imap/html, /usr/share/indimail/locale/cs/LC_MESSAGES, /usr/share/indimail/locale/fr/LC_MESSAGES, /usr/share/man/man7, /usr/share/indimail/locale/es/LC_MESSAGES, /usr/share, /usr/share/indimail/locale/sq/LC_MESSAGES, /usr/share/man, /usr/share/indimail/locale/de/LC_MESSAGES, /usr/share/indimail/locale/ja/LC_MESSAGES, /usr/bin, /usr/lib, /usr/sbin, /usr/share/indimail/locale/sr, /usr/share/indimail/locale/vi, /usr/libexec/indimail, /usr/lib/python3.12/site-packages, /usr/share/indimail/locale/de, /usr/libexec, /usr/share/indimail/locale/pl/LC_MESSAGES, /usr/share/indimail/locale/fr, /usr/share/indimail/doc, /usr/share/man/man1, /usr/share/indimail/locale/vi/LC_MESSAGES, /usr/share/indimail/locale/sv/LC_MESSAGES, /usr/share/indimail, /var/log, /usr/share/indimail/locale/eo/LC_MESSAGES, /usr/share/indimail/locale/sv, /etc/indimail, /etc, /usr, /usr/share/indimail/locale/ro/LC_MESSAGES, /usr/share/man/man8, /var, /usr/share/indimail/locale/pl, /usr/lib64, /usr/share/indimail/locale/ro, /usr/libexec/indimail/imapmodules [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/indimail/tcp, /usr/share/indimail/locale/cs, /usr/share/indimail/locale/sr/LC_MESSAGES, /usr/lib/python3.12, /usr/share/indimail/locale/eo, /usr/share/indimail/locale/sq, /usr/lib/python3.12/site-packages/__pycache__, /usr/share/indimail/doc/courier-imap, /usr/share/indimail/locale/es, /usr/share/indimail/locale/ja, /usr/share/indimail/doc/courier- imap/html, /usr/share/indimail/locale/cs/LC_MESSAGES, /usr/share/indimail/locale/fr/LC_MESSAGES, /usr/share/man/man7, /usr/share/indimail/locale/es/LC_MESSAGES, /usr/share, /usr/share/indimail/locale/sq/LC_MESSAGES, /usr/share/man, /usr/share/indimail/locale/de/LC_MESSAGES, /usr/share/indimail/locale/ja/LC_MESSAGES, /usr/bin, /usr/sbin, /usr/lib, /usr/share/indimail/locale/sr, /usr/share/indimail/locale/vi, /usr/libexec/indimail, /usr/lib/python3.12/site-packages, /usr/share/indimail/locale/de, /usr/share/indimail/locale/pl/LC_MESSAGES, /usr/libexec, /usr/share/indimail/locale/fr, /usr/share/indimail/doc, /usr/share/man/man1, /usr/share/indimail/locale/vi/LC_MESSAGES, /usr/share/indimail/locale/sv/LC_MESSAGES, /usr/share/indimail, /var/log, /usr/share/indimail/locale/eo/LC_MESSAGES, /usr/share/indimail/locale/sv, /etc/indimail, /etc, /usr/share/indimail/locale/ro/LC_MESSAGES, /usr, /usr/share/man/man8, /var, /usr/share/indimail/locale/pl, /usr/lib64, /usr/share/indimail/locale/ro, /usr/libexec/indimail/imapmodules [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Package uses hardened build flags if required to. Note: suid files: authshadow, authpam [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source3: http://downloads.sourceforge.net/indimail/indimail-access-rpmlintrc, Source2: http://downloads.sourceforge.net/indimail/fetchmail-6.5.0.beta9.tar.gz, Source1: http://downloads.sourceforge.net/indimail/courier- imap-5.2.6.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _project local, %define nodebug 1 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1802240 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: indimail-access-1.2-1.1.fc41.x86_64.rpm indimail-access-1.2-1.1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpp5hdfzsz')] checks: 32, packages: 2 indimail-access.spec: E: superfluous-%clean-section indimail-access.src: E: spelling-error ('fetchmail', '%description -l en_US fetchmail -> fetch mail, fetch-mail, fetching') indimail-access.x86_64: E: setuid-binary /usr/libexec/indimail/imapmodules/authpam root 4755 indimail-access.x86_64: E: setuid-binary /usr/libexec/indimail/imapmodules/authshadow root 4755 indimail-access.x86_64: W: non-standard-uid /etc/indimail/tcp/tcp.imap.cdb indimail indimail-access.x86_64: W: non-standard-uid /etc/indimail/tcp/tcp.pop3.cdb indimail indimail-access.x86_64: W: non-standard-uid /var/log/svc qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/fetchmail qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/fetchmail/current qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/imapd-ssl.993 qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/imapd-ssl.993/current qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/imapd.143 qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/imapd.143/current qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/pop3d-ssl.995 qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/pop3d-ssl.995/current qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/pop3d.110 qmaill indimail-access.x86_64: W: non-standard-uid /var/log/svc/pop3d.110/current qmaill indimail-access.x86_64: W: non-standard-gid /etc/indimail/tcp/tcp.imap.cdb indimail indimail-access.x86_64: W: non-standard-gid /etc/indimail/tcp/tcp.pop3.cdb indimail indimail-access.x86_64: W: non-standard-gid /var/log/svc nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/fetchmail nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/fetchmail/current nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/imapd-ssl.993 nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/imapd-ssl.993/current nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/imapd.143 nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/imapd.143/current nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/pop3d-ssl.995 nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/pop3d-ssl.995/current nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/pop3d.110 nofiles indimail-access.x86_64: W: non-standard-gid /var/log/svc/pop3d.110/current nofiles indimail-access.x86_64: E: non-standard-executable-perm /usr/libexec/indimail/imapmodules/authpam 4755 indimail-access.x86_64: E: non-standard-executable-perm /usr/libexec/indimail/imapmodules/authshadow 4755 indimail-access.x86_64: E: non-readable /etc/indimail/authmodulelist 600 indimail-access.x86_64: E: non-readable /etc/indimail/imapd-ssl.dist 600 indimail-access.x86_64: E: non-readable /etc/indimail/imapd.cnf 600 indimail-access.x86_64: E: non-readable /etc/indimail/imapd.dist 600 indimail-access.x86_64: E: non-readable /etc/indimail/pop3d-ssl.dist 600 indimail-access.x86_64: E: non-readable /etc/indimail/pop3d.cnf 600 indimail-access.x86_64: E: non-readable /etc/indimail/pop3d.dist 600 indimail-access.x86_64: W: non-conffile-in-etc /etc/indimail/indimail-access-release indimail-access.x86_64: W: non-conffile-in-etc /etc/indimail/indimail-access-rpm.info indimail-access.x86_64: W: log-files-without-logrotate ['/var/log/svc'] indimail-access.x86_64: W: files-duplicate /usr/share/man/man7/authshadow.7.gz /usr/share/man/man7/authindi.7.gz:/usr/share/man/man7/authpam.7.gz indimail-access.x86_64: E: env-script-interpreter /usr/lib/python3.12/site-packages/fetchmailconf.py /usr/bin/env python indimail-access.x86_64: W: dangerous-command-in-%postun rm indimail-access.x86_64: W: dangerous-command-in-%post rm indimail-access.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/fetchmail SSL_CTX_set_cipher_list 2 packages and 0 specfiles checked; 14 errors, 33 warnings, 137 filtered, 14 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "indimail-access". There are no files to process nor additional arguments. Nothing to do, aborting. Requires -------- indimail-access (rpmlib, GLIBC filtered): /bin/sh /usr/bin/awk /usr/bin/hostname /usr/bin/perl /usr/bin/sh /usr/bin/which config(indimail-access) coreutils findutils glibc grep group(nofiles) indimail-mta libc.so.6()(64bit) libcourier-unicode.so.7()(64bit) libcrypt.so.2()(64bit) libcrypt.so.2(XCRYPT_2.0)(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdbm.so.6()(64bit) libidn2.so.0()(64bit) libidn2.so.0(IDN2_0.0.0)(64bit) libm.so.6()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpcre2-8.so.0()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) openssl pkgconfig procps python(abi) rtld(GNU_HASH) sed shadow-utils user(qmaill) Provides -------- indimail-access: config(indimail-access) indimail-access indimail-access(x86-64) libcourier-unicode.so.7()(64bit) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name indimail-access --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, C/C++, Shell-api Disabled plugins: Ocaml, SugarActivity, Java, R, Perl, PHP, Haskell, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH