This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in pihole-v7 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* European Union Public License, Version 1.2", "European Union Public License, Version 1.2", "*No copyright* European Union Public License, Version 1.2 and/or MIT License", "BSD 2-Clause License", "MIT License", "GNU General Public License, Version 2", "*No copyright* MIT License", "Apache License 2.0", "GNU General Public License v3.0 or later and/or MIT License", "*No copyright* Apache License 2.0". 710 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/pihole-v7/licensecheck.txt [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 9830400 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: pihole-v7-7.0-ftl7.0.web7.0.rev7.fc46.riscv64.rpm pihole-v7-7.0-ftl7.0.web7.0.rev7.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxs51l0s0')] checks: 32, packages: 2 pihole-v7.riscv64: E: useless-provides group(pihole) pihole-v7.riscv64: W: non-standard-uid /etc/pihole pihole pihole-v7.riscv64: W: non-standard-uid /etc/pihole/dnsmasq.conf pihole pihole-v7.riscv64: W: non-standard-uid /etc/pihole/hosts pihole pihole-v7.riscv64: W: non-standard-uid /etc/pihole/hosts/custom.list pihole pihole-v7.riscv64: W: non-standard-uid /etc/pihole/pihole.toml pihole pihole-v7.riscv64: W: non-standard-uid /var/lib/pihole pihole pihole-v7.riscv64: W: non-standard-uid /var/lib/pihole/dhcp.leases pihole pihole-v7.riscv64: W: non-standard-uid /var/lib/pihole/gravity.db pihole pihole-v7.riscv64: W: non-standard-uid /var/lib/pihole/pihole-FTL.db pihole pihole-v7.riscv64: W: non-standard-uid /var/lib/pihole/pihole-tmp.db pihole pihole-v7.riscv64: W: non-standard-uid /var/log/pihole pihole pihole-v7.riscv64: W: non-standard-uid /var/log/pihole/FTL.log pihole pihole-v7.riscv64: W: non-standard-uid /var/log/pihole/pihole.log pihole pihole-v7.riscv64: W: non-standard-uid /var/log/pihole/webserver.log pihole pihole-v7.riscv64: W: non-standard-gid /etc/pihole pihole pihole-v7.riscv64: W: non-standard-gid /etc/pihole/dnsmasq.conf pihole pihole-v7.riscv64: W: non-standard-gid /etc/pihole/hosts pihole pihole-v7.riscv64: W: non-standard-gid /etc/pihole/hosts/custom.list pihole pihole-v7.riscv64: W: non-standard-gid /etc/pihole/pihole.toml pihole pihole-v7.riscv64: W: non-standard-gid /var/lib/pihole pihole pihole-v7.riscv64: W: non-standard-gid /var/lib/pihole/dhcp.leases pihole pihole-v7.riscv64: W: non-standard-gid /var/lib/pihole/gravity.db pihole pihole-v7.riscv64: W: non-standard-gid /var/lib/pihole/pihole-FTL.db pihole pihole-v7.riscv64: W: non-standard-gid /var/lib/pihole/pihole-tmp.db pihole pihole-v7.riscv64: W: non-standard-gid /var/log/pihole pihole pihole-v7.riscv64: W: non-standard-gid /var/log/pihole/FTL.log pihole pihole-v7.riscv64: W: non-standard-gid /var/log/pihole/pihole.log pihole pihole-v7.riscv64: W: non-standard-gid /var/log/pihole/webserver.log pihole pihole-v7.riscv64: E: non-executable-script /usr/libexec/pihole/COL_TABLE 644 /usr/bin/env sh pihole-v7.riscv64: E: non-executable-script /usr/share/bash-completion/completions/pihole 644 /bin/bash pihole-v7.riscv64: E: non-executable-script /usr/share/bash-completion/completions/pihole-FTL 644 /bin/bash pihole-v7.riscv64: W: no-manual-page-for-binary pihole-FTL pihole-v7.riscv64: E: no-changelogname-tag pihole-v7.src: E: no-changelogname-tag pihole-v7.riscv64: E: logrotate-user-writable-log-dir /var/log/pihole pihole:pihole 0755 pihole-v7.riscv64: E: incoherent-logrotate-file /etc/logrotate.d/pihole pihole-v7.riscv64: W: files-duplicate /usr/share/pihole/www/admin/LICENSE /usr/share/licenses/pihole-v7/web-LICENSE pihole-v7.riscv64: W: crypto-policy-non-compliance-openssl /usr/bin/pihole-FTL SSL_CTX_set_cipher_list pihole-v7.riscv64: W: binary-or-shlib-calls-gethostbyname /usr/bin/pihole-FTL 2 packages and 0 specfiles checked; 8 errors, 32 warnings, 16 filtered, 8 badness; has taken 0.9 s Rpmlint (debuginfo) ------------------- Checking: pihole-v7-debuginfo-7.0-ftl7.0.web7.0.rev7.fc46.riscv64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1i6uajid')] checks: 32, packages: 1 pihole-v7-debuginfo.riscv64: E: no-changelogname-tag 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 7 filtered, 1 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "pihole-v7-debuginfo". (none): E: there is no installed rpm "pihole-v7". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/darkexplosiveqwx/pi-hole/archive/refs/heads/rpm-v7.tar.gz#/core-v7.0.tar.gz : CHECKSUM(SHA256) this package : a43bfa85743cdb7495668368ad9f2ea1f21d7fe94d2ff083188d85a24686ce26 CHECKSUM(SHA256) upstream package : a43bfa85743cdb7495668368ad9f2ea1f21d7fe94d2ff083188d85a24686ce26 https://github.com/pi-hole/web/archive/refs/heads/development.tar.gz#/web-v7.0.tar.gz : CHECKSUM(SHA256) this package : 62b8a4b47ec99199b84d566acdc096ef97ad9b54f425d0165eb34716999a23f6 CHECKSUM(SHA256) upstream package : 62b8a4b47ec99199b84d566acdc096ef97ad9b54f425d0165eb34716999a23f6 https://github.com/darkexplosiveqwx/pi-hole-FTL/archive/refs/heads/rpm-v7.tar.gz#/FTL-v7.0.tar.gz : CHECKSUM(SHA256) this package : 3bbba12e4cb063b9f7ce50fe61b5c88ab386ee9ffd2c70edb8ac027c7ec1af2c CHECKSUM(SHA256) upstream package : 3bbba12e4cb063b9f7ce50fe61b5c88ab386ee9ffd2c70edb8ac027c7ec1af2c https://www.wireshark.org/download/automated/data/manuf.gz : CHECKSUM(SHA256) this package : f2e3d082bb3a3d99850df2cb0e71eb5ee33bb318a92a7dfc4eb154ca394d1540 CHECKSUM(SHA256) upstream package : f2e3d082bb3a3d99850df2cb0e71eb5ee33bb318a92a7dfc4eb154ca394d1540 Requires -------- pihole-v7 (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash /usr/bin/sh bash bash-completion bind-utils ca-certificates config(pihole-v7) curl findutils gawk grep group(pihole) iproute jq ld-linux-riscv64-lp64d.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.4()(64bit) libcrypto.so.4(OPENSSL_4.0.0)(64bit) libdbus-1.so.3()(64bit) libdbus-1.so.3(LIBDBUS_1_3)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libgmp.so.10()(64bit) libhogweed.so.7()(64bit) libhogweed.so.7(HOGWEED_7)(64bit) libidn2.so.0()(64bit) libidn2.so.0(IDN2_0.0.0)(64bit) libm.so.6()(64bit) libnetfilter_conntrack.so.3()(64bit) libnettle.so.9()(64bit) libnettle.so.9(NETTLE_9)(64bit) libnftables.so.1()(64bit) libnftables.so.1(LIBNFTABLES_1)(64bit) libnghttp2.so.14()(64bit) libnghttp3.so.9()(64bit) libreadline.so.8()(64bit) libssl.so.4()(64bit) libssl.so.4(OPENSSL_4.0.0)(64bit) logrotate lshw procps-ng psmisc rtld(GNU_HASH) shadow-utils systemd unzip user(pihole) util-linux Provides -------- pihole-v7: bundled(civetweb) bundled(cjson) bundled(dnsmasq) bundled(lua) bundled(miniz) bundled(sqlite3) bundled(tomlc17) bundled(tre) config(pihole-v7) group(pihole) pihole-v7 pihole-v7(riscv-64) user(pihole) Generated by fedora-review 0.12.0 (a08f0fc) last change: 2026-09-18 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name pihole-v7 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-riscv64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Ocaml, PHP, R, SugarActivity, Perl, fonts, Java, Python, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH, UNRETIREMENT