## START: Set by rpmautospec
## (rpmautospec version 0.2.5)
%define autorelease(e:s:pb:) %{?-p:0.}%{lua:
    release_number = 8;
    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
    print(release_number + base_release_number - 1);
}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist}
## END: Set by rpmautospec

%global npm_name topojson-server

Name:           %{npm_name}
Version:        3.0.1
Release:        %autorelease -b 2
Summary:        Convert GeoJSON to TopoJSON

# License of topojson-server is ISC; others come from bundled dependencies. See
# the license file %%{npm_name}-%%{version}-bundled-licenses.txt for a list of
# licenses in NPM format. Each bundled dependency has the license specified in
# the "license" key of its package.json file.
License:        ISC and MIT
%global forgeurl https://github.com/topojson/%{npm_name}
%forgemeta
URL:            %{forgeurl}
Source0:        https://registry.npmjs.org/%{npm_name}/-/%{npm_name}-%{version}.tgz
# The test files are not included in the NPM tarball. Instead of using a
# dl-tests.sh script source, we add the corresponding GitHub tarball as a
# second source. This results in some duplication in the source RPM, but it is
# a lot simpler!
#
# Note https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/ says,
# “The canonical method for shipping most node modules is tarballs from the npm
# registry. […] This method should be preferred to using checkouts from git or
# automatically generated tarballs from GitHub.” (Otherwise, we might just use
# the GitHub tarball as the primary source.)
Source1:        %{forgesource}
# Created with (from nodejs-packaging RPM):
# nodejs-packaging-bundler %%{npm_name} %%{version}
Source2:        %{npm_name}-%{version}-nm-prod.tgz
Source3:        %{npm_name}-%{version}-nm-dev.tgz
Source4:        %{npm_name}-%{version}-bundled-licenses.txt
# Hand-written man page
Source5:        geo2topo.1
# https://bugzilla.redhat.com/show_bug.cgi?id=1920223
Source6:        check-null-licenses
Source7:        audited-null-licenses.toml

ExclusiveArch:  %{nodejs_arches} noarch
BuildArch:      noarch

BuildRequires:  nodejs-devel
BuildRequires:  /usr/bin/esbuild
BuildRequires:  symlinks
BuildRequires:  rsync

# For check-null-licenses
BuildRequires:  python3
BuildRequires:  python3dist(toml)

Requires:       nodejs

%description
Convert GeoJSON to TopoJSON for smaller files and the power of topology!

See How to Infer Topology (https://bost.ocks.org/mike/topology/) for details on
how the topology is constructed.

geo2topo

  Converts one or more GeoJSON objects to an output topology.

See also topojson-client and topojson-simplify.


%prep
%setup -q -n package
# Copy in the tests from the GitHub tarball.
%setup -q -T -D -b 1 -n package
cp -rp '../%{npm_name}-%{version}/test' './'

# Remove pre-compiled bundled JavaScript that was built with rollup. Fedora
# guidelines prevent us from using it.
rm -rf dist

cp -p '%{SOURCE4}' .
# Set up bundled runtime (prod) node modules.
tar -xzf '%{SOURCE2}'
mkdir -p node_modules
pushd node_modules
ln -s ../node_modules_prod/* .
if [ -e ../node_modules_prod/.bin ]
then
  ln -s ../node_modules_prod/.bin .
fi
popd

# Fix shebang lines in executables. For some reason, brp-mangle-shebangs does
# not seem to do this under %%nodejs_sitelib.
find . -type f -perm /0111 |
  while read -r fn
  do
    if head -n 1 "${fn}" | grep -E '^#!%{_bindir}/env[[:blank:]]+' >/dev/null
    then
      sed -r -i '1s/env +//' "${fn}"
    fi
  done

# Remove dotfiles (hidden files) from bundled dependencies. Currently this is
# just .package-lock.json. If a dependency appears with an important hidden
# file, we may need to exclude it from removal.
#
# Also remove zero-length files from bundled dependencies. Currently there are
# none.
find node_modules_prod -type f \( -name '.*' -o -size 0 \) -print -delete


%build
# Under Fedora guidelines, we had to remove the pre-compiled bundled JavaScript
# sources. We have two options under the guidelines:
#
# 1. Patch everything to use ES6 modules directly. This is conceptually clean
#    but messy in practice.
# 2. Rebuild it ourselves. This is easy, and stays closest to upstream. Since
#    the rollup configuration is pretty trivial, and rollup is not in the prod
#    tarball, we choose to use esbuild instead of rollup. We also do not build
#    a minified bundle; that would be useful only for browsers.
#
# We choose to rebuild the bundle. We add a source map for better debugging,
# and we use CommonJS format instead of UMD since we do not need to support
# browsers. (Note that the tests would fail if we used iife format, for unknown
# reasons.)
mkdir -p dist
esbuild --bundle --platform=node --sourcemap \
    --outfile='dist/%{name}.js' 'src/index.js'

# Just as rollup did, we build a second bundle that exposes internals. (We
# could do this with rollup from the dev tarball in %%check, but unless we took
# great care, that would overwrite our main bundle, and we want to test with
# the same bundler we use in production.
mkdir -p build
esbuild --bundle --platform=node --sourcemap \
    --outfile='build/topojson-internals.js' 'test/internals.js'


%install
install -d '%{buildroot}%{nodejs_sitelib}/%{npm_name}'
# Note that, per Fedora guidelines, we MUST install the original sources
# whether they are used or not.
cp -rp \
    package.json \
    bin \
    dist \
    src \
    node_modules node_modules_prod \
    '%{buildroot}%{nodejs_sitelib}/%{npm_name}'

install -d '%{buildroot}%{_bindir}'
# Create an absolute symlink in the buildroot, then convert it to a relative
# one that will still resolve after installation. Otherwise, to create a
# relative symlink, we would have to know how deeply nested %%nodejs_sitelib
# is, which breaks the abstraction of using a macro.
find '%{buildroot}%{nodejs_sitelib}/%{npm_name}/bin/' -type f |
  while read -r target
  do
    link="%{buildroot}%{_bindir}/$(basename "${target}")"
    ln -sf "${target}" "${link}"
  done
symlinks -c -o %{buildroot}%{_bindir}/*

install -t '%{buildroot}%{_mandir}/man1' -p -m 0644 -D '%{SOURCE5}'


%check
%{python3} '%{SOURCE6}' --exceptions '%{SOURCE7}' --with prod node_modules_prod
%{__nodejs} -e 'require("./")'

# Set up bundled dev node_modules for testing. We must do this here, not in
# prep, so that they are not pulled into the installed RPM.
tar -xzf '%{SOURCE3}'
%{python3} '%{SOURCE6}' --exceptions '%{SOURCE7}' --with dev node_modules_dev
# The usual symlinking approach recommended by the guidelines does not work as
# some dependencies are split across the prod and dev tarballs due to plugins.
# Instead, we overlay the two directories using local rsync. This is less
# space-efficient, but it works!
rm -rf node_modules
cp -rp ./node_modules_prod node_modules
rsync -aqP ./node_modules_dev/ ./node_modules/
# See scripts.test in package.json. Note that we do not use rollup at all; we
# want to test the same bundle we use in production.
NODE_ENV=test find test -type f -name '*-test.js' \
    -exec './node_modules/.bin/tape' '{}' '+'


%files
%doc README.md
%license LICENSE %{npm_name}-%{version}-bundled-licenses.txt
%{nodejs_sitelib}/%{npm_name}
%{_bindir}/geo2topo
%{_mandir}/man1/geo2topo.1*


%changelog
* sam. déc. 04 2021 Benjamin A. Beasley <code@musicinmybrain.net> 3.0.1-9
- Re-generate (update) dependency bundle

* lun. juil. 26 2021 Benjamin A. Beasley <code@musicinmybrain.net> 3.0.1-7
- Check dev bundle licenses *after* unpacking it

* lun. juil. 26 2021 Benjamin A. Beasley <code@musicinmybrain.net> 3.0.1-6
- Improved error detection in check-null-licenses

* lun. juil. 26 2021 Benjamin A. Beasley <code@musicinmybrain.net> 3.0.1-5
- Remove unnecessary nodejs_symlink_deps macro in check section

* lun. juil. 26 2021 Benjamin A. Beasley <code@musicinmybrain.net> 3.0.1-4
- More shell quoting

* Fri Feb 05 2021 Benjamin A. Beasley <code@musicinmybrain.net> - 3.0.1-2
- Add script to audit for dependencies with null licenses in %%check

* Sat Jan 23 2021 Benjamin A. Beasley <code@musicinmybrain.net> - 3.0.1-1
- Initial package