This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/skribilo/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/guile/2.0/site-ccache [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/emacs/site-lisp, /usr/lib64/guile, /usr/lib64/guile/2.0, /usr/share/emacs, /usr/lib64/guile/2.0/site-ccache [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 901120 bytes in 59 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr-rpmbuild/results/skribilo/srpm- unpacked/skribilo.spec See: (this test has no URL) [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2334720 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: skribilo-0.9.5-1.fc39.s390x.rpm skribilo-0.9.5-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzectir3j')] checks: 31, packages: 2 skribilo.s390x: W: only-non-binary-in-usr-lib skribilo.s390x: W: no-manual-page-for-binary skribilo-config skribilo.s390x: W: devel-file-in-non-devel-package /usr/bin/skribilo-config skribilo.s390x: W: dangling-relative-symlink /usr/share/info/bsd.png.gz ../doc/skribilo/bsd.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/document-toolchain.png.gz ../doc/skribilo/document-toolchain.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/eq-disponibilite.png.gz ../doc/skribilo/eq-disponibilite.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l-simplified.png.gz ../doc/skribilo/eq-limit-b-over-l-simplified.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l.png.gz ../doc/skribilo/eq-limit-b-over-l.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/linux.png.gz ../doc/skribilo/linux.png.gz 2 packages and 0 specfiles checked; 0 errors, 9 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 skribilo.s390x: W: only-non-binary-in-usr-lib skribilo.s390x: W: no-manual-page-for-binary skribilo-config skribilo.s390x: W: devel-file-in-non-devel-package /usr/bin/skribilo-config skribilo.s390x: W: dangling-relative-symlink /usr/share/info/bsd.png.gz ../doc/skribilo/bsd.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/document-toolchain.png.gz ../doc/skribilo/document-toolchain.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/eq-disponibilite.png.gz ../doc/skribilo/eq-disponibilite.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l-simplified.png.gz ../doc/skribilo/eq-limit-b-over-l-simplified.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l.png.gz ../doc/skribilo/eq-limit-b-over-l.png.gz skribilo.s390x: W: dangling-relative-symlink /usr/share/info/linux.png.gz ../doc/skribilo/linux.png.gz 1 packages and 0 specfiles checked; 0 errors, 9 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://keys.openpgp.org/vks/v1/by-fingerprint/3CE464558A84FDC69DB40CFB090B11993D9AEBB5 : CHECKSUM(SHA256) this package : 43a4ebcfabe3c69341fd850954f2dfdbf9faebef329e21ebbc02e6dd23ac7687 CHECKSUM(SHA256) upstream package : 65dce1fece960dde897c6ebe83d96b5bcec5adad83d02db01604039456f9dc35 https://download.savannah.nongnu.org/releases/skribilo/skribilo-0.9.5.tar.gz.sig : CHECKSUM(SHA256) this package : e5ded90be7d06a7239e662c3d42588cde973b7e8bfb8c8c65d5a2e1566c608f6 CHECKSUM(SHA256) upstream package : e5ded90be7d06a7239e662c3d42588cde973b7e8bfb8c8c65d5a2e1566c608f6 https://download.savannah.nongnu.org/releases/skribilo/skribilo-0.9.5.tar.gz : CHECKSUM(SHA256) this package : 00826a21c4634fb0b410ee89eb48068c445d800825874654e3d53d5ca3f0bf09 CHECKSUM(SHA256) upstream package : 00826a21c4634fb0b410ee89eb48068c445d800825874654e3d53d5ca3f0bf09 diff -r also reports differences Requires -------- skribilo (rpmlib, GLIBC filtered): /usr/bin/sh linux-libertine-biolinum-fonts linux-libertine-fonts lomt-junction-fonts source-foundry-hack-fonts texlive-lobster2 Provides -------- skribilo: skribilo skribilo(s390-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name skribilo --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-s390x Active plugins: Generic, Shell-api Disabled plugins: Haskell, fonts, C/C++, PHP, R, Python, Ocaml, Java, SugarActivity, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH