From 52afa00160ba0a8191fc2767478b18cc72cb45b5 Mon Sep 17 00:00:00 2001 From: ferdiu Date: Wed, 6 May 2026 19:50:00 +0200 Subject: [PATCH 1/2] fix: const correctness in sim_card_name Use const char * for strrchr result and strdup only the basename, avoiding discarding const qualifier. Fixes build error: discarded 'const' qualifier treated as error. Signed-off-by: ferdiu --- src/alsa-sim.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/alsa-sim.c b/src/alsa-sim.c index a8b61fc0..0c1fb55c 100644 --- a/src/alsa-sim.c +++ b/src/alsa-sim.c @@ -463,18 +463,14 @@ static void alsa_config_to_new_card( // return the basename of fn (no path, no extension) // e.g. "/home/user/file.ext" -> "file" static char *sim_card_name(const char *fn) { + /* strdup fn and remove path (if any) */ + const char *s = strrchr(fn, '/'); + char *name = s ? strdup(s + 1) : strdup(fn); + if (!name) return NULL; - // strdup fn and remove path (if any) - char *name = strrchr(fn, '/'); - if (name) - name = strdup(name + 1); - else - name = strdup(fn); - - // remove extension + /* remove extension */ char *dot = strrchr(name, '.'); - if (dot) - *dot = '\0'; + if (dot) *dot = '\0'; return name; } From bd2b19bb0dd6cf4b90f7016dc03f9c82a875ee2f Mon Sep 17 00:00:00 2001 From: ferdiu Date: Thu, 7 May 2026 09:39:57 +0200 Subject: [PATCH 2/2] =?UTF-8?q?fix:=20window-mixer.c:131:21:=20error:=20in?= =?UTF-8?q?itialization=20discards=20=E2=80=98const=E2=80=99=20qualifier?= =?UTF-8?q?=20from=20pointer=20target=20type=20[-Werror=3Ddiscarded-qualif?= =?UTF-8?q?iers]?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: ferdiu --- src/window-mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/window-mixer.c b/src/window-mixer.c index 2eadbbac..babb430e 100644 --- a/src/window-mixer.c +++ b/src/window-mixer.c @@ -128,7 +128,7 @@ GtkWidget *create_mixer_controls(struct alsa_card *card) { strncmp(elem->name, "Matrix ", 7)) continue; - char *mix_str = strstr(elem->name, "Mix "); + const char *mix_str = strstr(elem->name, "Mix "); if (!mix_str) continue;