This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file furo.js.LICENSE.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0 and/or GNU Affero General Public License v3.0", "*No copyright* GNU Affero General Public License v3.0", "GNU Affero General Public License v3.0", "*No copyright* Apache License 2.0", "GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Lesser General Public License, Version 2.1", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2", "Apache License 2.0", "*No copyright* GNU Lesser General Public License, Version 3", "GNU Lesser General Public License, Version 3", "BSD 3-Clause License", "GNU General Public License v2.0 or later", "FSF All Permissive License", "GNU Lesser General Public License, Version 2.1", "MIT License", "*No copyright* MIT License", "BSD 2-Clause License", "Apache License 2.0 and/or MIT License", "ISC License", "*No copyright* Mozilla Public License 2.0", "Apache License 2.0 and/or BSD 3-Clause License", "*No copyright* The Unlicense", "BSD 3-Clause License and/or ISC License", "*No copyright* BSD 2-Clause License", "OpenSSL License", "Apache License 2.0 [generated file]". 5900 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/lxd/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /var/lib/selinux/targeted/active/modules/200 [ ]: Package must own all directories that it creates. Note: Directories without known owners: /var/lib/selinux/targeted/active/modules/200, /etc/sysctl.d, /var/lib/selinux/targeted, /usr/share/selinux/packages/targeted, /var/lib/selinux/targeted/active/modules, /var/lib/selinux, /var/lib/selinux/targeted/active [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /var/lib/copr- rpmbuild/results/lxd/upstream- unpacked/Source0/lxd-5.21.2/vendor/dqlite/test/unit/ext, /var/lib/copr-rpmbuild/results/lxd/upstream- unpacked/Source0/lxd-5.21.2/lxd/include, /var/lib/copr- rpmbuild/results/lxd/upstream- unpacked/Source0/lxd-5.21.2/vendor/dqlite/include [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in lxd [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lxd- selinux , lxd-client , lxd-tools , lxd-migrate , lxd-agent [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define gotestflags -buildmode pie -compiler gc -v -tags libsqlite3 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: lxd-5.21.2-0.1.fc39.s390x.rpm lxd-selinux-5.21.2-0.1.fc39.noarch.rpm lxd-client-5.21.2-0.1.fc39.s390x.rpm lxd-tools-5.21.2-0.1.fc39.s390x.rpm lxd-migrate-5.21.2-0.1.fc39.s390x.rpm lxd-agent-5.21.2-0.1.fc39.s390x.rpm lxd-doc-5.21.2-0.1.fc39.noarch.rpm lxd-5.21.2-0.1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppv4tdf3w')] checks: 32, packages: 8 lxd-doc.noarch: E: zero-length /usr/share/doc/lxd-doc/html/_static/scripts/furo-extensions.js lxd-agent.s390x: E: statically-linked-binary /usr/bin/lxd-agent lxd-migrate.s390x: E: statically-linked-binary /usr/bin/lxd-migrate lxd-selinux.noarch: E: spelling-error ('Incus', '%description -l en_US Incus -> Incas, Indus, Inc us') lxd-tools.s390x: E: spelling-error ('unmap', '%description -l en_US unmap -> unman, uncap') lxd-tools.s390x: E: spelling-error ('uids', '%description -l en_US uids -> yids, ids, aids') lxd-tools.s390x: E: spelling-error ('gids', '%description -l en_US gids -> digs, gods, ids') lxd-tools.s390x: E: spelling-error ('lxc', '%description -l en_US lxc -> lxi, lac') lxd.s390x: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/lxd.conf lxd-agent.s390x: W: position-independent-executable-suggested /usr/bin/lxd-agent lxd-migrate.s390x: W: position-independent-executable-suggested /usr/bin/lxd-migrate lxd.s390x: E: non-standard-dir-perm /var/cache/lxd 700 lxd.s390x: E: non-standard-dir-perm /var/lib/lxd 711 lxd.s390x: E: non-standard-dir-perm /var/log/lxd 700 lxd-selinux.noarch: E: non-readable /var/lib/selinux/targeted/active/modules/200/lxd 0 lxd.s390x: W: non-conffile-in-etc /etc/sysctl.d/10-lxd-inotify.conf lxd-selinux.noarch: W: no-documentation lxd.spec:339: W: macro-in-comment %gobuildflags lxd.s390x: W: log-files-without-logrotate ['/var/log/lxd'] lxd-selinux.noarch: W: dangerous-command-in-%pre cp lxd-selinux.noarch: W: dangerous-command-in-%postun rm lxd-selinux.noarch: W: dangerous-command-in-%posttrans rm lxd-selinux.noarch: W: dangerous-command-in-%post rm 8 packages and 0 specfiles checked; 12 errors, 11 warnings, 33 filtered, 12 badness; has taken 2.4 s Rpmlint (debuginfo) ------------------- Checking: lxd-client-debuginfo-5.21.2-0.1.fc39.s390x.rpm lxd-migrate-debuginfo-5.21.2-0.1.fc39.s390x.rpm lxd-agent-debuginfo-5.21.2-0.1.fc39.s390x.rpm lxd-debuginfo-5.21.2-0.1.fc39.s390x.rpm lxd-tools-debuginfo-5.21.2-0.1.fc39.s390x.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpj32a53gw')] checks: 32, packages: 5 5 packages and 0 specfiles checked; 0 errors, 0 warnings, 33 filtered, 0 badness; has taken 1.8 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "lxd-debuginfo". (none): E: there is no installed rpm "lxd-migrate". (none): E: there is no installed rpm "lxd-client". (none): E: there is no installed rpm "lxd-client-debuginfo". (none): E: there is no installed rpm "lxd-tools". (none): E: there is no installed rpm "lxd". (none): E: there is no installed rpm "lxd-agent". (none): E: there is no installed rpm "lxd-agent-debuginfo". (none): E: there is no installed rpm "lxd-migrate-debuginfo". (none): E: there is no installed rpm "lxd-doc". (none): E: there is no installed rpm "lxd-tools-debuginfo". (none): E: there is no installed rpm "lxd-selinux". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 12 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/swagger-api/swagger-ui/raw/v5.18.2/dist//swagger-ui.css#/swagger-ui-5.18.2.css : CHECKSUM(SHA256) this package : 8f33d996025317049d4a9864f421eab2b2a247872f388026fa94c654913259e7 CHECKSUM(SHA256) upstream package : 8f33d996025317049d4a9864f421eab2b2a247872f388026fa94c654913259e7 https://github.com/swagger-api/swagger-ui/raw/v5.18.2/dist//swagger-ui-standalone-preset.js#/swagger-ui-5.18.2-standalone-preset.js : CHECKSUM(SHA256) this package : 6c5a3338e69d84e7b05117b9ba7b141d24bd3fc102a9eb02e804d3b04dcec5a1 CHECKSUM(SHA256) upstream package : 6c5a3338e69d84e7b05117b9ba7b141d24bd3fc102a9eb02e804d3b04dcec5a1 https://github.com/swagger-api/swagger-ui/raw/v5.18.2/dist//swagger-ui-bundle.js#/swagger-ui-5.18.2-bundle.js : CHECKSUM(SHA256) this package : c50b94bbc4f02394326fb7aed1f4fb693b3677f4b3d3344e0d6131808cbf281f CHECKSUM(SHA256) upstream package : c50b94bbc4f02394326fb7aed1f4fb693b3677f4b3d3344e0d6131808cbf281f https://github.com/canonical/lxd/releases/download/lxd-5.21.2/lxd-5.21.2.tar.gz : CHECKSUM(SHA256) this package : ad37b014825207f7c16c50f8b38b59c6331efd00195b6c35af20ca5404255957 CHECKSUM(SHA256) upstream package : ad37b014825207f7c16c50f8b38b59c6331efd00195b6c35af20ca5404255957 Requires -------- lxd (rpmlib, GLIBC filtered): (lxd-selinux = 5.21.2-0.1.fc39 if selinux-policy-targeted) (nftables if iptables-nft) /bin/sh /usr/bin/sh attr config(lxd) dnsmasq ebtables iptables libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libdqlite.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblxc.so.1()(64bit) libresolv.so.2()(64bit) libsqlite3.so.0()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libudev.so.1(LIBUDEV_189)(64bit) libudev.so.1(LIBUDEV_199)(64bit) lxcfs lxd-client rsync rtld(GNU_HASH) shadow-utils squashfs-tools systemd tar xdelta xz lxd-selinux (rpmlib, GLIBC filtered): /bin/sh container-selinux libselinux-utils policycoreutils policycoreutils-python-utils selinux-policy selinux-policy-base lxd-client (rpmlib, GLIBC filtered): gettext libc.so.6()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) lxd-tools (rpmlib, GLIBC filtered): libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libc.so.6()(64bit) libdqlite.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblxc.so.1()(64bit) libresolv.so.2()(64bit) libsqlite3.so.0()(64bit) lxd(s390-64) rtld(GNU_HASH) lxd-migrate (rpmlib, GLIBC filtered): rsync lxd-agent (rpmlib, GLIBC filtered): lxd(s390-64) lxd-doc (rpmlib, GLIBC filtered): Provides -------- lxd: config(lxd) group(lxd) lxd lxd(s390-64) lxd-selinux: lxd-selinux lxd-client: lxd-client lxd-client(s390-64) lxd-tools: lxd-tools lxd-tools(s390-64) lxd-migrate: lxd-migrate lxd-migrate(s390-64) lxd-agent: lxd-agent lxd-agent(s390-64) lxd-doc: lxd-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name lxd --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-s390x Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Haskell, PHP, Perl, fonts, Java, Ocaml, SugarActivity, Python, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH