This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file furo.js.LICENSE.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/incus See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in incus-minimal, incus-agent See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/sysctl.d, /usr/lib/udev, /usr/lib/udev/rules.d [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in incus- minimal , incus-client , incus-tools , incus-agent [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define gocompilerflags_static -compiler gc, %define gobuild_baseflags_static %{gocompilerflags_static} -mod=vendor -tags="rpm_crashtraceback ${GO_BUILDTAGS-${BUILDTAGS-}}" -a -v, %define gobuild_ldflags_static ${GO_LDFLAGS-${LDFLAGS-}} %{?currentgoldflags} -B 0x$(echo "%{name}-%{version}-%{release}-${SOURCE_DATE_EPOCH:-}" | sha1sum | cut -d ' ' -f1) -compressdwarf=false, %define gobuildflags_static() %{expand:%{gobuild_baseflags_static} -ldflags "%{gobuild_ldflags_static}"}, %define gobuild_static(-) %{expand:, %define gotestflags -buildmode pie -compiler gc -v -tags libsqlite3 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2283520 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: incus-7.4-0.1.fc43.aarch64.rpm incus-minimal-7.4-0.1.fc43.aarch64.rpm incus-client-7.4-0.1.fc43.aarch64.rpm incus-tools-7.4-0.1.fc43.aarch64.rpm incus-agent-7.4-0.1.fc43.aarch64.rpm incus-doc-7.4-0.1.fc43.noarch.rpm incus-7.4-0.1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqk1n8tg6')] checks: 32, packages: 7 incus-agent.aarch64: E: statically-linked-binary /usr/libexec/incus/agents/incus-agent.linux.aarch64 incus-tools.aarch64: E: statically-linked-binary /usr/bin/incus-migrate incus-agent.aarch64: E: spelling-error ('incusd', '%description -l en_US incusd -> incubus') incus-tools.aarch64: E: spelling-error ('unmap', '%description -l en_US unmap -> unman, uncap') incus-tools.aarch64: E: spelling-error ('uids', '%description -l en_US uids -> yids, ids, aids') incus-tools.aarch64: E: spelling-error ('gids', '%description -l en_US gids -> digs, gods, ids') incus-tools.aarch64: E: spelling-error ('lxc', '%description -l en_US lxc -> lxi, lac') incus-tools.aarch64: E: spelling-error ('simplestreams', '%description -l en_US simplestreams -> simple streams, simple-streams, simplest reams') incus.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory incus.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory incus.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory incus-minimal.aarch64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/incus.conf incus-agent.aarch64: W: position-independent-executable-suggested /usr/libexec/incus/agents/incus-agent.linux.aarch64 incus-tools.aarch64: W: position-independent-executable-suggested /usr/bin/incus-migrate incus-minimal.aarch64: W: obsolete-not-provided incus-selinux incus-minimal.aarch64: E: non-standard-dir-perm /run/incus 711 incus-minimal.aarch64: E: non-standard-dir-perm /var/cache/incus 700 incus-minimal.aarch64: E: non-standard-dir-perm /var/lib/incus 711 incus-minimal.aarch64: E: non-standard-dir-perm /var/log/incus 700 incus.aarch64: W: no-documentation incus.aarch64: E: no-binary incus-minimal.aarch64: W: log-files-without-logrotate ['/var/log/incus'] incus-minimal.aarch64: W: dangerous-command-in-%pre rm incus-minimal.aarch64: W: dangerous-command-in-%post rm 7 packages and 0 specfiles checked; 13 errors, 11 warnings, 27 filtered, 13 badness; has taken 6.2 s Rpmlint (debuginfo) ------------------- Checking: incus-debuginfo-7.4-0.1.fc43.aarch64.rpm incus-tools-debuginfo-7.4-0.1.fc43.aarch64.rpm incus-client-debuginfo-7.4-0.1.fc43.aarch64.rpm incus-agent-debuginfo-7.4-0.1.fc43.aarch64.rpm incus-minimal-debuginfo-7.4-0.1.fc43.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpn7xv674h')] checks: 32, packages: 5 5 packages and 0 specfiles checked; 0 errors, 0 warnings, 45 filtered, 0 badness; has taken 7.8 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "incus-minimal". (none): E: there is no installed rpm "incus-debuginfo". (none): E: there is no installed rpm "incus-agent-debuginfo". (none): E: there is no installed rpm "incus-doc". (none): E: there is no installed rpm "incus-minimal-debuginfo". (none): E: there is no installed rpm "incus". (none): E: there is no installed rpm "incus-client-debuginfo". (none): E: there is no installed rpm "incus-client". (none): E: there is no installed rpm "incus-tools-debuginfo". (none): E: there is no installed rpm "incus-tools". (none): E: there is no installed rpm "incus-agent". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 11 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://linuxcontainers.org/downloads/incus/incus-7.4.tar.xz : CHECKSUM(SHA256) this package : bca540edff53374d075a35c5f118c8675804cfc426e0b29acd70e9c9b6d1a2ed CHECKSUM(SHA256) upstream package : bca540edff53374d075a35c5f118c8675804cfc426e0b29acd70e9c9b6d1a2ed https://github.com/swagger-api/swagger-ui/raw/v5.33.0/dist//swagger-ui-bundle.js#/swagger-ui-5.33.0-bundle.js : CHECKSUM(SHA256) this package : 62df541529080464a7660adc793eab7128c6193ce3be24ddc1e0e0a4a63edc2f CHECKSUM(SHA256) upstream package : 62df541529080464a7660adc793eab7128c6193ce3be24ddc1e0e0a4a63edc2f https://github.com/swagger-api/swagger-ui/raw/v5.33.0/dist//swagger-ui-standalone-preset.js#/swagger-ui-5.33.0-standalone-preset.js : CHECKSUM(SHA256) this package : 5243d492e14505e0cab87ac8b0195d0e615943e651743b2b698450a46eb470be CHECKSUM(SHA256) upstream package : 5243d492e14505e0cab87ac8b0195d0e615943e651743b2b698450a46eb470be https://github.com/swagger-api/swagger-ui/raw/v5.33.0/dist//swagger-ui.css#/swagger-ui-5.33.0.css : CHECKSUM(SHA256) this package : 1ac324f7dcd27e4b9386b4bd6421271ec147e922a22c05ba24b11515e9aa6321 CHECKSUM(SHA256) upstream package : 1ac324f7dcd27e4b9386b4bd6421271ec147e922a22c05ba24b11515e9aa6321 Requires -------- incus (rpmlib, GLIBC filtered): edk2-aarch64 incus-agent incus-minimal qemu-audio-spice qemu-char-spice qemu-device-display-virtio-gpu qemu-device-display-virtio-vga qemu-device-usb-redirect qemu-img qemu-kvm-core virtiofsd xorriso incus-minimal (rpmlib, GLIBC filtered): (container-selinux >= 2.245.0 if selinux-policy) (nftables if iptables-nft) /bin/sh /usr/bin/sh attr config(incus-minimal) dnsmasq ebtables incus-client iptables libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcowsql.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblxc.so.1()(64bit) libresolv.so.2()(64bit) libsqlite3.so.0()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libudev.so.1(LIBUDEV_189)(64bit) libudev.so.1(LIBUDEV_199)(64bit) lxcfs rsync rtld(GNU_HASH) shadow-utils skopeo squashfs-tools systemd tar xdelta xz incus-client (rpmlib, GLIBC filtered): gettext libc.so.6()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) incus-tools (rpmlib, GLIBC filtered): libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblxc.so.1()(64bit) libresolv.so.2()(64bit) rsync rtld(GNU_HASH) incus-agent (rpmlib, GLIBC filtered): /bin/sh /usr/bin/sh systemd incus-doc (rpmlib, GLIBC filtered): Provides -------- incus: incus incus(aarch-64) incus-minimal: config(incus-minimal) group(incus) group(incus-admin) incus-minimal incus-minimal(aarch-64) incus-client: incus-client incus-client(aarch-64) incus-tools: incus-tools incus-tools(aarch-64) incus-agent: incus-agent incus-agent(aarch-64) incus-doc: incus-doc Generated by fedora-review 0.12.0 (a08f0fc) last change: 2026-09-18 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name incus --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-43-aarch64 Active plugins: Generic, Shell-api Disabled plugins: Perl, Haskell, SugarActivity, Java, Ocaml, R, C/C++, fonts, PHP, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH, UNRETIREMENT