This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /lib/systemd [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/sysctl.d, /usr/lib/systemd, /usr/lib/systemd/system, /etc/logrotate.d, /lib/systemd [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in lxd, lxd-agent [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-lxc-lxd-devel , lxd-client , lxd-tools , lxd-p2c , lxd-agent [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define gotestflags -buildmode pie -compiler gc -v -tags libsqlite3 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 2.16 starting (python version = 3.10.2, NVR = mock-2.16-1.fc35)... Start: init plugins INFO: tmpfs initialized INFO: selinux enabled INFO: chroot_scan: initialized INFO: compress_logs: initialized Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: mounting tmpfs at /var/lib/mock/fedora-rawhide-x86_64/root. INFO: reusing tmpfs at /var/lib/mock/fedora-rawhide-x86_64/root. INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.16 INFO: Mock Version: 2.16 Finish: chroot init INFO: installing package(s): /var/lib/copr-rpmbuild/results/lxd-doc-4.22-0.1.fc37.noarch.rpm /var/lib/copr-rpmbuild/results/lxd-client-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-agent-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-agent-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-p2c-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-tools-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-tools-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-client-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-p2c-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/golang-github-lxc-lxd-devel-4.22-0.1.fc37.noarch.rpm WARNING: Dnf command failed, retrying, attempt #2, sleeping 10s WARNING: Dnf command failed, retrying, attempt #3, sleeping 10s ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 37 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /var/lib/copr-rpmbuild/results/lxd-doc-4.22-0.1.fc37.noarch.rpm /var/lib/copr-rpmbuild/results/lxd-client-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-agent-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-agent-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-p2c-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-tools-debuginfo-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-tools-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-client-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/lxd-p2c-4.22-0.1.fc37.x86_64.rpm /var/lib/copr-rpmbuild/results/golang-github-lxc-lxd-devel-4.22-0.1.fc37.noarch.rpm --setopt=tsflags=nocontexts --setopt=tsflags=nocontexts --setopt=tsflags=nocontexts Rpmlint ------- Cannot parse rpmlint output: Source checksums ---------------- https://linuxcontainers.org/downloads/lxd/lxd-4.22.tar.gz : CHECKSUM(SHA256) this package : 0977e4b8ae854278194b15f3dc6472d217b9619a024d03f60e95393352212385 CHECKSUM(SHA256) upstream package : 0977e4b8ae854278194b15f3dc6472d217b9619a024d03f60e95393352212385 Requires -------- lxd (rpmlib, GLIBC filtered): (nftables or (ebtables and iptables)) /bin/sh /usr/bin/sh acl attr config(lxd) container-selinux dnsmasq libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libdqlite.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblxc.so.1()(64bit) libraft.so.0()(64bit) libsqlite3.so.0()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libudev.so.1(LIBUDEV_189)(64bit) libudev.so.1(LIBUDEV_199)(64bit) lxcfs lxd-client rsync rtld(GNU_HASH) shadow-utils squashfs-tools systemd tar xdelta xz golang-github-lxc-lxd-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/Rican7/retry/jitter) golang(github.com/armon/go-proxyproto) golang(github.com/canonical/candid/candidclient) golang(github.com/canonical/go-dqlite) golang(github.com/canonical/go-dqlite/app) golang(github.com/canonical/go-dqlite/client) golang(github.com/canonical/go-dqlite/driver) golang(github.com/digitalocean/go-qemu/qmp) golang(github.com/digitalocean/go-smbios/smbios) golang(github.com/dustinkirkland/golang-petname) golang(github.com/flosch/pongo2) golang(github.com/fsnotify/fsnotify) golang(github.com/fvbommel/sortorder) golang(github.com/go-httprequest/httprequest) golang(github.com/google/gopacket) golang(github.com/google/gopacket/layers) golang(github.com/gorilla/mux) golang(github.com/gorilla/websocket) golang(github.com/gosexy/gettext) golang(github.com/hashicorp/go-msgpack/codec) golang(github.com/j-keck/arping) golang(github.com/jaypipes/pcidb) golang(github.com/jochenvg/go-udev) golang(github.com/juju/gomaasapi) golang(github.com/juju/persistent-cookiejar) golang(github.com/juju/schema) golang(github.com/kballard/go-shellquote) golang(github.com/mattn/go-sqlite3) golang(github.com/mdlayher/ndp) golang(github.com/mdlayher/netx/eui64) golang(github.com/mdlayher/vsock) golang(github.com/miekg/dns) golang(github.com/olekukonko/tablewriter) golang(github.com/osrg/gobgp/v3/api) golang(github.com/osrg/gobgp/v3/pkg/packet/bgp) golang(github.com/osrg/gobgp/v3/pkg/server) golang(github.com/pborman/uuid) golang(github.com/pkg/errors) golang(github.com/robfig/cron/v3) golang(github.com/rogpeppe/fastuuid) golang(github.com/sirupsen/logrus) golang(github.com/spf13/cobra) golang(github.com/spf13/cobra/doc) golang(github.com/stretchr/testify/assert) golang(github.com/stretchr/testify/require) golang(github.com/syndtr/gocapability/capability) golang(go.etcd.io/bbolt) golang(golang.org/x/crypto/scrypt) golang(golang.org/x/crypto/ssh/terminal) golang(golang.org/x/sys/unix) golang(golang.org/x/term) golang(google.golang.org/protobuf/proto) golang(google.golang.org/protobuf/reflect/protoreflect) golang(google.golang.org/protobuf/runtime/protoimpl) golang(google.golang.org/protobuf/types/known/anypb) golang(gopkg.in/inconshreveable/log15.v2) golang(gopkg.in/inconshreveable/log15.v2/term) golang(gopkg.in/juju/environschema.v1) golang(gopkg.in/juju/environschema.v1/form) golang(gopkg.in/lxc/go-lxc.v2) golang(gopkg.in/macaroon-bakery.v2/bakery) golang(gopkg.in/macaroon-bakery.v2/bakery/checkers) golang(gopkg.in/macaroon-bakery.v2/bakery/identchecker) golang(gopkg.in/macaroon-bakery.v2/httpbakery) golang(gopkg.in/macaroon-bakery.v2/httpbakery/agent) golang(gopkg.in/macaroon-bakery.v2/httpbakery/form) golang(gopkg.in/tomb.v2) golang(gopkg.in/yaml.v2) lxd-client (rpmlib, GLIBC filtered): gettext libc.so.6()(64bit) rtld(GNU_HASH) lxd-tools (rpmlib, GLIBC filtered): libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libc.so.6()(64bit) libdqlite.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblxc.so.1()(64bit) libraft.so.0()(64bit) libsqlite3.so.0()(64bit) rtld(GNU_HASH) lxd-p2c (rpmlib, GLIBC filtered): rsync lxd-agent (rpmlib, GLIBC filtered): /bin/sh /usr/bin/sh lxd-doc (rpmlib, GLIBC filtered): Provides -------- lxd: config(lxd) lxd lxd(x86-64) golang-github-lxc-lxd-devel: golang(github.com/lxc/lxd/client) golang(github.com/lxc/lxd/lxc/config) golang(github.com/lxc/lxd/lxc/utils) golang(github.com/lxc/lxd/lxd-benchmark/benchmark) golang(github.com/lxc/lxd/lxd/apparmor) golang(github.com/lxc/lxd/lxd/backup) golang(github.com/lxc/lxd/lxd/bgp) golang(github.com/lxc/lxd/lxd/cgroup) golang(github.com/lxc/lxd/lxd/cluster) golang(github.com/lxc/lxd/lxd/cluster/raft) golang(github.com/lxc/lxd/lxd/cluster/request) golang(github.com/lxc/lxd/lxd/config) golang(github.com/lxc/lxd/lxd/daemon) golang(github.com/lxc/lxd/lxd/db) golang(github.com/lxc/lxd/lxd/db/cluster) golang(github.com/lxc/lxd/lxd/db/generate/db) golang(github.com/lxc/lxd/lxd/db/generate/file) golang(github.com/lxc/lxd/lxd/db/generate/lex) golang(github.com/lxc/lxd/lxd/db/node) golang(github.com/lxc/lxd/lxd/db/query) golang(github.com/lxc/lxd/lxd/db/schema) golang(github.com/lxc/lxd/lxd/device) golang(github.com/lxc/lxd/lxd/device/config) golang(github.com/lxc/lxd/lxd/device/nictype) golang(github.com/lxc/lxd/lxd/device/pci) golang(github.com/lxc/lxd/lxd/dns) golang(github.com/lxc/lxd/lxd/dnsmasq) golang(github.com/lxc/lxd/lxd/dnsmasq/dhcpalloc) golang(github.com/lxc/lxd/lxd/endpoints) golang(github.com/lxc/lxd/lxd/events) golang(github.com/lxc/lxd/lxd/filter) golang(github.com/lxc/lxd/lxd/firewall) golang(github.com/lxc/lxd/lxd/firewall/drivers) golang(github.com/lxc/lxd/lxd/fsmonitor) golang(github.com/lxc/lxd/lxd/fsmonitor/drivers) golang(github.com/lxc/lxd/lxd/include) golang(github.com/lxc/lxd/lxd/instance) golang(github.com/lxc/lxd/lxd/instance/drivers) golang(github.com/lxc/lxd/lxd/instance/drivers/qmp) golang(github.com/lxc/lxd/lxd/instance/instancetype) golang(github.com/lxc/lxd/lxd/instance/operationlock) golang(github.com/lxc/lxd/lxd/ip) golang(github.com/lxc/lxd/lxd/lifecycle) golang(github.com/lxc/lxd/lxd/locking) golang(github.com/lxc/lxd/lxd/maas) golang(github.com/lxc/lxd/lxd/metrics) golang(github.com/lxc/lxd/lxd/migration) golang(github.com/lxc/lxd/lxd/network) golang(github.com/lxc/lxd/lxd/network/acl) golang(github.com/lxc/lxd/lxd/network/openvswitch) golang(github.com/lxc/lxd/lxd/network/zone) golang(github.com/lxc/lxd/lxd/node) golang(github.com/lxc/lxd/lxd/operations) golang(github.com/lxc/lxd/lxd/project) golang(github.com/lxc/lxd/lxd/rbac) golang(github.com/lxc/lxd/lxd/refcount) golang(github.com/lxc/lxd/lxd/request) golang(github.com/lxc/lxd/lxd/resources) golang(github.com/lxc/lxd/lxd/response) golang(github.com/lxc/lxd/lxd/revert) golang(github.com/lxc/lxd/lxd/rsync) golang(github.com/lxc/lxd/lxd/seccomp) golang(github.com/lxc/lxd/lxd/state) golang(github.com/lxc/lxd/lxd/storage) golang(github.com/lxc/lxd/lxd/storage/drivers) golang(github.com/lxc/lxd/lxd/storage/filesystem) golang(github.com/lxc/lxd/lxd/storage/memorypipe) golang(github.com/lxc/lxd/lxd/storage/quota) golang(github.com/lxc/lxd/lxd/sys) golang(github.com/lxc/lxd/lxd/task) golang(github.com/lxc/lxd/lxd/template) golang(github.com/lxc/lxd/lxd/ucred) golang(github.com/lxc/lxd/lxd/util) golang(github.com/lxc/lxd/lxd/vsock) golang(github.com/lxc/lxd/lxd/warnings) golang(github.com/lxc/lxd/shared) golang(github.com/lxc/lxd/shared/api) golang(github.com/lxc/lxd/shared/cancel) golang(github.com/lxc/lxd/shared/cmd) golang(github.com/lxc/lxd/shared/dnsutil) golang(github.com/lxc/lxd/shared/eagain) golang(github.com/lxc/lxd/shared/i18n) golang(github.com/lxc/lxd/shared/idmap) golang(github.com/lxc/lxd/shared/instancewriter) golang(github.com/lxc/lxd/shared/ioprogress) golang(github.com/lxc/lxd/shared/logger) golang(github.com/lxc/lxd/shared/logging) golang(github.com/lxc/lxd/shared/netutils) golang(github.com/lxc/lxd/shared/osarch) golang(github.com/lxc/lxd/shared/simplestreams) golang(github.com/lxc/lxd/shared/subprocess) golang(github.com/lxc/lxd/shared/termios) golang(github.com/lxc/lxd/shared/units) golang(github.com/lxc/lxd/shared/usbid) golang(github.com/lxc/lxd/shared/validate) golang(github.com/lxc/lxd/shared/version) golang-github-lxc-lxd-devel golang-ipath(github.com/lxc/lxd) lxd-client: lxd-client lxd-client(x86-64) lxd-tools: lxd-tools lxd-tools(x86-64) lxd-p2c: lxd-p2c lxd-p2c(x86-64) lxd-agent: lxd-agent lxd-agent(x86-64) lxd-doc: lxd-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name lxd --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: SugarActivity, Java, fonts, Python, Haskell, R, Perl, PHP, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH