This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - Dist tag is present. Note: Multiple Release: tags found See: https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/mpf/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mpf- check , mpf-cli , mpf-gui [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mpf-3.8.3~20260724234123.5c736f88-1.fc44.aarch64.rpm mpf-check-3.8.3~20260724234123.5c736f88-1.fc44.aarch64.rpm mpf-cli-3.8.3~20260724234123.5c736f88-1.fc44.aarch64.rpm mpf-gui-3.8.3~20260724234123.5c736f88-1.fc44.aarch64.rpm mpf-3.8.3~20260724234123.5c736f88-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpev5ogras')] checks: 32, packages: 5 mpf.aarch64: E: spelling-error ('cli', 'Summary(en_US) cli -> CLI, cl, clii') mpf.aarch64: E: spelling-error ('gui', 'Summary(en_US) gui -> GUI, goo, gun') mpf.aarch64: E: spelling-error ('cli', '%description -l en_US cli -> CLI, cl, clii') mpf.aarch64: E: spelling-error ('orchestrator', '%description -l en_US orchestrator -> orchestra tor, orchestra-tor, orchestrate') mpf.aarch64: E: spelling-error ('gui', '%description -l en_US gui -> GUI, goo, gun') mpf.aarch64: E: spelling-error ('frontend', '%description -l en_US frontend -> fronted, front end, front-end') mpf.aarch64: E: spelling-error ('subpackages', '%description -l en_US subpackages -> sub packages, sub-packages, prepackages') mpf.src: E: spelling-error ('cli', 'Summary(en_US) cli -> CLI, cl, clii') mpf.src: E: spelling-error ('gui', 'Summary(en_US) gui -> GUI, goo, gun') mpf.src: E: spelling-error ('cli', '%description -l en_US cli -> CLI, cl, clii') mpf.src: E: spelling-error ('orchestrator', '%description -l en_US orchestrator -> orchestra tor, orchestra-tor, orchestrate') mpf.src: E: spelling-error ('gui', '%description -l en_US gui -> GUI, goo, gun') mpf.src: E: spelling-error ('frontend', '%description -l en_US frontend -> fronted, front end, front-end') mpf.src: E: spelling-error ('subpackages', '%description -l en_US subpackages -> sub packages, sub-packages, prepackages') mpf-check.aarch64: E: spelling-error ('submissionInfo', 'Summary(en_US) submissionInfo -> submission Info, submission-info, submission') mpf-check.aarch64: E: spelling-error ('txt', 'Summary(en_US) txt -> text, ext, tit') mpf-check.aarch64: E: spelling-error ('submissionInfo', '%description -l en_US submissionInfo -> submission Info, submission-info, submission') mpf-check.aarch64: E: spelling-error ('txt', '%description -l en_US txt -> text, ext, tit') mpf-cli.aarch64: E: spelling-error ('orchestrator', 'Summary(en_US) orchestrator -> orchestra tor, orchestra-tor, orchestrate') mpf-cli.aarch64: E: spelling-error ('redumper', 'Summary(en_US) redumper -> re dumper, re-dumper, pumper') mpf-cli.aarch64: E: spelling-error ('aaru', 'Summary(en_US) aaru -> aura, arum') mpf-cli.aarch64: E: spelling-error ('discimagecreator', 'Summary(en_US) discimagecreator -> discriminatory') mpf-cli.aarch64: E: spelling-error ('redumper', '%description -l en_US redumper -> re dumper, re-dumper, pumper') mpf-cli.aarch64: E: spelling-error ('aaru', '%description -l en_US aaru -> aura, arum') mpf-cli.aarch64: E: spelling-error ('discimagecreator', '%description -l en_US discimagecreator -> discriminatory') mpf-cli.aarch64: E: spelling-error ('sys', '%description -l en_US sys -> says, sis, syn') mpf-cli.aarch64: E: spelling-error ('rawio', '%description -l en_US rawio -> ratio, radio') mpf-gui.aarch64: E: spelling-error ('Avalonia', 'Summary(en_US) Avalonia -> Avalon') mpf-gui.aarch64: E: spelling-error ('frontend', 'Summary(en_US) frontend -> fronted, front end, front-end') mpf-gui.aarch64: E: spelling-error ('Avalonia', '%description -l en_US Avalonia -> Avalon') mpf-gui.aarch64: E: spelling-error ('sys', '%description -l en_US sys -> says, sis, syn') mpf-gui.aarch64: E: spelling-error ('rawio', '%description -l en_US rawio -> ratio, radio') mpf-gui.aarch64: E: spelling-error ('dumpable', '%description -l en_US dumpable -> dump able, dump-able, impalpable') mpf-gui.aarch64: E: spelling-error ('xdg', '%description -l en_US xdg -> bldg') mpf-gui.aarch64: E: spelling-error ('natively', '%description -l en_US natively -> naively, negatively, tentatively') mpf.aarch64: W: no-documentation mpf.aarch64: E: no-binary mpf.spec: W: no-%check-section mpf-check.aarch64: W: manpage-not-compressed gz /usr/share/man/man1/mpf-check.1 mpf-cli.aarch64: W: manpage-not-compressed gz /usr/share/man/man1/mpf-cli.1 mpf-gui.aarch64: W: manpage-not-compressed gz /usr/share/man/man1/mpf-gui.1 mpf.spec: W: invalid-url Source0: MPF.Check_net10.0_linux-x64_release.zip mpf-check.aarch64: E: explicit-lib-dependency krb5-libs mpf-check.aarch64: E: explicit-lib-dependency libicu mpf-check.aarch64: E: explicit-lib-dependency libunwind mpf-check.aarch64: E: explicit-lib-dependency openssl-libs mpf-check.aarch64: E: explicit-lib-dependency zlib mpf-cli.aarch64: E: explicit-lib-dependency krb5-libs mpf-cli.aarch64: E: explicit-lib-dependency libicu mpf-cli.aarch64: E: explicit-lib-dependency libunwind mpf-cli.aarch64: E: explicit-lib-dependency openssl-libs mpf-cli.aarch64: E: explicit-lib-dependency zlib mpf-gui.aarch64: E: explicit-lib-dependency krb5-libs mpf-gui.aarch64: E: explicit-lib-dependency libicu mpf-gui.aarch64: E: explicit-lib-dependency libunwind mpf-gui.aarch64: E: explicit-lib-dependency openssl-libs mpf-gui.aarch64: E: explicit-lib-dependency zlib 5 packages and 0 specfiles checked; 51 errors, 6 warnings, 26 filtered, 51 badness; has taken 20.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "mpf-cli". (none): E: there is no installed rpm "mpf". (none): E: there is no installed rpm "mpf-gui". (none): E: there is no installed rpm "mpf-check". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/SabreTools/MPF/releases/download/rolling/MPF.CLI_net10.0_linux-x64_release.zip : CHECKSUM(SHA256) this package : e6472f306b8623be9973b7f0fd2b4ec68e278294c5b991df6156704a0ded135a CHECKSUM(SHA256) upstream package : e6472f306b8623be9973b7f0fd2b4ec68e278294c5b991df6156704a0ded135a https://github.com/SabreTools/MPF/releases/download/rolling/MPF.Avalonia_net10.0_linux-x64_release.zip : CHECKSUM(SHA256) this package : e7416bae856662dc755fbd0935e23229e5fd1ae1eb23ec4d05eccd1346945c08 CHECKSUM(SHA256) upstream package : e7416bae856662dc755fbd0935e23229e5fd1ae1eb23ec4d05eccd1346945c08 https://github.com/SabreTools/MPF/releases/download/rolling/MPF.Check_net10.0_linux-arm64_release.zip : CHECKSUM(SHA256) this package : 38d74715bdd1920ba93ee2b45321c15dd004f2e202e7c7cf96de35385259285d CHECKSUM(SHA256) upstream package : 38d74715bdd1920ba93ee2b45321c15dd004f2e202e7c7cf96de35385259285d https://github.com/SabreTools/MPF/releases/download/rolling/MPF.CLI_net10.0_linux-arm64_release.zip : CHECKSUM(SHA256) this package : b91be1c136abcc4c62647deb70fd28ce20ff81ffb19c56e96079b9cdc16b58af CHECKSUM(SHA256) upstream package : b91be1c136abcc4c62647deb70fd28ce20ff81ffb19c56e96079b9cdc16b58af https://github.com/SabreTools/MPF/releases/download/rolling/MPF.Avalonia_net10.0_linux-arm64_release.zip : CHECKSUM(SHA256) this package : d6e81a8759a9bd32d0fcb0a140a66628b04883b5ce48e461ccd7ace3c457fd1e CHECKSUM(SHA256) upstream package : d6e81a8759a9bd32d0fcb0a140a66628b04883b5ce48e461ccd7ace3c457fd1e Requires -------- mpf (rpmlib, GLIBC filtered): mpf-check mpf-cli mpf-gui mpf-check (rpmlib, GLIBC filtered): /bin/sh jq krb5-libs ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libicu libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libunwind openssl-libs rtld(GNU_HASH) zlib mpf-cli (rpmlib, GLIBC filtered): /bin/sh jq krb5-libs ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libicu libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libunwind openssl-libs rtld(GNU_HASH) zlib mpf-gui (rpmlib, GLIBC filtered): /bin/sh desktop-file-utils hicolor-icon-theme jq krb5-libs ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libicu libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libunwind openssl-libs rtld(GNU_HASH) zlib Provides -------- mpf: mpf mpf(aarch-64) mpf-check: mpf-check mpf-check(aarch-64) mpf-cli: mpf-cli mpf-cli(aarch-64) mpf-gui: application() application(mpf-gui.desktop) mpf-gui mpf-gui(aarch-64) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mpf --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-44-aarch64 Active plugins: Generic, Shell-api Disabled plugins: fonts, Python, R, Perl, SugarActivity, Haskell, PHP, Ocaml, C/C++, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH