This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/redhat-rpm-config, https://src.fedoraproject.org/tests/redhat-rpm-config See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/redhat-rpm-config/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr-rpmbuild/results/redhat-rpm- config/srpm-unpacked/redhat-rpm-config.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: redhat-rpm-config-266-1.fc40.noarch.rpm redhat-rpm-config-266-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpszpp0pqz')] checks: 31, packages: 2 redhat-rpm-config.noarch: W: only-non-binary-in-usr-lib redhat-rpm-config.noarch: W: one-line-command-in-%trigger /usr/lib/rpm/redhat/redhat-annobin-plugin-select.sh redhat-rpm-config.noarch: W: one-line-command-in-%trigger /usr/lib/rpm/redhat/redhat-annobin-plugin-select.sh redhat-rpm-config.noarch: W: obsolete-not-provided rpmautospec-rpm-macros redhat-rpm-config.spec: W: no-%build-section redhat-rpm-config.spec:734: W: macro-in-%changelog %_swidtagdir redhat-rpm-config.noarch: W: files-duplicate /usr/lib/rpm/redhat/redhat-annobin-select-annobin-built-plugin /usr/lib/rpm/redhat/redhat-annobin-cc1 2 packages and 0 specfiles checked; 0 errors, 7 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 redhat-rpm-config.noarch: W: only-non-binary-in-usr-lib redhat-rpm-config.noarch: W: one-line-command-in-%trigger /usr/lib/rpm/redhat/redhat-annobin-plugin-select.sh redhat-rpm-config.noarch: W: one-line-command-in-%trigger /usr/lib/rpm/redhat/redhat-annobin-plugin-select.sh redhat-rpm-config.noarch: W: obsolete-not-provided rpmautospec-rpm-macros redhat-rpm-config.noarch: W: files-duplicate /usr/lib/rpm/redhat/redhat-annobin-select-annobin-built-plugin /usr/lib/rpm/redhat/redhat-annobin-cc1 1 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://git.savannah.gnu.org/cgit/config.git/plain/config.sub : CHECKSUM(SHA256) this package : 4ca6a19995601877a120ad10d0d96e036dedab134b49b198bf30414c5f1fa18e CHECKSUM(SHA256) upstream package : 018d30ba55d0abc9ca18896e36d1cc0955bc778a6fd82ca6361704fe48b98804 https://git.savannah.gnu.org/cgit/config.git/plain/config.guess : CHECKSUM(SHA256) this package : 851148d33bbe0380794cc3002c32657cd1d32785d387b328299d71745376ec3e CHECKSUM(SHA256) upstream package : 810df8ff01d768a5f3dba7dc3c484f95b8e0d340a339f49ecfdd06b6ecfd2ca4 diff -r also reports differences Requires -------- redhat-rpm-config (rpmlib, GLIBC filtered): (annobin-plugin-gcc if gcc) (gcc-plugin-annobin if gcc) (llvm if clang) /bin/sh /usr/bin/bash /usr/bin/file /usr/bin/find /usr/bin/grep /usr/bin/sed /usr/bin/sh /usr/bin/xargs ansible-srpm-macros coreutils dwz efi-srpm-macros fonts-srpm-macros forge-srpm-macros fpc-srpm-macros ghc-srpm-macros gnat-srpm-macros go-srpm-macros kernel-srpm-macros lua-srpm-macros ocaml-srpm-macros openblas-srpm-macros package-notes-srpm-macros perl-srpm-macros pyproject-srpm-macros python-srpm-macros qt5-srpm-macros qt6-srpm-macros rpm rust-srpm-macros zip Provides -------- redhat-rpm-config: redhat-rpm-config rpm_macro(_dwz_limit) rpm_macro(_dwz_low_mem_die_limit) rpm_macro(_dwz_low_mem_die_limit_armv5tel) rpm_macro(_dwz_low_mem_die_limit_armv7hl) rpm_macro(_dwz_max_die_limit) rpm_macro(_dwz_max_die_limit_armv5tel) rpm_macro(_dwz_max_die_limit_armv7hl) rpm_macro(_dwz_max_die_limit_x86_64) rpm_macro(_find_debuginfo_dwz_opts) rpm_macro(_metainfodir) rpm_macro(_monodir) rpm_macro(_monogacdir) rpm_macro(_swidtagdir) rpm_macro(_vpath_builddir) rpm_macro(_vpath_srcdir) rpm_macro(autochangelog) rpm_macro(autorelease) rpm_macro(bash_completions_dir) rpm_macro(constrain_build) rpm_macro(fish_completions_dir) rpm_macro(gap_arches) rpm_macro(gpgverify) rpm_macro(java_arches) rpm_macro(ldc_arches) rpm_macro(ldconfig_post) rpm_macro(ldconfig_postun) rpm_macro(ldconfig_scriptlets) rpm_macro(limit_build) rpm_macro(listfiles) rpm_macro(mono_arches) rpm_macro(new_package) rpm_macro(nodejs_arches) rpm_macro(rpmmacrodir) rpm_macro(valgrind_arches) rpm_macro(wordwrap) rpm_macro(writevars) rpm_macro(zsh_completions_dir) system-rpm-config Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name redhat-rpm-config --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, SugarActivity, R, fonts, Python, Perl, PHP, C/C++, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH