This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/anki- bin/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mime, /usr/lib64/python3.12, /usr/lib64/python3.12/site-packages, /usr/share/mime/packages [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 887 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _qt_lib aqt, %define _cpython cp39, %define _glibc 28, %define _wheel_source 51/5f/6f52b958fe38a36a0799c01fbd56a742ebdfcf41f89438dbee998b8ce692, %define _glibc 31, %define _wheel_source df/bb/b0bfbc6a06a598b0b614d18dd8c4f40827828649f9742f1f44a4e44d6a2c, %define _pip_source https://files.pythonhosted.org/packages/, %define aqt_source 21/2a/d8e22a9521be04ef29a30d21a2c3008783ab03b6f07cc14696a040f747a4, %define anki_wheel %{_basename}-%{version}-%{_cpython}-abi3-manylinux_2_%{_glibc}_%{_arch}.whl, %define aqt_wheel %{_qt_lib}-%{version}-py3-none-any.whl [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: anki-bin-24.06.3-1.fc40.x86_64.rpm anki-bin-24.06.3-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0l5z2wom')] checks: 32, packages: 2 anki-bin.x86_64: W: unstripped-binary-or-object /usr/lib64/python3.12/site-packages/anki/_rsbridge.so anki-bin.src: W: summary-ended-with-dot Powerful, intelligent flash cards. anki-bin.x86_64: W: summary-ended-with-dot Powerful, intelligent flash cards. anki-bin.x86_64: W: python-leftover-require python3-flask anki-bin.x86_64: W: python-leftover-require python3-flask-cors anki-bin.x86_64: W: python-leftover-require python3-jsonschema anki-bin.x86_64: W: python-leftover-require python3-pip-system-certs anki-bin.x86_64: W: python-leftover-require python3-pyqt6-webengine anki-bin.x86_64: W: python-leftover-require python3-send2trash anki-bin.x86_64: W: python-leftover-require python3-waitress anki-bin.x86_64: W: python-leftover-require python3-decorator anki-bin.x86_64: W: python-leftover-require python3-distro anki-bin.x86_64: W: python-leftover-require python3-markdown anki-bin.x86_64: W: python-leftover-require python3-orjson anki-bin.x86_64: W: python-leftover-require python3-protobuf anki-bin.x86_64: E: files-duplicated-waste 309550 anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/imgs/media-record.png /usr/lib64/python3.12/site-packages/_aqt/data/qt/icons/media-record.png anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/pages/editable.css /usr/lib64/python3.12/site-packages/_aqt/data/web/css/editable.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_layout.11pzZHtD.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/0.11pzZHtD.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_layout.IueIF_dt.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/0.IueIF_dt.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_page.bbjb279y.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/2.bbjb279y.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_page.p-Cacfjz.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/2.p-Cacfjz.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_page.B5ccZEdE.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/4.B5ccZEdE.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_page.m6aFTiDT.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/4.m6aFTiDT.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_page.Qa4TP02F.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/6.Qa4TP02F.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_page.T9GipAsA.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/6.T9GipAsA.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_page.-Zxjqsu7.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/9.-Zxjqsu7.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/_page.fajENBT1.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/9.fajENBT1.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/Shortcut.NgnNDWaX.css /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/assets/IconConstrain.NgnNDWaX.css anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/nodes/0.GUmolNYp.mjs /usr/lib64/python3.12/site-packages/_aqt/data/web/sveltekit/_app/immutable/nodes/0.668JXiMn.mjs anki-bin.x86_64: W: files-duplicate /usr/lib64/python3.12/site-packages/aqt-24.06.3.dist-info/INSTALLER /usr/lib64/python3.12/site-packages/anki-24.06.3.dist-info/INSTALLER 2 packages and 0 specfiles checked; 1 errors, 30 warnings, 9 filtered, 1 badness; has taken 1.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "anki-bin". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- anki-bin: /usr/lib64/python3.12/site-packages/anki/_rsbridge.so Source checksums ---------------- https://github.com/ankitects/anki/raw/24.06.3/README.md : CHECKSUM(SHA256) this package : 754bd3c9b6dc68b26c0e49c59b28a07eaddfe0b5367fe807bdda7e92f0ad94fb CHECKSUM(SHA256) upstream package : 754bd3c9b6dc68b26c0e49c59b28a07eaddfe0b5367fe807bdda7e92f0ad94fb https://github.com/ankitects/anki/raw/24.06.3/LICENSE : CHECKSUM(SHA256) this package : db0a8d3e19f7f7f5fca72a4a70ea1fb7bad57b7b1bb21c7de132a9e00617fed7 CHECKSUM(SHA256) upstream package : db0a8d3e19f7f7f5fca72a4a70ea1fb7bad57b7b1bb21c7de132a9e00617fed7 https://github.com/ankitects/anki/raw/24.06.3/qt/bundle/lin/anki.xpm : CHECKSUM(SHA256) this package : d814c62e38246b6e4ba73ee037647a29675925167518137f05a8f9e60c258b6e CHECKSUM(SHA256) upstream package : d814c62e38246b6e4ba73ee037647a29675925167518137f05a8f9e60c258b6e https://github.com/ankitects/anki/raw/24.06.3/qt/bundle/lin/anki.png : CHECKSUM(SHA256) this package : 97ad2134ef1a7686789c7becd8bd05dd8693cf0d3127951ca6ba7b29a80b402a CHECKSUM(SHA256) upstream package : 97ad2134ef1a7686789c7becd8bd05dd8693cf0d3127951ca6ba7b29a80b402a https://github.com/ankitects/anki/raw/24.06.3/qt/bundle/lin/anki.xml : CHECKSUM(SHA256) this package : 2845a528fb3a064b67404a03d72bfaba9b421cb220b25228b815946c6553ce38 CHECKSUM(SHA256) upstream package : 2845a528fb3a064b67404a03d72bfaba9b421cb220b25228b815946c6553ce38 https://github.com/ankitects/anki/raw/24.06.3/qt/bundle/lin/anki.1 : CHECKSUM(SHA256) this package : 8b9fec8fdf2897b4722f8cee169e9fb1e46cee90d3fb03ee12587e30c2f5dad7 CHECKSUM(SHA256) upstream package : 8b9fec8fdf2897b4722f8cee169e9fb1e46cee90d3fb03ee12587e30c2f5dad7 https://github.com/ankitects/anki/raw/24.06.3/qt/bundle/lin/anki.desktop : CHECKSUM(SHA256) this package : 3829ce614aaea9eb1e57abf4c269647cc87ccc6d4755c3b2563ce44e30992ae2 CHECKSUM(SHA256) upstream package : 3829ce614aaea9eb1e57abf4c269647cc87ccc6d4755c3b2563ce44e30992ae2 https://github.com/ankitects/anki/raw/24.06.3/qt/runanki.py : CHECKSUM(SHA256) this package : 9648e7e915f51f08e05c48ef5f39b4015922fe1cf3d7f2895535ef10ef4507ae CHECKSUM(SHA256) upstream package : 9648e7e915f51f08e05c48ef5f39b4015922fe1cf3d7f2895535ef10ef4507ae https://files.pythonhosted.org/packages/21/2a/d8e22a9521be04ef29a30d21a2c3008783ab03b6f07cc14696a040f747a4/aqt-24.06.3-py3-none-any.whl : CHECKSUM(SHA256) this package : 6c6638b861544555f39dd16f72d99100fad0aab2a6fa6b40f6bd7349693271a7 CHECKSUM(SHA256) upstream package : 6c6638b861544555f39dd16f72d99100fad0aab2a6fa6b40f6bd7349693271a7 https://files.pythonhosted.org/packages/51/5f/6f52b958fe38a36a0799c01fbd56a742ebdfcf41f89438dbee998b8ce692/anki-24.06.3-cp39-abi3-manylinux_2_28_x86_64.whl : CHECKSUM(SHA256) this package : e03959487c5664db136ec7809d864d03141a3ce356d4b6354ceeb7dd5b8c9d37 CHECKSUM(SHA256) upstream package : e03959487c5664db136ec7809d864d03141a3ce356d4b6354ceeb7dd5b8c9d37 Requires -------- anki-bin (rpmlib, GLIBC filtered): /usr/bin/python3 hicolor-icon-theme ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) python(abi) python3-beautifulsoup4 python3-decorator python3-distro python3-flask python3-flask-cors python3-jsonschema python3-markdown python3-orjson python3-pip-system-certs python3-protobuf python3-pyqt6-webengine python3-requests python3-send2trash python3-waitress python3.12dist(anki) python3.12dist(beautifulsoup4) python3.12dist(decorator) python3.12dist(distro) python3.12dist(flask) python3.12dist(flask-cors) python3.12dist(jsonschema) python3.12dist(markdown) python3.12dist(orjson) python3.12dist(pip-system-certs) python3.12dist(protobuf) python3.12dist(requests) python3.12dist(requests[socks]) python3.12dist(send2trash) python3.12dist(waitress) qt6-qtsvg qt6-qtwebengine rtld(GNU_HASH) sox Provides -------- anki-bin: anki anki-bin anki-bin(x86-64) application() application(anki.desktop) mimehandler(application/x-anki) mimehandler(application/x-ankiaddon) mimehandler(application/x-apkg) python3-anki python3-aqt python3.12dist(anki) python3.12dist(aqt) python3dist(anki) python3dist(aqt) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name anki-bin --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-40-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Java, R, Ocaml, SugarActivity, Perl, Haskell, C/C++, PHP, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH