This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 6 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/nebula-overlay-networking/licensecheck.txt [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in nebula-overlay-networking [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8060 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nebula-overlay-networking-1.10.0-1.fc44.x86_64.rpm nebula-overlay-networking-1.10.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp3yeefgpx')] checks: 32, packages: 2 nebula-overlay-networking.x86_64: W: unstripped-binary-or-object /usr/bin/nebula nebula-overlay-networking.x86_64: W: unstripped-binary-or-object /usr/bin/nebula-cert nebula-overlay-networking.x86_64: E: statically-linked-binary /usr/bin/nebula nebula-overlay-networking.x86_64: E: statically-linked-binary /usr/bin/nebula-cert nebula-overlay-networking.spec:85: W: shared-dir-glob-in-files %{_bindir}/* nebula-overlay-networking.x86_64: W: position-independent-executable-suggested /usr/bin/nebula nebula-overlay-networking.x86_64: W: position-independent-executable-suggested /usr/bin/nebula-cert nebula-overlay-networking.x86_64: W: no-manual-page-for-binary nebula nebula-overlay-networking.x86_64: W: no-manual-page-for-binary nebula-cert nebula-overlay-networking.spec: W: no-%check-section nebula-overlay-networking.spec:61: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 61) 2 packages and 0 specfiles checked; 2 errors, 9 warnings, 11 filtered, 2 badness; has taken 1.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "nebula-overlay-networking". There are no files to process nor additional arguments. Nothing to do, aborting. Source checksums ---------------- https://github.com/slackhq/nebula/raw/v1.10.0/README.md : CHECKSUM(SHA256) this package : 93c85dda367a1675345db0e7339d8bef1a26fa0d4a84c3df38d742e9ad4ee74e CHECKSUM(SHA256) upstream package : 93c85dda367a1675345db0e7339d8bef1a26fa0d4a84c3df38d742e9ad4ee74e https://github.com/slackhq/nebula/raw/v1.10.0/examples/service_scripts/nebula.service : CHECKSUM(SHA256) this package : 085e5d62d8e52526b9b6bb84f969726602b3bf4c427c2d8ec65fc4a2d47dd41a CHECKSUM(SHA256) upstream package : 085e5d62d8e52526b9b6bb84f969726602b3bf4c427c2d8ec65fc4a2d47dd41a https://github.com/slackhq/nebula/raw/v1.10.0/LICENSE : CHECKSUM(SHA256) this package : aefd0cce553f24945ce1c692c3c4f9fda581f078ba82977845715cd18565b3bd CHECKSUM(SHA256) upstream package : aefd0cce553f24945ce1c692c3c4f9fda581f078ba82977845715cd18565b3bd https://github.com/slackhq/nebula/raw/v1.10.0/examples/config.yml : CHECKSUM(SHA256) this package : 4f8d564b8e2d34944ab25e77838e46e436d013b28f709fa0e6be69faee7e096c CHECKSUM(SHA256) upstream package : 4f8d564b8e2d34944ab25e77838e46e436d013b28f709fa0e6be69faee7e096c https://github.com/slackhq/nebula/releases/download/v1.10.0/nebula-linux-amd64.tar.gz : CHECKSUM(SHA256) this package : 79bf98683091cceeab6333626ca6068a1f26fb34238147231c6aa5f1b73e5e23 CHECKSUM(SHA256) upstream package : 79bf98683091cceeab6333626ca6068a1f26fb34238147231c6aa5f1b73e5e23 Requires -------- nebula-overlay-networking (rpmlib, GLIBC filtered): /bin/sh config(nebula-overlay-networking) firewalld Provides -------- nebula-overlay-networking: config(nebula-overlay-networking) nebula-overlay-networking nebula-overlay-networking(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nebula-overlay-networking --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, C/C++, fonts, Java, Perl, PHP, Ocaml, Python, R, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH