This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'ASL 2.0'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0". 142 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/samba-exporter/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /lib/systemd, /usr/share/doc/samba-exporter, /usr/share/doc/samba-exporter/docs/Installation, /usr/share/doc/samba- exporter/grafana, /lib, /usr/share/man/man1, /etc/default, /usr/share/doc/samba-exporter/docs, /usr/share/doc/samba- exporter/docs/assets, /usr/share/doc, /usr/share/man, /usr/lib, /usr/share/doc/samba-exporter/docs/UserDocs, /etc, /usr/share/doc/samba-exporter/docs/DeveloperDocs, /lib/systemd/system, /usr/bin, /usr [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/bin, /usr/share/doc/samba-exporter/docs/DeveloperDocs, /etc/default, /usr/share/doc/samba-exporter/docs, /usr/share/doc/samba- exporter/docs/assets, /usr, /usr/share/doc, /usr/share/man/man1, /usr/share/man, /lib/systemd, /lib/systemd/system, /usr/lib, /usr/share/doc/samba-exporter/docs/UserDocs, /etc, /usr/share/doc/samba-exporter, /usr/share/doc/samba- exporter/docs/Installation, /usr/share/doc/samba-exporter/grafana, /lib [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 244407 bytes in 14 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Package uses hardened build flags if required to. Note: Systemd files (daemon?): samba_exporter.service, samba_statusd.service [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _rpmfilename %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm, %define _unpackaged_files_terminate_build 0 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: samba-exporter-1.34.2-1.fc40.x86_64.rpm samba-exporter-1.34.2-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpl00fiivn')] checks: 32, packages: 2 samba-exporter.x86_64: E: standard-dir-owned-by-package /usr/share samba-exporter.src: E: spelling-error ('prometheus', '%description -l en_US prometheus -> Prometheus, promethium') samba-exporter.src: E: spelling-error ('smbstatus', '%description -l en_US smbstatus -> status') samba-exporter.x86_64: E: spelling-error ('prometheus', '%description -l en_US prometheus -> Prometheus, promethium') samba-exporter.x86_64: E: spelling-error ('smbstatus', '%description -l en_US smbstatus -> status') samba-exporter.x86_64: E: non-standard-executable-perm /usr/bin/samba_exporter 775 samba-exporter.x86_64: E: non-standard-executable-perm /usr/bin/samba_statusd 775 samba-exporter.x86_64: E: non-standard-executable-perm /usr/bin/start_samba_statusd 775 samba-exporter.spec:24: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 24) samba-exporter.x86_64: W: incoherent-version-in-changelog 1.34.2 ['1.34.2-1.fc40', '1.34.2-1'] samba-exporter.x86_64: W: dangerous-command-in-%preun rm samba-exporter.x86_64: W: dangerous-command-in-%postun rm 2 packages and 0 specfiles checked; 8 errors, 4 warnings, 7 filtered, 8 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "samba-exporter". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/imker25/samba_exporter/archive/refs/tags/1.34.2.tar.gz : CHECKSUM(SHA256) this package : 5f885338a11dc0afbb7a704e34f483f1fa86f62840d46243a6420738e2fd40a2 CHECKSUM(SHA256) upstream package : 5f885338a11dc0afbb7a704e34f483f1fa86f62840d46243a6420738e2fd40a2 Requires -------- samba-exporter (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash binutils config(samba-exporter) filesystem libc.so.6()(64bit) man-db procps-ng rtld(GNU_HASH) samba systemd Provides -------- samba-exporter: config(samba-exporter) samba-exporter samba-exporter(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name samba-exporter --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-40-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, fonts, PHP, Ocaml, C/C++, SugarActivity, Perl, Java, Haskell, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH