This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "Q Public License 1.0", "*No copyright* Q Public License 1.0", "GNU General Public License v3.0 or later", "NTP License [generated file]", "Q Public License 1.0 GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "Q Public License 1.0 GNU General Public License, Version 2 [generated file]". 86 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/objfw/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/ofhttp/lang, /usr/share/ofdns/lang, /usr/share/ofarc, /usr/share/ofhash/lang, /usr/include/ObjFWTLS, /usr/share/ofdns, /usr/share/ofhttp, /usr/share/ofarc/lang, /usr/include/ObjFWRT, /usr/share/ofhash [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/ofdns/lang, /usr/include/ObjFWTLS, /usr/share/ofhttp/lang, /usr/share/ofdns, /usr/share/ofhttp, /usr/share/ofarc, /usr/share/ofarc/lang, /usr/include/ObjFWRT, /usr/share/ofhash, /usr/share/ofhash/lang [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libobjfw , libobjfwrt , libobjfwrt-devel , libobjfwtls , libobjfwtls-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: objfw-1.1dev-1.fc35.i686.rpm libobjfw-1.1dev-1.fc35.i686.rpm libobjfw-devel-1.1dev-1.fc35.i686.rpm libobjfwrt-1.1dev-1.fc35.i686.rpm libobjfwrt-devel-1.1dev-1.fc35.i686.rpm libobjfwtls-1.1dev-1.fc35.i686.rpm libobjfwtls-devel-1.1dev-1.fc35.i686.rpm ofarc-1.1dev-1.fc35.i686.rpm ofdns-1.1dev-1.fc35.i686.rpm ofhash-1.1dev-1.fc35.i686.rpm ofhttp-1.1dev-1.fc35.i686.rpm objfw-debuginfo-1.1dev-1.fc35.i686.rpm objfw-debugsource-1.1dev-1.fc35.i686.rpm objfw-1.1dev-1.fc35.src.rpm objfw.i686: E: devel-dependency libobjfw-devel objfw.i686: E: no-changelogname-tag objfw.i686: E: no-binary objfw.i686: W: no-documentation libobjfw.i686: E: no-changelogname-tag libobjfw.i686: W: shared-lib-calls-exit /usr/lib/libobjfw.so.0.0.0 exit@GLIBC_2.0 libobjfw.i686: W: no-documentation libobjfw-devel.i686: E: no-changelogname-tag libobjfw-devel.i686: W: no-documentation libobjfw-devel.i686: E: rpath-in-buildconfig /usr/bin/objfw-config lines ['69'] libobjfw-devel.i686: W: no-manual-page-for-binary objfw-compile libobjfw-devel.i686: W: no-manual-page-for-binary objfw-config libobjfw-devel.i686: W: no-manual-page-for-binary objfw-new libobjfwrt.i686: E: no-changelogname-tag libobjfwrt.i686: W: no-documentation libobjfwrt-devel.i686: E: no-changelogname-tag libobjfwrt-devel.i686: W: no-documentation libobjfwtls.i686: E: no-changelogname-tag libobjfwtls.i686: W: no-documentation libobjfwtls-devel.i686: E: no-changelogname-tag libobjfwtls-devel.i686: W: no-documentation ofarc.i686: E: no-changelogname-tag ofarc.i686: W: no-documentation ofarc.i686: W: no-manual-page-for-binary ofarc ofdns.i686: E: no-changelogname-tag ofdns.i686: W: no-documentation ofdns.i686: W: no-manual-page-for-binary ofdns ofhash.i686: E: no-changelogname-tag ofhash.i686: W: no-documentation ofhash.i686: W: no-manual-page-for-binary ofhash ofhttp.i686: W: spelling-error Summary(en_US) downloader -> downloaded, down loader, down-loader ofhttp.i686: W: spelling-error %description -l en_US downloader -> downloaded, down loader, down-loader ofhttp.i686: E: no-changelogname-tag ofhttp.i686: W: no-documentation ofhttp.i686: W: no-manual-page-for-binary ofhttp objfw-debuginfo.i686: E: no-changelogname-tag objfw-debugsource.i686: E: no-changelogname-tag objfw.src: E: no-changelogname-tag objfw.src: W: invalid-url Source0: objfw-1.1dev.tar.gz 14 packages and 0 specfiles checked; 17 errors, 22 warnings. Rpmlint (debuginfo) ------------------- Checking: objfw-debuginfo-1.1dev-1.fc35.i686.rpm objfw-debuginfo.i686: E: no-changelogname-tag 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- objfw (rpmlib, GLIBC filtered): libobjfw(x86-32) libobjfw-devel libobjfwrt(x86-32) libobjfwrt-devel ofarc(x86-32) ofdns(x86-32) ofhash(x86-32) ofhttp(x86-32) libobjfw (rpmlib, GLIBC filtered): ld-linux.so.2 libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_3.3) libm.so.6 libobjfwrt(x86-32) libobjfwrt.so.0 rtld(GNU_HASH) libobjfw-devel (rpmlib, GLIBC filtered): /usr/bin/sh libobjfw(x86-32) libobjfw.so.0 libobjfwrt-devel libobjfwrt (rpmlib, GLIBC filtered): ld-linux.so.2 libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) rtld(GNU_HASH) libobjfwrt-devel (rpmlib, GLIBC filtered): libobjfwrt(x86-32) libobjfwrt.so.0 libobjfwtls (rpmlib, GLIBC filtered): gnutls(x86-32) libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgnutls.so.30 libgnutls.so.30(GNUTLS_3_4) libobjfw.so.0 libobjfwrt.so.0 rtld(GNU_HASH) libobjfwtls-devel (rpmlib, GLIBC filtered): libobjfwtls(x86-32) libobjfwtls.so.0 ofarc (rpmlib, GLIBC filtered): libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libobjfw(x86-32) libobjfw.so.0 libobjfwrt(x86-32) libobjfwrt.so.0 rtld(GNU_HASH) ofdns (rpmlib, GLIBC filtered): libc.so.6 libobjfw(x86-32) libobjfw.so.0 libobjfwrt(x86-32) libobjfwrt.so.0 rtld(GNU_HASH) ofhash (rpmlib, GLIBC filtered): libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libobjfw(x86-32) libobjfw.so.0 libobjfwrt(x86-32) libobjfwrt.so.0 rtld(GNU_HASH) ofhttp (rpmlib, GLIBC filtered): libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libobjfw(x86-32) libobjfw.so.0 libobjfwrt(x86-32) libobjfwrt.so.0 libobjfwtls(x86-32) libobjfwtls.so.0 rtld(GNU_HASH) objfw-debuginfo (rpmlib, GLIBC filtered): objfw-debugsource (rpmlib, GLIBC filtered): Provides -------- objfw: objfw objfw(x86-32) libobjfw: libobjfw libobjfw(x86-32) libobjfw.so.0 libobjfw-devel: libobjfw-devel libobjfw-devel(x86-32) libobjfwrt: libobjfwrt libobjfwrt(x86-32) libobjfwrt.so.0 libobjfwrt-devel: libobjfwrt-devel libobjfwrt-devel(x86-32) libobjfwtls: libobjfwtls libobjfwtls(x86-32) libobjfwtls.so.0 libobjfwtls-devel: libobjfwtls-devel libobjfwtls-devel(x86-32) ofarc: ofarc ofarc(x86-32) ofdns: ofdns ofdns(x86-32) ofhash: ofhash ofhash(x86-32) ofhttp: ofhttp ofhttp(x86-32) objfw-debuginfo: objfw-debuginfo objfw-debuginfo(x86-32) objfw-debugsource: objfw-debugsource objfw-debugsource(x86-32) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name objfw --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-35-i686 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, PHP, Java, fonts, Haskell, Ocaml, Python, Perl, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH