This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Dist tag is present. - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in forgejo See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License", "MIT License", "Apache License 2.0 and/or BSD 3-Clause License and/or MIT License", "*No copyright* MIT License", "MIT License [generated file]", "Apache License 2.0", "*No copyright* BSD 0-Clause License", "*No copyright* GNU General Public License, Version 2 [obsolete FSF postal address (Temple Place)]", "Attribution Assurance License", "Amazon Digital Services License", "Academic Free License v1.1", "Academic Free License v1.2", "Academic Free License v2.0", "Academic Free License v2.1", "Academic Free License v3.0", "Affero General Public License v1.0", "GNU Affero General Public License v3.0", "AMD's plpa_map.c License", "Apple MIT License", "Academy of Motion Picture Arts and Sciences BSD", "*No copyright* ANTLR Software Rights Notice", "ANTLR Software Rights Notice", "Adobe Postscript AFM License", "Adaptive Public License 1.0", "Apple Public Source License 1.0", "Apple Public Source License 1.1", "*No copyright* Apple Public Source License 1.2", "Apple Public Source License 2.0", "Abstyles License", "Adobe Systems Incorporated Source Code License Agreement", "Adobe Glyph List License", "Afmparse License", "Aladdin Free Public License, Version 8", "Apache License 1.0", "Apache License 1.1", "*No copyright* Apache License 2.0", "*No copyright* Artistic License 1.0", "*No copyright* Artistic License 1.0 (Perl)", "*No copyright* Artistic-1.0-cl8", "GNU General Public License, Version 3", "*No copyright* BSD 1-Clause License", "*No copyright* BSD 2-Clause License", "*No copyright* BSD 2-Clause Plus Patent License", "*No copyright* BSD 2-Clause with views sentence", "*No copyright* BSD 3-Clause License", "*No copyright* Apache License 1.0 and/or BSD 3-Clause License", "BSD 3-Clause License and/or Lawrence Berkeley National Labs BSD variant license", "*No copyright* BSD 3-Clause Modification", "*No copyright* BSD 3-Clause No Military License", "BSD 3-Clause No Nuclear License", "BSD 3-Clause License", "BSD 3-Clause No Nuclear Warranty", "*No copyright* BSD 4-Clause License", "BSD-4-Clause (University of California-Specific)", "NTP License", "Apache License 1.0 and/or BSD 4-Clause License", "Apache License 1.0 and/or BSD 3-Clause License", "BSD 4-Clause License", "*No copyright* BSD Protection License and/or GNU General Public License", "*No copyright* Boost Software License 1.0", "Bahyph License", "*No copyright* Barr License", "*No copyright* Beerware License", "*No copyright* GNU General Public License", "*No copyright* BitTorrent Open Source License v1.0", "*No copyright* BitTorrent Open Source License v1.1", "*No copyright* Boehm GC License", "Borceux license", "CMU License and/or GNU General Public License", "*No copyright* Cryptographic Autonomy License 1.0", "Computer Associates Trusted Open Source License 1.1", "Creative Commons Attribution 1.0 Generic", "*No copyright* Creative Commons Attribution 2.0", "*No copyright* Creative Commons Attribution 2.5", "Creative Commons Attribution 3.0", "Creative Commons Attribution 4.0", "Creative Commons Attribution-NonCommercial 1.0", "*No copyright* Creative Commons Attribution-NonCommercial 2.0", "*No copyright* Creative Commons Attribution-NonCommercial 2.5", "Creative Commons Attribution- NonCommercial 3.0", "Creative Commons Attribution-NonCommercial 4.0", "Creative Commons Attribution-NoDerivs-NonCommercial 1.0", "*No copyright* Creative Commons Attribution-NonCommercial-NoDerivs 2.0", "*No copyright* Creative Commons Attribution-NonCommercial-NoDerivs 2.5", "Creative Commons Attribution-NonCommercial-NoDerivs 3.0", "Creative Commons Attribution-NonCommercial-NoDerivatives 4.0", "Creative Commons Attribution-NonCommercial-ShareAlike 1.0", "*No copyright* Creative Commons Attribution-NonCommercial-ShareAlike 2.0", "*No copyright* Creative Commons Attribution-NonCommercial-ShareAlike 2.5", "Creative Commons Attribution-NonCommercial-ShareAlike 3.0", "Creative Commons Attribution-NonCommercial-ShareAlike 4.0", "Creative Commons Attribution-NoDerivs 1.0", "*No copyright* Creative Commons Attribution-NoDerivs 2.0", "*No copyright* Creative Commons Attribution-NoDerivs 2.5", "Creative Commons Attribution-NoDerivs 3.0", "Creative Commons Attribution-NoDerivatives 4.0", "Creative Commons Attribution-ShareAlike 1.0", "*No copyright* Creative Commons Attribution-ShareAlike 2.0", "*No copyright* Creative Commons Attribution-ShareAlike 2.5", "Creative Commons Attribution-ShareAlike 3.0", "Creative Commons Attribution-ShareAlike 4.0", "Creative Commons Public Domain Dedication and Certification and/or Public domain", "*No copyright* Creative Commons CC0 1.0", "*No copyright* CeCILL Free Software License Agreement v1.0", "*No copyright* CeCILL Free Software License Agreement v1.1", "*No copyright* CeCILL Free Software License Agreement v2.0", "*No copyright* CeCILL Free Software License Agreement v2.1", "*No copyright* CeCILL-B Free Software License Agreement v1.0", "*No copyright* CeCILL-C Free Software License Agreement v1.0", "GNU General Public License, Version 2", "CNRI Jython License", "*No copyright* CNRI Python License", "CNRI Python Open Source GPL Compatible License Agreement", "*No copyright* Common Public Attribution License 1.0", "Common Public License 1.0", "*No copyright* Code Project Open License 1.02", "*No copyright* CUA Office Public License v1.0", "Caldera License", "*No copyright* Clarified Artistic License", "*No copyright* MIT No Attribution", "Condor Public License v1.1", "Cube License", "Deutsche Freie Software Lizenz 1.0", "DSDP License", "*No copyright* Educational Community License, Version 1.0", "*No copyright* Educational Community License, Version 2.0", "*No copyright* Eiffel Forum License v1.0", "*No copyright* Eiffel Forum License v2.0", "Eclipse Public License 1.0", "Eclipse Public License 2.0", "EU DataGrid Software License", "European Union Public License, Version 1.0", "European Union Public License, Version 1.1", "European Union Public License, Version 1.2", "Apache License 1.1 and/or Entessa Public License v1.0", "*No copyright* Erlang Public License v1.1", "Eurosym License", "*No copyright* GNU Lesser General Public License", "*No copyright* FSF All Permissive License", "FSF All Permissive License", "FSF Unlimited License", "FSF Unlimited License (with License Retention)", "Freetype Project License", "*No copyright* Fair License", "GNU General Public License", "Frameworx Open License 1.0", "*No copyright* Public domain", "GNU Free Documentation License v1.1", "GNU Free Documentation License v1.2", "GNU Free Documentation License v1.3", "3dfx Glide License", "mit_osf", "*No copyright* NTP License (legal disclaimer)", "Kevlin Henney License", "*No copyright* NTP License", "Historical Permission Notice and Disclaimer - sell variant", "MIT Open Group variant", "*No copyright* libpng License", "IBM PowerPC Initialization and Boot Software", "ICU License", "*No copyright* IPA Font License", "*No copyright* IBM Public License v1.0", "ISC License", "*No copyright* Imlib2 License and/or enna License", "Intel Open Source License", "JSON License and/or MIT License", "GNU Library General Public License, Version 2.0", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License, Version 3", "GNU Lesser General Public License", "*No copyright* GNU General Public License, Version 2", "Historical Permission Notice and Disclaimer and/or NTP License", "Lucent Public License Version 1.0", "Lucent Public License v1.02", "LaTeX Project Public License 1", "LaTeX Project Public License 1.1", "LaTeX Project Public License 1.2", "LaTeX Project Public License 1.3a", "LaTeX Project Public License 1.3c", "*No copyright* Common Public License 1.0", "Leptonica License", "*No copyright* Licence Libre du Québec – Permissive version 1.1", "*No copyright* Licence Libre du Québec – Réciprocité version 1.1", "*No copyright* Licence Libre du Québec – Réciprocité forte version 1.1", "libpng License", "*No copyright* Festival", "Khronos License", "*No copyright* MIT (old)", "Enlightenment License (e16)", "enna License", "*No copyright* feh License", "*No copyright* MIT Open Group variant", "*No copyright* Mozilla Public License 1.0", "*No copyright* Mozilla Public License 1.1", "*No copyright* Mozilla Public License 2.0", "Microsoft Public License", "Microsoft Reciprocal License", "*No copyright* Apache License 1.1", "*No copyright* The MirOS License", "*No copyright* Motosoto License", "Mulan Permissive Software License, Version 1", "*No copyright* Mulan Permissive Software License, Version 2", "Multics License", "NASA Open Source Agreement 1.3", "Net Boolean Public License v1", "*No copyright* University of Illinois/NCSA Open Source License", "Nethack General Public License", "Public domain", "*No copyright* Netizen Open Source License 1.0", "*No copyright* Netscape Public License v1.0", "Mozilla Public License 1.1 and/or Netscape Public License v1.1", "Non-Profit Open Software License 3.0", "Naumen Public License", "BSD 3-Clause License and/or CMU License", "*No copyright* Nokia Open Source License", "OCLC Research Public License 2.0", "*No copyright* Open Data Commons Attribution License v1.0", "ODC Open Database License v1.0", "*No copyright* SIL Open Font License 1.0", "*No copyright* SIL Open Font License 1.1", "*No copyright* OGC Software License, Version 1.0", "*No copyright* Open Group Test Suite License", "Open LDAP Public License v1.1", "Open LDAP Public License v1.2", "Open LDAP Public License v1.3", "Open LDAP Public License v1.4", "Open LDAP Public License v2", "Open LDAP Public License v2.0.1", "Open LDAP Public License v2.1", "Open LDAP Public License v2.2", "Open LDAP Public License v2.2.1", "Open LDAP Public License 2.2.2", "Open LDAP Public License v2.3", "Open LDAP Public License v2.4", "Open LDAP Public License v2.5", "Open LDAP Public License v2.6", "Open LDAP Public License v2.7", "Open LDAP Public License v2.8", "*No copyright* Open Public License v1.0", "OSET Public License version 2.1", "Open Software License 1.0", "Open Software License 1.1", "Open Software License 2.0", "Open Software License 2.1", "Open Software License 3.0", "OpenSSL License and/or SSLeay", "OpenSSL License", "mit_openvision", "PHP License v3.0", "PHP License v3.01", "*No copyright* GNU Affero General Public License v3.0", "Python Software Foundation License 2.0", "PostgreSQL License", "Python License 2.0", "Q Public License 1.0", "*No copyright* Red Hat eCos Public License v1.1", "Reciprocal Public License 1.1", "Reciprocal Public License 1.5", "RealNetworks Public Source License v1.0", "Ricoh Source Code Public License", "*No copyright* Ruby License", "Public domain and/or Sax Public Domain Notice", "SGI Free Software License B v1.0", "*No copyright* SGI Free Software License B v1.1", "SGI Free Software License B v2.0", "*No copyright* Apache License", "*No copyright* Sun Industry Standards Source License v1.1", "*No copyright* Sun Industry Standards Source License v1.2", "Standard ML of New Jersey License", "*No copyright* Sun Public License v1.0", "SSLeay", "*No copyright* Simple Public License 2.0", "BSD 3-Clause License and/or Sleepycat License", "*No copyright* SugarCRM Public License v1.1.3", "Trusster Open Source License", "*No copyright* GNU General Public License v2.0 or later", "Upstream Compatibility License v. 1.0", "Universal Permissive License v1.0", "Unicode License Agreement - Data Files and Software (2016)", "Unicode License Agreement - Data Files and Software (2015)", "Unicode Terms of Use", "mit_unixcrypt", "*No copyright* The Unlicense", "BSD 3-Clause License and/or Vovida Software License v1.0", "*No copyright* W3C Software Notice and License (2002-12-31)", "W3C Software Notice and License (1998-07-20)", "*No copyright* W3C Software and Document Notice and License (2015-05-13)", "Do What The Fuck You Want To Public License, Version 2", "Sybase Open Watcom Public License 1.0", "mit_widget", "X11 License", "University of Illinois/NCSA Open Source License and/or XFree86 License 1.1", "*No copyright* mit_xfig", "MIT License and/or X.Net License", "Zope Public License 2.0", "*No copyright* Zope Public License 2.1", "Zed License", "Zend License v2.0", "*No copyright* Zimbra Public License v1.3", "*No copyright* Zimbra Public License v1.4", "*No copyright* zlib License", "bzip2 and libbzip2 License v1.0.6", "curl License", "*No copyright* GNU General Public License and/or eCos license version 2.0", "*No copyright* gSOAP Public License v1.3b", "libtiff License", "*No copyright* mpich2 License", "zlib/libpng License with Acknowledgement", "BSD 1-Clause License", "Apache License 2.0 and/or MIT License", "Apache License 2.0 and/or BSD 3-Clause License", "BSD 2-Clause License and/or ISC License", "Mozilla Public License 2.0", "Apache License 2.0 and/or Creative Commons Attribution 4.0", "BSD 3-Clause License and/or ISC License". 9598 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/forgejo/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc, /usr/lib/systemd, /usr, /usr/share, /var, /var/lib, /usr/share/licenses, /usr/lib/systemd/system, /usr/share/doc, /usr/lib, /usr/bin, /usr/lib/sysusers.d [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc, /usr/lib/systemd, /usr, /usr/share, /var, /var/lib, /usr/share/licenses, /usr/lib/systemd/system, /usr/share/doc, /usr/lib, /usr/bin, /usr/lib/sysusers.d [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /var/lib/copr- rpmbuild/results/forgejo/upstream-unpacked/Source0/forgejo- src-7.0.3/vendor/github.com/ClickHouse/clickhouse-go/v2/ext, /var/lib/copr-rpmbuild/results/forgejo/upstream- unpacked/Source0/forgejo-src-7.0.3/modules/markup/external [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2573 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua:, %define forgejo_arch amd64, %define forgejo_arch %{_arch}, %define _build_id_links none [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: forgejo-7.0.3-1.fc39.x86_64.rpm forgejo-7.0.3-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpv5jdzfqr')] checks: 32, packages: 2 forgejo.x86_64: E: statically-linked-binary /usr/bin/forgejo forgejo.x86_64: W: position-independent-executable-suggested /usr/bin/forgejo forgejo.x86_64: W: non-standard-uid /var/lib/forgejo git forgejo.x86_64: W: non-standard-gid /etc/forgejo git forgejo.x86_64: W: non-standard-gid /var/lib/forgejo git forgejo.x86_64: E: non-standard-dir-perm /etc/forgejo 770 forgejo.x86_64: E: non-standard-dir-perm /var/lib/forgejo 750 forgejo.x86_64: W: no-manual-page-for-binary forgejo 2 packages and 0 specfiles checked; 3 errors, 5 warnings, 7 filtered, 3 badness; has taken 1.8 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "forgejo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://codeberg.org/forgejo/forgejo/releases/download/v7.0.3/forgejo-7.0.3-linux-amd64.xz : CHECKSUM(SHA256) this package : 989fea2973152cc3e566b26bd0d0bc9b4731e97c28d40942b379a03351d19a10 CHECKSUM(SHA256) upstream package : 989fea2973152cc3e566b26bd0d0bc9b4731e97c28d40942b379a03351d19a10 https://codeberg.org/forgejo/forgejo/releases/download/v7.0.3/forgejo-src-7.0.3.tar.gz : CHECKSUM(SHA256) this package : c9e85222eb27508e74a284cb125df7c6d7cfc31f52c62f1e305d2aeb1bdb7abc CHECKSUM(SHA256) upstream package : c9e85222eb27508e74a284cb125df7c6d7cfc31f52c62f1e305d2aeb1bdb7abc Requires -------- forgejo (rpmlib, GLIBC filtered): /bin/sh git git-lfs Provides -------- forgejo: forgejo forgejo(x86-64) group(git) user(git) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name forgejo --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: fonts, Python, PHP, Perl, SugarActivity, R, Haskell, Java, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH