Warning: Permanently added '3.90.241.74' (ED25519) to the list of known hosts. You can reproduce this build on your computer by running: sudo dnf install copr-rpmbuild /usr/bin/copr-rpmbuild --verbose --drop-resultdir --srpm --task-url https://copr.fedorainfracloud.org/backend/get-srpm-build-task/10527893 Version: 1.8 PID: 12712 Logging PID: 12714 Task: {'appstream': True, 'background': True, 'build_id': 10527893, 'chroot': None, 'distributions_in_build': ['fedora-42', 'fedora-43', 'fedora-44', 'fedora-rawhide'], 'distributions_in_project': ['fedora-42', 'fedora-43', 'fedora-44', 'fedora-rawhide'], 'package_name': 'xournalpp', 'project_dirname': 'xournalpp', 'project_name': 'xournalpp', 'project_owner': 'luya', 'repos': [], 'sandbox': 'luya/xournalpp--https://api.github.com/users/bhennion', 'source_json': {'clone_url': 'https://github.com/xournalpp/xournalpp.git', 'committish': '86cec540b6e188d8f77d74c043fafa1279be353b', 'spec': 'rpm/fedora/xournalpp.spec', 'srpm_build_method': 'rpkg', 'subdirectory': '', 'type': 'git'}, 'source_type': 8, 'submitter': 'https://api.github.com/users/bhennion', 'task_id': '10527893'} Running: git clone https://github.com/xournalpp/xournalpp.git /var/lib/copr-rpmbuild/workspace/workdir-ipnemmia/xournalpp --depth 500 --no-single-branch --recursive cmd: ['git', 'clone', 'https://github.com/xournalpp/xournalpp.git', '/var/lib/copr-rpmbuild/workspace/workdir-ipnemmia/xournalpp', '--depth', '500', '--no-single-branch', '--recursive'] cwd: . rc: 0 stdout: stderr: Cloning into '/var/lib/copr-rpmbuild/workspace/workdir-ipnemmia/xournalpp'... Running: git checkout 86cec540b6e188d8f77d74c043fafa1279be353b -- cmd: ['git', 'checkout', '86cec540b6e188d8f77d74c043fafa1279be353b', '--'] cwd: /var/lib/copr-rpmbuild/workspace/workdir-ipnemmia/xournalpp rc: 0 stdout: stderr: Note: switching to '86cec540b6e188d8f77d74c043fafa1279be353b'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false HEAD is now at 86cec540b fix(pdf): return nullptr from getPage() when page index is out of bounds (#7485) Generated rpkg config: [rpkg] preprocess_spec = True [git] anon_clone_url = https://github.com/%(repo_path)s [lookaside] download_url = https://${git_props:remote_netloc}/repo/pkgs/%(repo_path)s/%(filename)s/%(hashtype)s/%(hash)s/%(filename)s Writing config into /var/lib/copr-rpmbuild/workspace/workdir-ipnemmia/.config/rpkg.conf Running: rpkg srpm --outdir /var/lib/copr-rpmbuild/results --spec /var/lib/copr-rpmbuild/workspace/workdir-ipnemmia/xournalpp/rpm/fedora/xournalpp.spec cmd: ['rpkg', 'srpm', '--outdir', '/var/lib/copr-rpmbuild/results', '--spec', '/var/lib/copr-rpmbuild/workspace/workdir-ipnemmia/xournalpp/rpm/fedora/xournalpp.spec'] cwd: /var/lib/copr-rpmbuild/workspace/workdir-ipnemmia/xournalpp rc: 0 stdout: Wrote: /var/lib/copr-rpmbuild/results/xournalpp.spec setting SOURCE_DATE_EPOCH=1725840000 Wrote: /var/lib/copr-rpmbuild/results/xournalpp-1.3.4^22.g86cec540b-1.src.rpm stderr: git_cwd_pack: archiving /var/lib/copr-rpmbuild/workspace/workdir-ipnemmia/xournalpp: commit 86cec540b6e188d8f77d74c043fafa1279be353b (HEAD, origin/release-1.3) Author: ChasingZenith Date: Sun May 31 17:02:32 2026 +0800 fix(pdf): return nullptr from getPage() when page index is out of bounds (#7485) Problem: PopplerGlibDocument::getPage() previously constructed a PopplerGlibPage object wrapping a null PopplerPage* when poppler_document_get_page() returned NULL (e.g. page index exceeded the document's page count). This produced a non-null shared_ptr to an invalid page, defeating all downstream null checks. Before-fix errors: PdfCache::render()'s null check passed despite the invalid page, then poppler_page_get_size() and other Poppler methods were called on NULL, triggering: Poppler-CRITICAL **: poppler_page_get_size: assertion 'POPPLER_IS_PAGE(page)' failed Impact: PdfCache::render() null-checks getPage()'s return value to render a gray background for missing pages: auto popplerPage = pdfDocument.getPage(pdfPageNo); if (!popplerPage) { renderMissingPdfPage(cr, pageWidth, pageHeight); return; } Since getPage() returned a non-null (but invalid) shared_ptr for out-of-bounds pages, this guard never triggered. Calling Poppler methods on the null PopplerPage* caused the render to fail with internal state corruption—not just for the missing page, but for subsequent renders of OTHER pages that shared the same cache or render context. Symptom: after PDF auto-reload reduced the page count (e.g. 3 pages → 2 pages), the out-of-bounds pages correctly showed gray background on initial render. However, the corrupted state from the failed render propagated to valid pages as well: on the next zoom in/out, even pages that still existed in the PDF also turned into gray backgrounds. Fix: return nullptr when poppler_document_get_page() returns NULL. All callers already handle null correctly; the old behavior violated the function's contract of returning a valid page or null, and the invalid object corrupted internal caches for unrelated pages. git_cwd_pack: Wrote: /var/lib/copr-rpmbuild/results/xournalpp-86cec540.tar.gz Output: ['xournalpp-86cec540.tar.gz', 'xournalpp-1.3.4^22.g86cec540b-1.src.rpm', 'xournalpp.spec'] Running SRPMResults tool Using distributions_in_build for this build. Extracting arch-specific tags for fedora-42 Extracting arch-specific tags for fedora-43 Extracting arch-specific tags for fedora-44 Extracting arch-specific tags for fedora-rawhide Package info: { "architecture_specific_tags": { "fedora-42": {}, "fedora-43": {}, "fedora-44": {}, "fedora-rawhide": {} }, "name": "xournalpp", "epoch": null, "version": "1.3.4^22.g86cec540b", "release": "1" } SRPMResults finished