This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'LicenseRef-NPSL-0.94'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/nmap, https://src.fedoraproject.org/tests/nmap See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Java/#_pre_built_dependencies ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF Unlimited License (with License Retention) and/or GNU General Public License and/or GNU Lesser General Public License [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v2.0 or later", "*No copyright* MIT License", "*No copyright* GNU Lesser General Public License, Version 2.1 and/or GNU Library General Public License, Version 2.0", "BSD 3-Clause License", "FSF Unlimited License (with License Retention) and/or GNU General Public License v2.0 or later [generated file]", "*No copyright* BSD 3-Clause License", "BSD-4-Clause (University of California-Specific)", "BSD 4-Clause License", "BSD 3-Clause License and/or GNU General Public License, Version 2", "Historical Permission Notice and Disclaimer - sell variant [generated file]", "NTP License", "BSD 2-Clause License", "MIT License", "FSF Unlimited License (with License Retention) [generated file]", "X11 License [generated file]", "FSF Unlimited License (with License Retention)", "zlib License", "ISC License", "*No copyright* GNU General Public License, Version 2", "Apache License 2.0", "*No copyright* X11 License", "GNU Lesser General Public License, Version 2.1", "*No copyright* BSD 2-Clause with views sentence", "GNU Library General Public License, Version 2.0", "*No copyright* Mozilla Public License 1.1", "OpenSSL License", "BSD 3-Clause License and/or BSD 4-Clause License and/or BSD-4-Clause (University of California-Specific)", "BSD 3-Clause License and/or BSD 4-Clause License", "GNU General Public License", "FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2", "GNU General Public License, Version 2", "FSF All Permissive License", "*No copyright* GNU General Public License", "*No copyright* Boost Software License 1.0", "Boost Software License 1.0", "*No copyright* zlib License". 2142 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/nmap/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/man/pt_PT/man1, /usr/share/man/ru/man1, /usr/share/man/it, /usr/share/man, /usr/lib, /usr/share/man/sk, /usr/share/licenses, /usr/share/man/fr, /usr/share/man/es, /usr/share/man/pt_BR/man1, /usr/share/man/pl, /usr/share/man/es/man1, /usr/share/man/man1, /usr, /usr/src, /usr/share/man/ja, /usr/share/man/zh/man1, /usr/share/man/de, /usr/share/man/sk/man1, /usr/share/man/hu, /usr/share/man/pt_BR, /usr/share/man/hr, /usr/share/man/hu/man1, /usr/share/man/fr/man1, /usr/share/man/it/man1, /usr/share, /usr/share/man/ja/man1, /usr/share/man/ro/man1, /usr/src/debug, /usr/share/man/de/man1, /usr/share/man/ro, /usr/bin, /usr/share/doc, /usr/share/man/ru, /usr/share/man/zh, /usr/share/man/pl/man1, /usr/share/man/pt_PT, /usr/share/man/hr/man1 [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/man/pt_PT/man1, /usr/share/man/hu, /usr/share/licenses, /usr/share/man/pt_BR, /usr/share/man/hr, /usr/share/man/fr, /usr/share/man/es, /usr/share/man/de/man1, /usr/share/man/pt_BR/man1, /usr/share/man/pl, /usr/share/man/hu/man1, /usr/share/man/es/man1, /usr/share/man/man1, /usr/share/man/ro, /usr/bin, /usr/share/doc, /usr, /usr/share/man/ru, /usr/share/man/zh, /usr/src, /usr/share/man/ja, /usr/share/man/fr/man1, /usr/share/man/it/man1, /usr/share/man/ru/man1, /usr/share/man/zh/man1, /usr/share/man/it, /usr/share/man/de, /usr/share/man/pl/man1, /usr/share/man, /usr/share, /usr/share/man/sk/man1, /usr/lib, /usr/share/man/ja/man1, /usr/share/man/pt_PT, /usr/share/man/ro/man1, /usr/share/man/hr/man1, /usr/src/debug, /usr/share/man/sk [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20638 bytes in 16 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Maven: [ ]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nmap- ncat [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua:, %define pixmap_srcdir zenmap/share/pixmaps [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Java: [ ]: Packages are noarch unless they use JNI Note: nmap subpackage is not noarch. Please verify manually [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 23224320 bytes in /usr/share nmap-7.95-1.fc40.x86_64.rpm:23142400 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: nmap-7.95-1.fc40.x86_64.rpm nmap-ncat-7.95-1.fc40.x86_64.rpm nmap-debuginfo-7.95-1.fc40.x86_64.rpm nmap-debugsource-7.95-1.fc40.x86_64.rpm nmap-7.95-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6vgrzbqd')] checks: 32, packages: 5 nmap-ncat.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/nmap-ncat/examples/logs/ascii-output nmap-ncat.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/nmap-ncat/examples/scripts/http-scan/scanner-output nmap-ncat.x86_64: W: spurious-executable-perm /usr/share/doc/nmap-ncat/examples/scripts/http-proxy nmap-ncat.x86_64: W: spurious-executable-perm /usr/share/doc/nmap-ncat/examples/scripts/http-scan/scan-example nmap.src: E: spelling-error ('identd', '%description -l en_US identd -> incident, evident, trident') nmap.src: E: spelling-error ('netcat', '%description -l en_US netcat -> net cat, net-cat, castanet') nmap.src: E: spelling-error ('ncat', '%description -l en_US ncat -> cat, cant, neat') nmap.src: E: spelling-error ('ndiff', '%description -l en_US ndiff -> niff, diff, n diff') nmap.src: E: spelling-error ('nping', '%description -l en_US nping -> ping, aping, oping') nmap.x86_64: E: spelling-error ('identd', '%description -l en_US identd -> incident, evident, trident') nmap.x86_64: E: spelling-error ('netcat', '%description -l en_US netcat -> net cat, net-cat, castanet') nmap.x86_64: E: spelling-error ('ncat', '%description -l en_US ncat -> cat, cant, neat') nmap.x86_64: E: spelling-error ('ndiff', '%description -l en_US ndiff -> niff, diff, n diff') nmap.x86_64: W: obsolete-not-provided nmap-frontend nmap.x86_64: W: obsolete-not-provided nmap-ndiff nmap-ncat.x86_64: W: non-executable-in-bin /usr/bin/nc 644 nmap.src: W: invalid-license LicenseRef-NPSL-0.94 nmap.x86_64: W: invalid-license LicenseRef-NPSL-0.94 nmap-debuginfo.x86_64: W: invalid-license LicenseRef-NPSL-0.94 nmap-debugsource.x86_64: W: invalid-license LicenseRef-NPSL-0.94 nmap-ncat.x86_64: W: invalid-license LicenseRef-NPSL-0.94 nmap.x86_64: W: devel-file-in-non-devel-package /usr/share/nmap/nselib/data/psexec/nmap_service.c nmap.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/nmap SSL_CTX_set_cipher_list nmap-ncat.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/ncat SSL_CTX_set_cipher_list nmap.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/nmap nmap.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/nping 5 packages and 0 specfiles checked; 9 errors, 17 warnings, 30 filtered, 9 badness; has taken 2.2 s Rpmlint (debuginfo) ------------------- Checking: nmap-debuginfo-7.95-1.fc40.x86_64.rpm nmap-ncat-debuginfo-7.95-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphil521wa')] checks: 32, packages: 2 nmap-debuginfo.x86_64: W: invalid-license LicenseRef-NPSL-0.94 nmap-ncat-debuginfo.x86_64: W: invalid-license LicenseRef-NPSL-0.94 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 22 filtered, 0 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "nmap-ncat". (none): E: there is no installed rpm "nmap-debuginfo". (none): E: there is no installed rpm "nmap-ncat-debuginfo". (none): E: there is no installed rpm "nmap-debugsource". (none): E: there is no installed rpm "nmap". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://svn.nmap.org/nmap/docs/nmap_gpgkeys.txt : CHECKSUM(SHA256) this package : 8cb20c4ea91db0e27b247e813a98a5dfe4d4548084abecab7ca9db51a49be8ba CHECKSUM(SHA256) upstream package : 8cb20c4ea91db0e27b247e813a98a5dfe4d4548084abecab7ca9db51a49be8ba https://nmap.org/dist/sigs/nmap-7.95.tar.bz2.asc : CHECKSUM(SHA256) this package : 8a6dd4c66aa78feb88ef38adf89c91bf089510e84ea9776308254c4843c72daf CHECKSUM(SHA256) upstream package : 8a6dd4c66aa78feb88ef38adf89c91bf089510e84ea9776308254c4843c72daf http://nmap.org/dist/nmap-7.95.tar.bz2 : CHECKSUM(SHA256) this package : e14ab530e47b5afd88f1c8a2bac7f89cd8fe6b478e22d255c5b9bddb7a1c5778 CHECKSUM(SHA256) upstream package : e14ab530e47b5afd88f1c8a2bac7f89cd8fe6b478e22d255c5b9bddb7a1c5778 Requires -------- nmap (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libpcap.so.1()(64bit) libpcre2-8.so.0()(64bit) libssh2.so.1()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) nmap-ncat rtld(GNU_HASH) nmap-ncat (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/alternatives libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libm.so.6()(64bit) libpcap.so.1()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) rtld(GNU_HASH) nmap-debuginfo (rpmlib, GLIBC filtered): nmap-debugsource (rpmlib, GLIBC filtered): Provides -------- nmap: nmap nmap(x86-64) nmap-ncat: nc nc6 ncat nmap-ncat nmap-ncat(x86-64) nmap-debuginfo: debuginfo(build-id) nmap-debuginfo nmap-debuginfo(x86-64) nmap-debugsource: nmap-debugsource nmap-debugsource(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: /var/lib/copr-rpmbuild/results/nmap/upstream- unpacked/Source0/nmap-7.95/libssh2/configure.ac:75 AM_CONFIG_HEADER found in: /var/lib/copr-rpmbuild/results/nmap/upstream- unpacked/Source0/nmap-7.95/libdnet-stripped/configure.in:11 AM_PROG_LIBTOOL found in: /var/lib/copr-rpmbuild/results/nmap/upstream- unpacked/Source0/nmap-7.95/libdnet-stripped/configure.in:36 Jar and class files in source ----------------------------- ./nmap-7.95/nselib/data/jdwp-class/JDWPSystemInfo.class ./nmap-7.95/nselib/data/jdwp-class/JDWPExecCmd.class Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nmap --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-40-x86_64 Active plugins: C/C++, Generic, Java, Shell-api Disabled plugins: SugarActivity, Perl, Python, Ocaml, fonts, PHP, Haskell, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH