This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/parallel-launcher/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - update-desktop-database must not be invoked in %post and %postun for Fedora 24 and later. Note: desktop file(s) with MimeType entry in parallel-launcher See: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#desktop- database ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License v3.0 or later", "*No copyright* GNU General Public License v3.0 or later", "MIT License", "Apache License 2.0", "GNU General Public License, Version 2". 585 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/parallel- launcher/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/parallel-launcher/translations, /usr/share/parallel-launcher [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor, /usr/share/parallel-launcher/translations, /usr/share/parallel- launcher, /usr/share/icons/hicolor/scalable/apps [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file Note: Found : Vendor: Matt Pharoah See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_tags_and_sections [!]: Uses parallel make %{?_smp_mflags} macro. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil} [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1433600 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: parallel-launcher-9.0.0-1.fc44.x86_64.rpm parallel-launcher-9.0.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqnjc72c3')] checks: 32, packages: 2 parallel-launcher.x86_64: W: unstripped-binary-or-object /usr/bin/parallel-launcher parallel-launcher.x86_64: W: unstripped-binary-or-object /usr/share/parallel-launcher/parallel-launcher-lsjs parallel-launcher.x86_64: W: unstripped-binary-or-object /usr/share/parallel-launcher/parallel-launcher-sdl-relay parallel-launcher.src: E: spelling-error ('homebrew', '%description -l en_US homebrew -> home brew, home-brew, hombre') parallel-launcher.src: E: spelling-error ('romhacking', '%description -l en_US romhacking -> tarmacking') parallel-launcher.x86_64: E: spelling-error ('homebrew', '%description -l en_US homebrew -> home brew, home-brew, hombre') parallel-launcher.x86_64: E: spelling-error ('romhacking', '%description -l en_US romhacking -> tarmacking') parallel-launcher.x86_64: E: script-without-shebang /usr/share/icons/hicolor/scalable/apps/ca.parallel_launcher.ParallelLauncher.svg parallel-launcher.x86_64: W: position-independent-executable-suggested /usr/bin/parallel-launcher parallel-launcher.x86_64: W: position-independent-executable-suggested /usr/share/parallel-launcher/parallel-launcher-lsjs parallel-launcher.x86_64: W: position-independent-executable-suggested /usr/share/parallel-launcher/parallel-launcher-sdl-relay parallel-launcher.x86_64: W: no-manual-page-for-binary parallel-launcher parallel-launcher.x86_64: W: no-documentation parallel-launcher.spec: W: no-%check-section parallel-launcher.src: W: invalid-license GPLv3 parallel-launcher.x86_64: W: invalid-license GPLv3 parallel-launcher.x86_64: W: incoherent-version-in-changelog 9.0.0 ['9.0.0-1.fc44', '9.0.0-1'] parallel-launcher.src: E: description-line-too-long ja Parallel Launcherは、リテール、自作を問わず、N64ゲームを可能な限りシンプルに、そしてアクセスしやすくすることを目的としたエミュレータランチャーです。Parallel LauncherはRetroArchエミュレータを使用しますが、分かりにくいメニューやコントローラの設定を、よりシンプルなユーザーインターフェースに置き換えます。また、オプションでromhacking.comとの統合も可能です。 parallel-launcher.x86_64: E: description-line-too-long ja Parallel Launcherは、リテール、自作を問わず、N64ゲームを可能な限りシンプルに、そしてアクセスしやすくすることを目的としたエミュレータランチャーです。Parallel LauncherはRetroArchエミュレータを使用しますが、分かりにくいメニューやコントローラの設定を、よりシンプルなユーザーインターフェースに置き換えます。また、オプションでromhacking.comとの統合も可能です。 parallel-launcher.x86_64: W: dangerous-command-in-%postun rm parallel-launcher.x86_64: E: arch-dependent-file-in-usr-share /usr/share/parallel-launcher/parallel-launcher-lsjs parallel-launcher.x86_64: E: arch-dependent-file-in-usr-share /usr/share/parallel-launcher/parallel-launcher-sdl-relay 2 packages and 0 specfiles checked; 9 errors, 13 warnings, 5 filtered, 9 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "parallel-launcher". ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s There are no files to process nor additional arguments. Nothing to do, aborting. Source checksums ---------------- https://gitlab.com/parallel-launcher/parallel-launcher/-/archive/v9.0-0/parallel-launcher-v9.0-0.tar.bz2 : CHECKSUM(SHA256) this package : 484ff98dd3b4096ee7007200c21288ca403d1277133510d3bc870188cce2165b CHECKSUM(SHA256) upstream package : 1909fdaa40a7302c47ea769803fc8120b43eb6189da77bfe82c39a31b72d6601 diff -r also reports differences Requires -------- parallel-launcher (rpmlib, GLIBC filtered): ((libQt6Core6 and libQt6Widgets6 and libQt6Network6 and libQt6Svg6 and libQt6DBus6) or (lib64qt6core6 and lib64qt6widgets6 and lib64qt6network6 and lib64qt6svg6 and lib64qt6dbus6) or (lib64Qt6Core and lib64Qt6Widgets and lib64Qt6Network and lib64Qt6Svg and lib64Qt6DBus) or (qt6-qtbase and (qt6-qtbase-common or libQt6Core) and qt6-qtdeclarative and qt6-qtsvg and (qt6-qdbus or qt6-tools-qdbus or qt6-qttools))) (coreutils or coreutils-common) (fuse3 or fuse) (libQt6Gui6 or qt6-qtbase-gui or lib64qt6gui6 or lib64Qt6Gui) (libgcc_s1 or libgcc) (libgcrypt or libgcrypt20) (libsqlite3-0 or sqlite-libs or lib64sqlite3) (libstdc++6 or libstdc++) (zlib-ng-compat or zlib or lib64zlib1 or lib64z1) /bin/sh /usr/bin/xdg-open dosfstools findutils glibc libGLX.so.0()(64bit) libOpenGL.so.0()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.10)(64bit) libQt6DBus.so.6()(64bit) libQt6DBus.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6Svg.so.6()(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgcrypt.so.20()(64bit) libgcrypt.so.20(GCRYPT_1.6)(64bit) libgpg-error.so.0()(64bit) libgpg-error.so.0(GPG_ERROR_1.0)(64bit) libm.so.6()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) p7zip polkit rtld(GNU_HASH) xdg-utils Provides -------- parallel-launcher: application() application(ca.parallel_launcher.ParallelLauncher.desktop) metainfo() metainfo(ca.parallel_launcher.ParallelLauncher.metainfo.xml) mimehandler(application/x-bps-patch) mimehandler(application/x-n64-rom) mimehandler(x-scheme-handler/rhdc) parallel-launcher parallel-launcher(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name parallel-launcher --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: R, Perl, SugarActivity, Python, PHP, Ocaml, fonts, Haskell, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH