This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in uwsm See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 73 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/uwsm/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/uwsm, /usr/share/uwsm/modules, /usr/libexec/uwsm [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/uwsm/modules, /usr/share/uwsm, /usr/libexec/uwsm [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 55707 bytes in 11 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in uwsm- devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: uwsm-0.27.0-2.fc43.x86_64.rpm uwsm-devel-0.27.0-2.fc43.x86_64.rpm uwsm-0.27.0-2.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4fk5np86')] checks: 32, packages: 3 uwsm.x86_64: W: symlink-to-binary-with-shebang /usr/share/uwsm/plugins/niri_session.sh is a link to a script (/usr/share/uwsm/plugins/niri.sh) but missing requires for /bin/false uwsm.x86_64: W: symlink-to-binary-with-shebang /usr/share/uwsm/plugins/start_hyprland.sh is a link to a script (/usr/share/uwsm/plugins/hyprland.sh) but missing requires for /bin/false uwsm.src: E: spelling-error ('waitpid', '%description -l en_US waitpid -> wapiti') uwsm.src: E: spelling-error ('overridable', '%description -l en_US overridable -> irrecoverable') uwsm.src: E: spelling-error ('autostart', '%description -l en_US autostart -> auto start, auto-start, autos tart') uwsm.src: E: spelling-error ('systemd', '%description -l en_US systemd -> systems, system, system d') uwsm.x86_64: E: spelling-error ('waitpid', '%description -l en_US waitpid -> wapiti') uwsm.x86_64: E: spelling-error ('overridable', '%description -l en_US overridable -> irrecoverable') uwsm.x86_64: E: spelling-error ('autostart', '%description -l en_US autostart -> auto start, auto-start, autos tart') uwsm.x86_64: E: non-executable-script /usr/share/uwsm/plugins/hyprland.sh 644 /bin/false uwsm.x86_64: E: non-executable-script /usr/share/uwsm/plugins/labwc.sh 644 /bin/false uwsm.x86_64: E: non-executable-script /usr/share/uwsm/plugins/mango.sh 644 /bin/false uwsm.x86_64: E: non-executable-script /usr/share/uwsm/plugins/niri.sh 644 /bin/false uwsm.x86_64: E: non-executable-script /usr/share/uwsm/plugins/sway.sh 644 /bin/false uwsm.x86_64: E: non-executable-script /usr/share/uwsm/plugins/wayfire.sh 644 /bin/false uwsm-devel.x86_64: W: no-documentation uwsm.x86_64: E: no-binary uwsm.spec: W: no-%check-section uwsm-devel.x86_64: W: description-shorter-than-summary uwsm.src: E: description-line-too-long Provides a set of Systemd units and helpers to set up the environment and manage standalone Wayland compositor sessions. uwsm.src: E: description-line-too-long Aside from environment setup/cleanup, it makes Systemd do most of the work and does not require any extra daemons running in background (except for a tiny waitpid process and a simple shell signal handler in the lightest case). uwsm.src: E: description-line-too-long This setup provides robust session management, overridable compositor- and session-aware environment management, XDG autostart, bi-directional binding with login session, clean shutdown, solutions for a set of small but annoying gotchas of systemd session management. uwsm.src: E: description-line-too-long For compositors this is an opportunity to offload: Systemd integration, session/XDG autostart management, Systemd/DBus activation environment interaction with its caveats. uwsm.x86_64: E: description-line-too-long Provides a set of Systemd units and helpers to set up the environment and manage standalone Wayland compositor sessions. uwsm.x86_64: E: description-line-too-long Aside from environment setup/cleanup, it makes Systemd do most of the work and does not require any extra daemons running in background (except for a tiny waitpid process and a simple shell signal handler in the lightest case). uwsm.x86_64: E: description-line-too-long This setup provides robust session management, overridable compositor- and session-aware environment management, XDG autostart, bi-directional binding with login session, clean shutdown, solutions for a set of small but annoying gotchas of systemd session management. uwsm.x86_64: E: description-line-too-long For compositors this is an opportunity to offload: Systemd integration, session/XDG autostart management, Systemd/DBus activation environment interaction with its caveats. 3 packages and 0 specfiles checked; 22 errors, 5 warnings, 12 filtered, 22 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "uwsm-devel". (none): E: there is no installed rpm "uwsm". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/Vladimir-csp/uwsm/archive/refs/tags/v0.27.0.tar.gz#/uwsm-0.27.0.tar.gz : CHECKSUM(SHA256) this package : 58cfb93773d2286a875c249ee4c8c59f71029c8f91c55e5f0fe50ca65c6f2e13 CHECKSUM(SHA256) upstream package : 58cfb93773d2286a875c249ee4c8c59f71029c8f91c55e5f0fe50ca65c6f2e13 Requires -------- uwsm (rpmlib, GLIBC filtered): /usr/bin/python3 /usr/bin/sh uwsm-devel (rpmlib, GLIBC filtered): uwsm Provides -------- uwsm: uwsm uwsm(x86-64) uwsm-devel: uwsm-devel uwsm-devel(x86-64) Generated by fedora-review 0.12.0 (a08f0fc) last change: 2026-09-18 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name uwsm --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-43-x86_64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, Perl, Java, Haskell, fonts, R, PHP, Ocaml, Python, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH, UNRETIREMENT