This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in openlogi See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "Apache License 2.0", "BSD 0-Clause License", "*No copyright* MIT License", "*No copyright* The Unlicense", "BSD 2-Clause License", "*No copyright* Apache License (v2.0) or MIT license and/or MIT License", "Apache License 2.0 and/or MIT License", "*No copyright* BSD 3-Clause License", "BSD 3-Clause License", "FSF All Permissive License", "*No copyright* zlib License", "zlib License", "Apache License (v2.0) or MIT license", "*No copyright* Apache License (v2.0) or MIT license", "*No copyright* BSD 3-Clause License and/or Creative Commons Attribution 3.0 and/or MIT License", "Apache License (v2.0) or MIT license and/or BSD 3-Clause License", "Unicode License Agreement - Data Files and Software (2016)", "*No copyright* Creative Commons CC0 1.0", "ISC License", "*No copyright* Apache License 2.0 and/or MIT License", "Apache License 2.0 and/or BSD 3-Clause License", "*No copyright* zlib License [generated file]", "*No copyright* Mozilla Public License 2.0", "*No copyright* SIL Open Font License", "Apache License 2.0 and/or GNU Lesser General Public License v2.1 or later and/or MIT License", "*No copyright* Boost Software License 1.0", "Apple Public Source License 2.0", "BSD 3-Clause License and/or MIT License", "Apache License (v2.0) or MIT license and/or MIT License", "Freetype Project License", "*No copyright* Apache License 2.0 and/or Public domain", "*No copyright* ISC License", "*No copyright* W3C License", "Apache License 2.0 [generated file]", "Apache License 2.0 and/or Boost Software License 1.0", "*No copyright* Public domain", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "Historical Permission Notice and Disclaimer - sell variant", "Freetype Project License [generated file]", "GNU General Public License, Version 2", "BSD 2-Clause with views sentence", "*No copyright* Creative Commons Attribution- ShareAlike 3.0", "Apache License 2.0 and/or BSD 2-Clause License", "FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2 [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "X11 License [generated file]", "GNU General Public License v2.0 or later", "Boost Software License 1.0", "MIT (old)", "Public domain", "MIT Open Group variant", "*No copyright* GNU General Public License, Version 2", "Freetype Project License and/or XFree86 License". 31934 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/openlogi/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev/rules.d, /usr/lib/udev [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 13702 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openlogi-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: openlogi-0.8.15-1.fc46.aarch64.rpm openlogi-devel-0.8.15-1.fc46.aarch64.rpm openlogi-0.8.15-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqewxixrw')] checks: 32, packages: 3 openlogi.aarch64: W: unstripped-binary-or-object /usr/bin/openlogi openlogi.aarch64: W: unstripped-binary-or-object /usr/bin/openlogi-agent openlogi-devel.aarch64: E: summary-too-long Development files for Local-first alternative to Logitech Options+ for HID++ devices openlogi.aarch64: E: spelling-error ('gpui', '%description -l en_US gpui -> GPU') openlogi.aarch64: E: spelling-error ('appicon', '%description -l en_US appicon -> app icon, app-icon, apportion') openlogi.aarch64: E: spelling-error ('vendored', '%description -l en_US vendored -> vendor ed, vendor-ed, vendor') openlogi.src: E: spelling-error ('systemd', '%description -l en_US systemd -> systems, system, system d') openlogi.src: E: spelling-error ('gpui', '%description -l en_US gpui -> GPU') openlogi.src: E: spelling-error ('appicon', '%description -l en_US appicon -> app icon, app-icon, apportion') openlogi.src: E: spelling-error ('vendored', '%description -l en_US vendored -> vendor ed, vendor-ed, vendor') openlogi.aarch64: W: no-manual-page-for-binary openlogi openlogi.aarch64: W: no-manual-page-for-binary openlogi-agent openlogi-devel.aarch64: W: no-documentation openlogi.spec: W: no-%check-section openlogi.spec: W: invalid-url Source1: openlogi-0.8.15-vendor.tar.gz openlogi-devel.aarch64: W: description-shorter-than-summary openlogi.aarch64: E: description-line-too-long OpenLogi is a local-first alternative to Logitech Options+ for HID++ devices: remap buttons, change DPI, and configure SmartShift from the command line or the background agent. No account and no telemetry; configuration lives in a plain TOML file. openlogi.aarch64: E: description-line-too-long This package ships the CLI and the background agent (a systemd user unit). Neither the GPUI desktop window nor the on-screen overlay is built: both depend on crates published only as git sources (gpui-kit, appicon), which cannot be vendored for offline COPR builds. openlogi.src: E: description-line-too-long OpenLogi is a local-first alternative to Logitech Options+ for HID++ devices: remap buttons, change DPI, and configure SmartShift from the command line or the background agent. No account and no telemetry; configuration lives in a plain TOML file. openlogi.src: E: description-line-too-long This package ships the CLI and the background agent (a systemd user unit). Neither the GPUI desktop window nor the on-screen overlay is built: both depend on crates published only as git sources (gpui-kit, appicon), which cannot be vendored for offline COPR builds. 3 packages and 0 specfiles checked; 12 errors, 8 warnings, 14 filtered, 12 badness; has taken 4.1 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "openlogi". (none): E: there is no installed rpm "openlogi-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/AprilNEA/OpenLogi/archive/refs/tags/v0.8.15.tar.gz#/openlogi-0.8.15.tar.gz : CHECKSUM(SHA256) this package : b426e9c8e4edae343409e81e818775138fc8a5baac0bca1c86f6e56e188a966d CHECKSUM(SHA256) upstream package : b426e9c8e4edae343409e81e818775138fc8a5baac0bca1c86f6e56e188a966d Requires -------- openlogi (rpmlib, GLIBC filtered): glibc ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) rtld(GNU_HASH) openlogi-devel (rpmlib, GLIBC filtered): openlogi Provides -------- openlogi: openlogi openlogi(aarch-64) openlogi-devel: openlogi-devel openlogi-devel(aarch-64) Generated by fedora-review 0.12.0 (a08f0fc) last change: 2026-09-18 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name openlogi --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-aarch64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Ocaml, Python, Java, R, Haskell, Perl, PHP, fonts, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH, UNRETIREMENT