{"object_kind":"push","event_name":"push","before":"3917235a2d9e276994ab2ecbd8319bc94c041ca0","after":"33f609984533a4921619fa1f66ec6b82e9dec7c6","ref":"refs/heads/nm-1-50","ref_protected":false,"checkout_sha":"33f609984533a4921619fa1f66ec6b82e9dec7c6","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"d775c3d256860d6b8662d1ffacd8d64d7799fb8c","message":"ndisc: honor default route parameters from RA route options\n\nRFC 4191 section-3.1 says:\n\n  When processing a Router Advertisement, a type C host first updates a\n  ::/0 route based on the Router Lifetime and Default Router Preference\n  in the Router Advertisement message header. [...] The Router Preference\n  and Lifetime values in a ::/0 Route Information Option override the\n  preference and lifetime values in the Router Advertisement header.\n\nFix the RA parsing so that the parameters from a default route option\nare applied to the gateway.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1666\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2072\n\nFixes: c3a4656a68f9 ('rdisc: libndp implementation')\n(cherry picked from commit 6c18fda5194d548e8620571353524b351fd02942)\n","title":"ndisc: honor default route parameters from RA route options","timestamp":"2024-12-18T10:11:17+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d775c3d256860d6b8662d1ffacd8d64d7799fb8c","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/ndisc/nm-lndp-ndisc.c"],"removed":[]},{"id":"b9a733d00b621408ed8a71a6be0f7b7f2fa77cd2","message":"bonding: steer IGMP queries to the active bond balance-slb primary port\n\nAdd chains and rules to steer the IGMP reports to the primary member\nport. This rules are adapted from the script provided by Eric Garver.\n\nhttps://gitlab.com/egarver/virtual-networking/-/blob/master/mlag.sh\n\nFixes: e9268e392418 ('firewall: add mlag firewall utils for multi chassis link aggregation (MLAG) for bonding-slb')\n(cherry picked from commit c691dd7ecfe3532a6bf5fa5a3a4e8d828d5a5176)\n","title":"bonding: steer IGMP queries to the active bond balance-slb primary port","timestamp":"2024-12-18T10:12:21+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b9a733d00b621408ed8a71a6be0f7b7f2fa77cd2","author":{"name":"Fernando Fernandez Mancera","email":"ffmancera@riseup.net"},"added":[],"modified":["src/core/nm-firewall-utils.c","src/core/tests/test-core.c"],"removed":[]},{"id":"a53349fa9c8e529462b606fa3deb7dcac92952d3","message":"libnmc: fix bug checking VersionInfo's capabilities\n\nRemove the `+ 31u` that was making that it would search for bit 1 at\narray's element 1, instead of element 0. Fixed comparison >len that\nshoudl be >=len. Fix a few typos.\n\nFixes: bc6098d44106 ('libnm: add internal nmc_client_has_{version_info_v,version_info_capability,capability}() helper')\n(cherry picked from commit 5a65170b49d38f5195da900f63710c847ce3364e)\n","title":"libnmc: fix bug checking VersionInfo's capabilities","timestamp":"2024-12-18T10:14:28+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a53349fa9c8e529462b606fa3deb7dcac92952d3","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/libnm-client-aux-extern/nm-libnm-aux.c","src/libnm-client-impl/nm-client.c"],"removed":[]},{"id":"9682c81ea66581d31514c64c2f86016aabd00081","message":"platform: rename NM_IP_ROUTE_TABLE_SYNC_MODE_FULL -> ALL_EXCEPT_LOCAL\n\nThe difference between FULL and ALL was not obvious without reading the\ndocumentation. Moreover, a new mode is going to be introduced so the\nconfusion could grow. Rename to a more explicit name.\n\n(cherry picked from commit e1840ad5fbe4684cb8fce4a638617729969255e5)\n","title":"platform: rename NM_IP_ROUTE_TABLE_SYNC_MODE_FULL -> ALL_EXCEPT_LOCAL","timestamp":"2024-12-18T10:14:59+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9682c81ea66581d31514c64c2f86016aabd00081","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/libnm-platform/nm-platform.c","src/libnm-platform/nmp-base.h"],"removed":[]},{"id":"7f6e84b26eaaabcd046b5c547824fffcba706051","message":"l3cfg: remove routes added by NM on reapply\n\nBy default, on reapply we were only syncing the main routes table. This\ncauses that routes added by NM to other tables are not removed on\nreapply. This was done to preserve routes added externally, but routes\nadded by NM itself should be removed.\n\nAdd a new route table syncing mode \"main + NM routes\". This mode\nmaintains the normal behaviour of syncing completely the main table,\nand for other tables removes only routes that were added by us, leaving\nthe rest untouched. Use this mode by default, as this is what a user\nwould expect on reapply.\n\nNote: this might not work if NM is restarted between the profile being\nmodified and the reapply, because NM forgets what routes were added by\nitself because of the restart. This is a rare corner case, though.\n\nUse the D-Bus property \"VersionInfo\" to expose a capability flag\nindicating that this bug is fixed. It is the first capability that we\nexpose in this way. However, it is convenient to do it this way as it's\nsomething that clients like nmstate needs to know, so they can decide\nwhether a conn down is needed or not. It is not enough to decide that by\nversion number because it might be fixed via a downstream patch in distros\nlike RHEL.\n\nhttps://issues.redhat.com/browse/RHEL-67324\nhttps://issues.redhat.com/browse/RHEL-66262\n\nFixes: e9c17fcc9b33 ('l3cfg: default to 'main' route table sync mode')\n(cherry picked from commit e330eb9c4a721d158641701cb48cd8094246d258)\n","title":"l3cfg: remove routes added by NM on reapply","timestamp":"2024-12-18T10:20:37+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/7f6e84b26eaaabcd046b5c547824fffcba706051","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/nm-l3cfg.c","src/core/nm-manager.c","src/libnm-core-public/nm-dbus-interface.h","src/libnm-platform/nm-platform.c","src/libnm-platform/nm-platform.h","src/libnm-platform/nmp-base.h"],"removed":[]},{"id":"f59a26b1b14b037131b87ae7e6f040e61eeb4716","message":"l3cfg: get routes to prune from the list of routes configured by NM\n\nWe always sync routes in the main table, but routes in tables other\nthan main are only pruned if were added by NM, by default. Get the list\nof routes to prune from other tables using obj_state->os_nm_configured,\nas this tracks what routes were effectively added by NM.\n\nThe list should be the same that the one obtained from l3cfg_old. It\ncould be different if we commited the l3cfg with an NMIPRouteTableSyncMode\nof NM_IP_ROUTE_TABLE_SYNC_MODE_MAIN, thus not deleting some routes at\ncommit time. However, since the previous commit, we never do it.\n\nWhat all this shows is that starting to use different NMIPRouteTableSyncModes\nis probably a bad idea: it will be a source of bugs of routes not being\nalways synced as users expect, and the use case for them is still to be\nknown.\n\n(cherry picked from commit c06d130c38a4d4238e18c06f0152f8f1a6bafa7f)\n","title":"l3cfg: get routes to prune from the list of routes configured by NM","timestamp":"2024-12-18T10:20:40+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/f59a26b1b14b037131b87ae7e6f040e61eeb4716","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/nm-l3cfg.c"],"removed":[]},{"id":"57fc79695007b718a755db5e493413c85930fdd7","message":"merge: branch 'ih/rt-leftover'\n\nl3cfg: remove routes added by NM on reapply\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2080\n(cherry picked from commit 3bcbe6ed01c0e1a635cf160d2a25e84cc5651ca9)\n","title":"merge: branch 'ih/rt-leftover'","timestamp":"2024-12-18T11:14:23+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/57fc79695007b718a755db5e493413c85930fdd7","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-l3cfg.c","src/core/nm-manager.c","src/libnm-client-aux-extern/nm-libnm-aux.c","src/libnm-client-impl/nm-client.c","src/libnm-core-public/nm-dbus-interface.h","src/libnm-platform/nm-platform.c","src/libnm-platform/nm-platform.h","src/libnm-platform/nmp-base.h"],"removed":[]},{"id":"8887af2574b4dc865d6fb185babdd03ccb77d61f","message":"libnm-core: improve keyfile documentation\n\nClarify the special behavior of some keyfile options.\n\n(cherry picked from commit dfe93983063f7e61e6bc25e63936a80ac2244b37)\n","title":"libnm-core: improve keyfile documentation","timestamp":"2024-12-18T11:16:28+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/8887af2574b4dc865d6fb185babdd03ccb77d61f","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-connection.c","src/libnm-core-impl/nm-setting-infiniband.c","src/libnm-core-impl/nm-setting-ip4-config.c","src/libnm-core-impl/nm-setting-ip6-config.c"],"removed":[]},{"id":"b461997ccd0ff467e2aaf167cdbc9b330548f0e3","message":"libnm: fix warnings due to invalid \"closure\" annotation\n\nThe \"closure\" annotation needs to be set on the callback parameter\ninstead of on the data for the callback function.\n\nThis patch fixes the following warning:\n\n\"\"\"\n../src/libnm-core-impl/nm-utils.c:3632: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:4778: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:5776: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:5849: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:5976: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:6091: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:6448: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:6521: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:6581: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:6663: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-client.c:6728: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-secret-agent-old.c:974: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-secret-agent-old.c:1014: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-secret-agent-old.c:1041: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-secret-agent-old.c:974: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-secret-agent-old.c:1014: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n../src/libnm-client-impl/nm-secret-agent-old.c:1041: Warning: NM: invalid \"closure\" annotation: only valid on callback parameters\n\"\"\"\n\n(cherry picked from commit dd9aca4bd91b906b792cf7c2e6dc9d9bee359cc2)\n","title":"libnm: fix warnings due to invalid \"closure\" annotation","timestamp":"2024-12-18T11:16:44+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b461997ccd0ff467e2aaf167cdbc9b330548f0e3","author":{"name":"Fernando Fernandez Mancera","email":"ffmancera@riseup.net"},"added":[],"modified":["src/libnm-client-impl/nm-client.c","src/libnm-client-impl/nm-secret-agent-old.c","src/libnm-core-impl/nm-utils.c"],"removed":[]},{"id":"429a4d1996c17572d77f04e4f7aea3cef648d1c8","message":"l3cfg: never retry ACD on NOARP interfaces\n\nAfter upgrading to RHEL-9.4, customers have reported that `ip monitor`\nrepeatedly logs the same route additions every 30 seconds. This issue\nappears to stem from NetworkManager continually retrying to add the same\nroutes due to keep retrying Address Conflict Detection (ACD) on NOARP\ninterfaces.\n\nTo prevent unnecessary route additions and reduce log noise, this change\nmodifies NetworkManager's behavior to stop retrying ACD on interfaces\nwith the NOARP flag.\n\nThis fix addresses route instability and excessive logging for affected\nNOARP configurations.\n\nhttps://issues.redhat.com/browse/RHEL-59125\n(cherry picked from commit 883399606f9e7807f59cdd1523926bc28989b51f)\n","title":"l3cfg: never retry ACD on NOARP interfaces","timestamp":"2024-12-18T11:16:58+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/429a4d1996c17572d77f04e4f7aea3cef648d1c8","author":{"name":"Wen Liang","email":"wenliang@redhat.com"},"added":[],"modified":["src/core/nm-l3cfg.c"],"removed":[]},{"id":"33f609984533a4921619fa1f66ec6b82e9dec7c6","message":"device: support IPv6 EUI64 link-local address for ipv6 tunnels\n\nCurrently, if a IPv6 tunnel device is configured to use an EUI64\nlink-local address (via per-connection or global configuration), the\nIPv6 configuration fails because NM cannot determine an interface\nidentifier.\n\nGenerate the interface identifier use the same mechanism [1] as\nkernel, which relies on the fake \"permanent\" address and treats the\ninterface as Ethernet.\n\n[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv6/addrconf.c?h=v6.11#n2364\n\nFixes-test: @iptunnel_ip6gre_create_device\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2065\n(cherry picked from commit 293282595285a82b7a29480575c5dd07249fffd8)\n","title":"device: support IPv6 EUI64 link-local address for ipv6 tunnels","timestamp":"2024-12-18T11:17:49+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/33f609984533a4921619fa1f66ec6b82e9dec7c6","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]}],"total_commits_count":11,"push_options":{},"repository":{"name":"NetworkManager","url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}