{"object_kind":"push","event_name":"push","before":"b4e8edbc8acea46b7a35fd399eadb6810d607277","after":"384dd7d5f2c5d08ea52516f7b614c0b88dd72c01","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"384dd7d5f2c5d08ea52516f7b614c0b88dd72c01","message":null,"user_id":94562,"user_name":"Íñigo Huguet","user_username":"ihuguet","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/94562/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"f2a2e49d0701025e9856bade75cfcc8cd2980294","message":"Revert \"policy: refresh IPv4 forwarding after connection activation and disconnection\"\n\nThis reverts commit 2ad5fbf0253d6f915a0e8815ca70ba4d9ec41648.\n\nIt is actually a partial revert. The changes to documentation don't need\nto be reverted.\n\nFixes: 2ad5fbf0253d ('policy: refresh IPv4 forwarding after connection activation and disconnection')\n","title":"Revert \"policy: refresh IPv4 forwarding after connection activation and disconnection\"","timestamp":"2025-10-24T05:27:18+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/f2a2e49d0701025e9856bade75cfcc8cd2980294","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/devices/nm-device.h","src/core/nm-policy.c"],"removed":[]},{"id":"d58d0a793e41e8740898929647a95f292b8ad9b3","message":"ip: restore IP forwarding on device deconfiguration\n\nWith the ipv4.forwarding property we may modify the forwarding sysctl of\nthe device on activation. In next commits, we will also modify it if the\nconnection is shared, instead of modifying the global forwarding.\n\nRestore the forwarding value to the default one when the device is\ndeconfigured for any reason.\n\nFixes: a8a2e6d727f0 ('ip-config: Support configuring per-device IPv4 sysctl forwarding option')\n","title":"ip: restore IP forwarding on device deconfiguration","timestamp":"2025-10-24T05:27:18+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d58d0a793e41e8740898929647a95f292b8ad9b3","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"8faa33b9d4419938198110210f20480cd0d3158c","message":"manager: add sharing-ipv4-changed signal\n\nThis signal notifies about the \"sharing state\", that's it, when there\nis at least one shared connection active or not. Each device informs\nto nm_manager when a shared connection is activated or deactivated\nand nm_manager emits this signal when the first shared connection is\nactivated or the last one is deactivated.\n\nFor now we're only interested in IPv4 forwarding as it's the only one\nthat we need to track from nm_device (in following commits).\n\nFixes: a8a2e6d727f0 ('ip-config: Support configuring per-device IPv4 sysctl forwarding option')\n","title":"manager: add sharing-ipv4-changed signal","timestamp":"2025-10-24T05:27:18+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/8faa33b9d4419938198110210f20480cd0d3158c","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/nm-manager.c","src/core/nm-manager.h"],"removed":[]},{"id":"32cbf4c629a3f857c7fa2e77e73a7c63942a6383","message":"ip: shared: stop using the global forwarding\n\nAs we introduced the ipv4.forwarding property in a8a2e6d727f0 ('ip-config:\nSupport configuring per-device IPv4 sysctl forwarding option'), we must\nnot enable or disable the global forwarding setting in the kernel, as it\naffects to all the devices, maybe forcing them to behave in a way\ndifferent to what the user requested in ipv4.forwarding.\n\nInstead, we need to selectively enable or disable the per-device forwarding\nsettings. Specifically, only devices activated with ipv4.forwarding=auto\nmust have their forwarding enabled or disabled depending on shared\nconnections. Devices with yes/no must not be affected by shared connections.\n\nAlso, devices with ipv4.forwarding=auto must get the proper forwarding value\non activation, but also change it when shared connections appear or\ndisappear dynamically. Use the new sharing-ipv4-change signal from\nnm_manager to achieve it.\n\nFixes: a8a2e6d727f0 ('ip-config: Support configuring per-device IPv4 sysctl forwarding option')\n","title":"ip: shared: stop using the global forwarding","timestamp":"2025-10-24T05:27:18+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/32cbf4c629a3f857c7fa2e77e73a7c63942a6383","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"e06aaba1ca36209480845fcb74fd80875a95d3c0","message":"core: mark as managed-type=removed when unrealize\n\nThis is needed to ensure that the right CleanupType is chosen when\ncalling to nm_device_state_changed() a bit later. With this change\nCLEANUP_TYPE_REMOVED will be used instead of CLEANUP_TYPE_DECONFIGURE,\nwhich is wrong because the device has already disappeared.\n","title":"core: mark as managed-type=removed when unrealize","timestamp":"2025-10-24T05:27:18+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/e06aaba1ca36209480845fcb74fd80875a95d3c0","author":{"name":"Íñigo Huguet","email":"ihuguet@riseup.net"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"384dd7d5f2c5d08ea52516f7b614c0b88dd72c01","message":"merge: branch 'ih/forwarding'\n\ncore: ip forwarding: improve performance setting IPv4 forwarding for method=shared and forwarding=auto\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2201","title":"merge: branch 'ih/forwarding'","timestamp":"2025-10-24T05:27:36+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/384dd7d5f2c5d08ea52516f7b614c0b88dd72c01","author":{"name":"Íñigo Huguet","email":"ihuguet@riseup.net"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/devices/nm-device.h","src/core/nm-manager.c","src/core/nm-manager.h","src/core/nm-policy.c"],"removed":[]}],"total_commits_count":6,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}