{"object_kind":"push","event_name":"push","before":"8e0825f9cd4f9a8d923abba4c7a69ce9b700b273","after":"a2d147366cdb3f788efa95b501af51c951656ed1","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"a2d147366cdb3f788efa95b501af51c951656ed1","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"3a4e18e30205b958ced44382313586e6858cc027","message":"nmcli: fix \"device wifi connect\" command with existing connection\n\nExecuting this command twice, or when a connection profile already\nexists for the SSID:\n\n  nmcli device wifi connect $SSID password $PASSWORD\n\nreturns error:\n\n  Error: 802-11-wireless-security.key-mgmt: property is missing.\n\nWhen setting the password nmcli was wiping the existing wireless\nsecurity setting.\n\nFixes: c8ff1b30fba3 ('nmcli/dev: use secret agent for nmcli d [wifi] connect')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1688\n","title":"nmcli: fix \"device wifi connect\" command with existing connection","timestamp":"2025-12-17T10:55:50+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/3a4e18e30205b958ced44382313586e6858cc027","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/nmcli/devices.c"],"removed":[]},{"id":"427a7cf2577868cd70556923a88312a68f939009","message":"nmcli: start the agent only after updating the connection\n\nWhen connecting to a wifi network and providing the password on the\ncommand line, nmcli first looks if there is a compatible connection to\nreuse. If there is not, it creates and activates a new one via a\nsingle call to AddAndActivate().\n\nIf there is a compatible connection, nmcli first calls Update() on it\nto set the new password and then Activate() to bring it up. Before\nthat, it registers a secret agent that can prompt for a new password\nin case of authentication failure.\n\nHowever, as soon as nmcli registers a secret agent, NM tries to\nactivate again the connection if it was blocked due to a previous\nauthentication failure. This connection attempt is going to fail\nbecause it still uses the old password, as new one hasn't been set via\nUpdate().\n\nChange the order of operations to register the agent after Update()\nand before Activate().\n\nReproducer:\n\n nmcli device wifi connect SSID password BAD_PASSWORD\n nmcli device wifi connect SSID password GOOD_PASSWORD\n\nFixes: c8ff1b30fba3 ('nmcli/dev: use secret agent for nmcli d [wifi] connect')\n","title":"nmcli: start the agent only after updating the connection","timestamp":"2025-12-17T10:55:51+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/427a7cf2577868cd70556923a88312a68f939009","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/nmcli/devices.c"],"removed":[]},{"id":"a2d147366cdb3f788efa95b501af51c951656ed1","message":"Merge branch 'bg/issue1688'\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2323\n","title":"Merge branch 'bg/issue1688'","timestamp":"2025-12-17T11:59:20+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a2d147366cdb3f788efa95b501af51c951656ed1","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/nmcli/devices.c"],"removed":[]}],"total_commits_count":3,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}