{"object_kind":"push","event_name":"push","before":"92d53749ebf22997e55d818fb531ac5caecc39e7","after":"6e533dcb721ce9baaa7f2f0fdc6bd02c85b7f0bf","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"6e533dcb721ce9baaa7f2f0fdc6bd02c85b7f0bf","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"0639bb6c8b9fc34c8cbd4b40789f59a6571a41dd","message":"core: fix again l3cd comparison\n\nWhen only one of the two default routes is set, a NULL pointer is\ndereferenced:\n\n Thread 1 \"NetworkManager\" received signal SIGSEGV, Segmentation fault.\n nm_l3_config_data_cmp_full (a=a@entry=0x4e2bde0, b=0x4e87330, flags=flags@entry=40) at ../src/core/nm-l3-config-data.c:2622\n 2622\t                    NMPlatformIP4Route ra = def_route_a->ip4_route;\n\n (gdb) bt\n 0  nm_l3_config_data_cmp_full (a=a@entry=0x4e2bde0, b=0x4e87330, flags=flags@entry=40) at ../src/core/nm-l3-config-data.c:2622\n 1  in nm_dns_manager_set_ip_config (self=0x4db7520, addr_family=2, source_tag=0x4eb80a0, l3cd=0x4e2bde0, ip_config_type=NM_DNS_IP_CONFIG_TYPE_DEFAULT, replace_all=1)\n     at ../src/core/dns/nm-dns-manager.c:2109\n 2  in nm_dns_manager_set_ip_config (self=0x4db7520, addr_family=addr_family@entry=0, source_tag=source_tag@entry=0x4eb80a0, l3cd=l3cd@entry=0x4e2bde0,\n     ip_config_type=NM_DNS_IP_CONFIG_TYPE_DEFAULT, replace_all=replace_all@entry=1) at ../src/core/dns/nm-dns-manager.c:2059\n 3  in device_l3cd_changed (device=0x4eb80a0, l3cd_old=0x4e87330, l3cd_new=0x4e2bde0, user_data=0x4da4548) at ../src/core/nm-policy.c:2518\n 4  in ffi_call_unix64 () from target:/lib64/libffi.so.8\n 5  in ffi_call_int.lto_priv () from target:/lib64/libffi.so.8\n 6  in ffi_call () from target:/lib64/libffi.so.8\n 7  in g_cclosure_marshal_generic_va () from target:/lib64/libgobject-2.0.so.0\n 8  in signal_emit_valist_unlocked () from target:/lib64/libgobject-2.0.so.0\n 9  in g_signal_emit_valist () from target:/lib64/libgobject-2.0.so.0\n 10 in g_signal_emit () from target:/lib64/libgobject-2.0.so.0\n 11 in _dev_l3_cfg_notify_cb (l3cfg=0x4e2af20, notify_data=0x7ffd2176dfb0, self=0x4eb80a0) at ../src/core/devices/nm-device.c:4997\n\nIf flag NM_L3_CONFIG_CMP_FLAGS_ROUTES is set, let\nnmp_object_cmp_full() compare the two routes and deal with NULL\nvalues.\n\nIf flag NM_L3_CONFIG_CMP_FLAGS_ROUTES_ID is set, check that both\nobjects are not NULL before accessing them.\n\nThe crash is only seen when the routes are equal (according to\n_dedup_multi_index_cmp(), which compares the network, metric and\nplen), and only one l3cd has a default route. Only routes in the main\ntable qualify as default routes.\n\nFixes: 0a02995175e0 ('core: fix l3cd comparison')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1902\n","title":"core: fix again l3cd comparison","timestamp":"2026-06-17T07:42:59+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/0639bb6c8b9fc34c8cbd4b40789f59a6571a41dd","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-l3-config-data.c","src/core/tests/test-core.c"],"removed":[]},{"id":"6e533dcb721ce9baaa7f2f0fdc6bd02c85b7f0bf","message":"merge: branch 'bg/issue1902'\n\ncore: fix again l3cd comparison\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2372","title":"merge: branch 'bg/issue1902'","timestamp":"2026-06-17T07:59:18+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/6e533dcb721ce9baaa7f2f0fdc6bd02c85b7f0bf","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-l3-config-data.c","src/core/tests/test-core.c"],"removed":[]}],"total_commits_count":2,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}