{"object_kind":"push","event_name":"push","before":"128b49fe2122d297e7c51e73834a269b6730399a","after":"20f975abe3e91a211a1f8a8115b6fce71ce70a64","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"20f975abe3e91a211a1f8a8115b6fce71ce70a64","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"eff8330b579c07f1f5338f50a459709727d690cf","message":"libnm-core: add missing flags check in .to_dbus_function()\n\nProperties that define a .to_dbus_function() as a D-Bus override, need\nto return early if the flags only ask to serialize secrets.\n\nFixes: 7fb23b0a62a0 ('libnm: add NMIPRoutingRule API')\n","title":"libnm-core: add missing flags check in .to_dbus_function()","timestamp":"2026-02-24T08:46:32+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/eff8330b579c07f1f5338f50a459709727d690cf","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-ip-config.c"],"removed":[]},{"id":"db0825a110b24b755d3dab5df4381959b693ba9e","message":"settings: accept not-saved secrets from agents without modify-system\n\nThe \"modify.system\" polkit permission allows a user to modify settings\nfor connection profiles that belong to all users.\n\nFor this reason, when an agent returns system secrets (i.e. secrets\nthat are going to be stored to disk), NetworkManager checks that the\nagent has the modify.system permission.\n\nIf a secret has the AGENT_OWNED flag, it's stored in the agent\nitself. If the secret has the NOT_SAVED flag, it will be asked to\nusers at the beginning of every connection attempt.\n\nIn both those cases the profile is not modified and there is no need\nfor the modify.system permission. Fix the check to also consider the\nNOT_SAVED flag.\n","title":"settings: accept not-saved secrets from agents without modify-system","timestamp":"2026-02-24T08:46:32+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/db0825a110b24b755d3dab5df4381959b693ba9e","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/settings/nm-settings-connection.c"],"removed":[]},{"id":"024360bffa1d0848f2acb0d4eabefedf1b5f8787","message":"settings: fix check on existing system secrets\n\nThe previous check was based only on the presence of a non-NULL\n\"existing_secrets\" GVariant. That GVariant is created via:\n\n  nm_connection_to_dbus(nm_settings_connection_get_connection(self),\n                        NM_CONNECTION_SERIALIZE_WITH_SECRETS_SYSTEM_OWNED)\n\nThe function returns a GVariant containing a first-level dictionary\nfor each setting, even for those that doesn't contain any secrets. As\na result, the check was requiring the system.modify permission even if\nthere weren't any cached secrets to send to the agent.\n\nFix the check to actually check for the presence of any secrets in the\ncached dictionary. Some connection types have a third-level\ndictionary that can be empty, for example VPNs have vpn.secrets.\n","title":"settings: fix check on existing system secrets","timestamp":"2026-02-25T09:05:04+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/024360bffa1d0848f2acb0d4eabefedf1b5f8787","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/settings/nm-agent-manager.c"],"removed":[]},{"id":"20f975abe3e91a211a1f8a8115b6fce71ce70a64","message":"merge: branch 'bg/secret-permissions'\n\nFix the handling of permissions for connection secrets\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2367","title":"merge: branch 'bg/secret-permissions'","timestamp":"2026-02-25T08:24:10+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/20f975abe3e91a211a1f8a8115b6fce71ce70a64","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/settings/nm-agent-manager.c","src/core/settings/nm-settings-connection.c","src/libnm-core-impl/nm-setting-ip-config.c"],"removed":[]}],"total_commits_count":4,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}